-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: refactor wds menu and related components, widgets (#33703)
## Description 1. WDS menu component has been completely refactored. WDS headless component has been removed, we use `react-aria-components` instead. The menu component now has the ability to use submenus and icons for items. 2. Rename components `ActionGroup` to `ToolbarButtons and `ButtonGroup` to `InlineButtons` 3. Make API of the `ToolbarButtons`, `Menu`, `InlineButtons`, `Select` consistent. 4. Cosmetic refactoring of `ToolbarButtons` and `InlineButtons` and related widgets. Fixes: #32299 #32109 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9210315418> > Commit: b11c002 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9210315418&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No --------- Co-authored-by: Pawan Kumar <[email protected]>
- Loading branch information
Showing
84 changed files
with
2,286 additions
and
2,457 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 0 additions & 66 deletions
66
app/client/packages/design-system/headless/src/components/Menu/src/Menu.tsx
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
app/client/packages/design-system/headless/src/components/Menu/src/MenuItem.tsx
This file was deleted.
Oops, something went wrong.
27 changes: 0 additions & 27 deletions
27
app/client/packages/design-system/headless/src/components/Menu/src/MenuList.tsx
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
app/client/packages/design-system/headless/src/components/Menu/src/index.ts
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
app/client/packages/design-system/headless/src/components/Menu/src/types.ts
This file was deleted.
Oops, something went wrong.
76 changes: 0 additions & 76 deletions
76
app/client/packages/design-system/headless/src/components/Menu/stories/Menu.stories.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.