Skip to content

Commit

Permalink
chore: Removing usage of action right pane component (#37020)
Browse files Browse the repository at this point in the history
## Description

Removing usage of action right pane component to use Module inputs form
directly as right pane on EE.

Fixes [#36898](#36898)

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11475223785>
> Commit: e404221
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11475223785&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 23 Oct 2024 08:15:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Simplified rendering of action sections in the `CommonEditorForm` and
`EditorJSONtoForm` components by removing the `ActionRightPane`
component.
  
- **Bug Fixes**
- No bug fixes were implemented; overall functionality remains
consistent.

- **Refactor**
- Enhanced component structure for better direct manipulation of action
sections.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
ankitakinger authored Oct 23, 2024
1 parent 371b523 commit 7515500
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
5 changes: 1 addition & 4 deletions app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {
getHasManageActionPermission,
} from "ee/utils/BusinessFeatures/permissionPageHelpers";
import { ApiEditorContext } from "./ApiEditorContext";
import ActionRightPane from "components/editorComponents/ActionRightPane";
import RunHistory from "ee/components/RunHistory";
import { HintMessages } from "PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/HintMessages";
import { InfoFields } from "PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/InfoFields";
Expand Down Expand Up @@ -347,9 +346,7 @@ function CommonEditorForm(props: CommonFormPropsWithExtraParams) {
<RunHistory />
</SecondaryWrapper>
</div>
<ActionRightPane
additionalSections={actionRightPaneAdditionSections}
/>
{actionRightPaneAdditionSections}
</Wrapper>
</Form>
</MainContainer>
Expand Down
3 changes: 1 addition & 2 deletions app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
import { useParams } from "react-router";
import type { AppState } from "ee/reducers";
import { thinScrollbar } from "constants/DefaultTheme";
import ActionRightPane from "components/editorComponents/ActionRightPane";
import type { ActionResponse } from "api/ActionAPI";
import type { Plugin } from "api/PluginApi";
import type { UIComponentTypes } from "api/PluginApi";
Expand Down Expand Up @@ -377,7 +376,7 @@ export function EditorJSONtoForm(props: Props) {
<RunHistory />
</SecondaryWrapper>
</div>
<ActionRightPane additionalSections={actionRightPaneAdditionSections} />
{actionRightPaneAdditionSections}
</Wrapper>
</QueryFormContainer>
);
Expand Down

0 comments on commit 7515500

Please sign in to comment.