Skip to content

Commit

Permalink
chore: Updating types for support on EE (#37077)
Browse files Browse the repository at this point in the history
## Description

Updating types for support on EE

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11504079730>
> Commit: 05b133e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11504079730&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 24 Oct 2024 17:57:37 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced type safety for `PackageSearchItem` and `WorkflowSearchItem`
components through updated and exported interfaces.
- **Refactor**
- Updated component prop interfaces for better clarity and
maintainability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
ankitakinger authored Oct 25, 2024
1 parent 839e89e commit cd26aed
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions app/client/src/ce/pages/common/PackageSearchItem.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
interface Props {
// TODO: Fix this the next time the file is edited
// eslint-disable-next-line @typescript-eslint/no-explicit-any
searchedPackages: any;
import type { Package } from "ee/constants/PackageConstants";

export interface PackageSearchItemProps {
searchedPackages: Package[];
}

const PackageSearchItem = (props: Props) => {
const PackageSearchItem = (props: PackageSearchItemProps) => {
// eslint-disable-next-line
const { searchedPackages } = props;

Expand Down
4 changes: 2 additions & 2 deletions app/client/src/ce/pages/common/WorkflowSearchItem.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import type { Workflow } from "ee/constants/WorkflowConstants";

interface Props {
export interface WorkflowSearchItemProps {
workflowsList: Workflow[];
}

const WorkflowSearchItem = (props: Props) => {
const WorkflowSearchItem = (props: WorkflowSearchItemProps) => {
// eslint-disable-next-line
const { workflowsList } = props;

Expand Down

0 comments on commit cd26aed

Please sign in to comment.