Skip to content

Commit

Permalink
fix: overflow hidden was restricting the visibility of show bindings …
Browse files Browse the repository at this point in the history
…menu (#35609)

## Description
There was an IDE PR : #35114
, that got merged which added the `overflow: hidden` property to the
entity explorer which made the show bindings menu disappear from the
view port. Hence, that change is fixed with this PR.


Fixes #35584
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10347893824>
> Commit: 05dd349
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10347893824&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Mon, 12 Aug 2024 08:12:07 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **User Interface Changes**
- Adjusted the rendering behavior of the editor pane, allowing overflow
content to be visible, which may enhance the user experience within the
IDE.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
AmanAgarwal041 authored Aug 12, 2024
1 parent b8df54c commit d03278a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion app/client/src/pages/Editor/IDE/EditorPane/Explorer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const EditorPaneExplorer = () => {
}
className="relative ide-editor-left-pane__content"
flexDirection="column"
overflow="hidden"
width={
ideViewMode === EditorViewMode.FullScreen
? DEFAULT_EXPLORER_PANE_WIDTH
Expand Down
1 change: 0 additions & 1 deletion app/client/src/pages/Editor/IDE/EditorPane/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ const EditorPane = () => {
// @ts-expect-error Fix this the next time the file is edited
gap="spacing-2"
height="100%"
overflow="hidden"
width={width}
>
<EditorPaneExplorer />
Expand Down

0 comments on commit d03278a

Please sign in to comment.