reverting double click changes on entity item

app/client/packages/design-system/ads/src/List/List.tsx

@@ -105,6 +105,14 @@ function ListItem(props: ListItemProps) {
     }
   });
 
+  const handleDoubleClick = useEventCallback((e: React.MouseEvent) => {
+    e.stopPropagation();
+
+    if (!props.isDisabled && props.onDoubleClick) {
+      props.onDoubleClick();
+    }
+  });
+
   const handleRightControlClick = useEventCallback((e: React.MouseEvent) => {
     e.stopPropagation();
   });
@@ -119,6 +127,7 @@ function ListItem(props: ListItemProps) {
       data-testid={props.dataTestId}
       id={props.id}
       onClick={handleOnClick}
+      onDoubleClick={handleDoubleClick}
       role="listitem"
       size={size}
     >

app/client/packages/design-system/ads/src/List/List.types.tsx

@@ -12,6 +12,8 @@ export interface ListItemProps {
   rightControlVisibility?: "hover" | "always";
   /** callback for when the list item is clicked */
   onClick: (e: MouseEvent) => void;
+  /** callback for when the list item is double-clicked */
+  onDoubleClick?: () => void;
   /** Whether the list item is disabled. */
   isDisabled?: boolean;
   /** Whether the list item is selected. */

app/client/packages/design-system/ads/src/Templates/EditableEntityName/EditableEntityName.tsx

@@ -16,7 +16,6 @@ export const EditableEntityName = (props: EditableEntityNameProps) => {
     isFixedWidth,
     isLoading,
     name,
-    onDoubleClick,
     onExitEditing,
     onNameSave,
     size = "small",
@@ -81,7 +80,6 @@ export const EditableEntityName = (props: EditableEntityNameProps) => {
           inputRef={inputRef}
           isEditable={inEditMode}
           kind={size === "small" ? "body-s" : "body-m"}
-          onDoubleClick={onDoubleClick}
         >
           {editableName}
         </Styled.Text>

app/client/packages/design-system/ads/src/Templates/EditableEntityName/EditableEntityName.types.ts

@@ -23,6 +23,4 @@ export interface EditableEntityNameProps {
   onNameSave: (name: string) => void;
   /** Function to validate the name. */
   validateName: (name: string) => string | null;
-  /** callback for when the list item is double-clicked */
-  onDoubleClick?: (e: React.MouseEvent) => void;
 }

app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.tsx

@@ -3,7 +3,6 @@ import { ListItem } from "../../../List";
 import type { EntityItemProps } from "./EntityItem.types";
 import clx from "classnames";
 import { EditableEntityName } from "../../EditableEntityName";
-import { useEventCallback } from "usehooks-ts";
 
 export const EntityItem = (props: EntityItemProps) => {
   const {
@@ -19,15 +18,6 @@ export const EntityItem = (props: EntityItemProps) => {
 
   const inEditMode = canEdit ? isEditing : false;
 
-  const handleDoubleClick = useEventCallback((e: React.MouseEvent) => {
-    e.preventDefault();
-    e.stopPropagation();
-
-    if (!props.isDisabled && props.onDoubleClick) {
-      props.onDoubleClick(e);
-    }
-  });
-
   // Use List Item custom title prop to show the editable name
   const customTitle = useMemo(() => {
     return (
@@ -38,7 +28,6 @@ export const EntityItem = (props: EntityItemProps) => {
         isFixedWidth
         isLoading={isLoading}
         name={props.title}
-        onDoubleClick={handleDoubleClick}
         onExitEditing={onEditComplete}
         onNameSave={onNameSave}
         size="medium"

app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.types.ts

@@ -7,8 +7,6 @@ export interface EntityItemProps
   > {
   /** ID of the entity. Will be added to the markup for identification */
   id: string;
-  /** callback for when the list item is double-clicked */
-  onDoubleClick?: (e: React.MouseEvent) => void;
   /** Control the name editing behaviour */
   nameEditorConfig: {
     // Set editable based on user permissions