Add more button tests

appsmithorg · Jul 8, 2024 · f2d0e9f · f2d0e9f
1 parent e26ee7a
commit f2d0e9f
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/app/client/src/IDE/Components/Sidebar/SidebarButton/SidebarButton.test.tsx b/app/client/src/IDE/Components/Sidebar/SidebarButton/SidebarButton.test.tsx
@@ -3,6 +3,7 @@ import React from "react";
 import SidebarButton, { type SidebarButtonProps } from "./SidebarButton";
 
 import { Condition } from "../../../enums";
+import userEvent from "@testing-library/user-event";
 
 const sidebarButtonProps: SidebarButtonProps = {
   icon: "down-arrow",
@@ -24,4 +25,27 @@ describe("SidebarButton", () => {
     const svgs = container.querySelectorAll("svg");
     expect(svgs).toHaveLength(2);
   });
+
+  it("should call onClick with urlSuffix", async () => {
+    const checkOnClick = {
+      ...sidebarButtonProps,
+      onClick: jest.fn(),
+    };
+    const { getByRole } = render(<SidebarButton {...checkOnClick} />);
+
+    await userEvent.click(getByRole("button"));
+    expect(checkOnClick.onClick).toHaveBeenCalledWith(checkOnClick.urlSuffix);
+  });
+
+  it("should not call onClick when button is already selected", async () => {
+    const withSelected = {
+      ...sidebarButtonProps,
+      selected: true,
+      onClick: jest.fn(),
+    };
+    const { getByRole } = render(<SidebarButton {...withSelected} />);
+
+    await userEvent.click(getByRole("button"));
+    expect(withSelected.onClick).not.toHaveBeenCalled();
+  });
 });
diff --git a/app/client/src/IDE/Components/Sidebar/SidebarButton/SidebarButton.tsx b/app/client/src/IDE/Components/Sidebar/SidebarButton/SidebarButton.tsx
@@ -85,6 +85,7 @@ function SidebarButton(props: SidebarButtonProps) {
           className={`t--sidebar-${title || tooltip}`}
           data-selected={selected}
           onClick={handleOnClick}
+          role="button"
           selected={selected}
         >
           <Icon name={icon} size="lg" />