Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Error is not displayed when function is with same name #23720

Closed
1 task done
AnandiKulkarni opened this issue May 25, 2023 · 5 comments · Fixed by #23865
Closed
1 task done

[Bug]: Error is not displayed when function is with same name #23720

AnandiKulkarni opened this issue May 25, 2023 · 5 comments · Fixed by #23865
Assignees
@ohansFavour
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Javascript Product Issues related to users writing javascript in appsmith JS Linting & Errors Issues related to JS Linting and errors JS Objects Issues related to JS Objects Needs RCA a critical or high priority issue that needs an RCA Query & JS Pod Issues related to the query & JS Pod Regressed Scenarios that were working before but have now regressed

Comments

@AnandiKulkarni
Copy link

AnandiKulkarni commented May 25, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

JSfunction with same name should throw error

image

Steps To Reproduce

  1. Add two jsfunction with same name, it should throw error- This is not working

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

cloud
@AnandiKulkarni AnandiKulkarni added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage JS Objects Issues related to JS Objects labels May 25, 2023
@github-actions github-actions bot added the Javascript Product Issues related to users writing javascript in appsmith label May 25, 2023
@bharath31
Copy link

@ohansFavour could you please investigate why a lint error isn't being thrown?

@bharath31 bharath31 added JS Linting & Errors Issues related to JS Linting and errors and removed Needs Triaging Needs attention from maintainers to triage labels May 26, 2023
@ohansFavour
Copy link
Contributor

@bharath31 this is a regression caused by the linting of individual properties of the JSObject, instead of the Object as a whole.

@ohansFavour ohansFavour added the Regressed Scenarios that were working before but have now regressed label May 28, 2023
@bharath31 bharath31 added the Needs RCA a critical or high priority issue that needs an RCA label May 29, 2023
@bharath31
Copy link

@ohansFavour could you please run an RCA and fix this in the upcoming sprints?

@bharath31 bharath31 mentioned this issue Jun 2, 2023
Closed
1 task
@iSatVeerSingh
Copy link
Contributor

@bharath31 @ohansFavour I want to work on this. Could you please help me regarding, where is the code for linting in codebase.

@ohansFavour
Copy link
Contributor

@iSatVeerSingh thanks for showing interest in this issue. Unfortunately, we are making a change to the architecture for linting. As a result, this issue will be picked up by an internal member of the team.

@ohansFavour ohansFavour mentioned this issue Jun 15, 2023
Merged
19 tasks
ohansFavour added a commit that referenced this issue Jul 5, 2023
@ohansFavour @iamakulov
feat: Improve Linting performance (#23865)
e6f2dca 
## Description
This PR introduces a new architecture, making evaluation and linting
independent.

<img width="500" alt="Screenshot 2023-07-04 at 17 24 40"
src="https://github.com/appsmithorg/appsmith/assets/46670083/00b1eab9-cd79-4442-b51a-5345c2d6c4da">


In the previous architecture, one dependency graph was used to hold the
relationship between entities in the application and subsequently, the
"evaluation order" and "paths to lint" were generated.

Although similar, the dependency graph required for evaluation and
linting differ. For example, trigger fields should not depend on any
other entity/entity path in the eval's dependency graph since they are
not reactive. This is not the case for the linting dependency graph.

## Performance

- This PR introduces "lint only" actions. These actions trigger linting,
but not evaluation. For example, UPDATE_JS_ACTION_BODY_INIT (which is
fired immediately after a user edits the body of a JS Object). Since
linting fires without waiting for a successful update on the server,
**response time decreases by 40%** (from 2s to 1.2s).


- Reduction in time taken to generate paths requiring linting.

<img width="715" alt="Screenshot 2023-07-04 at 18 10 52"
src="https://github.com/appsmithorg/appsmith/assets/46670083/d73a4bfc-de73-4fa7-bdca-af1e5d8ce8a1">



#### PR fixes following issue(s)
Fixes #23447 
Fixes #23166
Fixes #24194 
Fixes #23720 
Fixes #23868 
Fixes #21895 

Latest DP: https://appsmith-r3f9e325p-get-appsmith.vercel.app/



#### Type of change

- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan

#23865 (comment)
>
>
#### Issues raised during DP testing

#23865 (comment)
response:
#23865 (comment)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [x] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: arunvjn <[email protected]>
Co-authored-by: Ivan Akulov <[email protected]>
@Nikhil-Nandagopal Nikhil-Nandagopal added the Query & JS Pod Issues related to the query & JS Pod label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohansFavour ohansFavour

Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Javascript Product Issues related to users writing javascript in appsmith JS Linting & Errors Issues related to JS Linting and errors JS Objects Issues related to JS Objects Needs RCA a critical or high priority issue that needs an RCA Query & JS Pod Issues related to the query & JS Pod Regressed Scenarios that were working before but have now regressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Improve Linting performance appsmithorg/appsmith
8 participants
@Nikhil-Nandagopal @ravikp7 @bharath31 @Druthi @satbir121 @ohansFavour @AnandiKulkarni @iSatVeerSingh