Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Back button doesn't work as expected, when copy pasting the Workspace Settings page URL #34431

Closed
1 task done
samhithav27 opened this issue Jun 24, 2024 · 4 comments
Closed
1 task done

[Bug]: Back button doesn't work as expected, when copy pasting the Workspace Settings page URL #34431

samhithav27 opened this issue Jun 24, 2024 · 4 comments
Assignees
@Nikhil-Nandagopal @pranavkanade @infinitetrooper @riteshkew
Labels
Bug Something isn't working Community Reported issues reported by community members Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Platform Administration Pod Issues related to platform administration & management Production Workspace Product Issues related to workspaces

Comments

@samhithav27
Copy link

samhithav27 commented Jun 24, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

When I am on some other URL (eg: google.com), and I paste the Workspace Settings page URL onto the browser (eg: https://appsmith.z-apps.io/workspace/665da9a39f855f14f89855c7/settings/members)
and then when I click on the Back button
I'm redirected to my previous URL (eg: google.com)
It should redirect me to the Workspaces Page

Steps To Reproduce

  1. Go to some random URL
  2. Copy https://appsmith.z-apps.io/workspace/{workspace-id}/settings/members
  3. Paste the above URL to a browser and click enter
  4. Click on back button
  5. You will be redirected to the URL in point 1

Public Sample App

No response

Environment

Release

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

v1.28
@samhithav27 samhithav27 added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Jun 24, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Community Reported issues reported by community members Medium Issues that frustrate users due to poor UX Release Workspace Product Issues related to workspaces labels Jun 24, 2024
@github-actions github-actions bot added the Platform Administration Pod Issues related to platform administration & management label Jun 25, 2024
@Nikhil-Nandagopal
Copy link
Contributor

Bumping this issue up to prod because it should have made it's way there by now if it was not fixed

@saicharan-zemoso
Copy link
Contributor

saicharan-zemoso commented Jul 31, 2024 •
edited
Loading

Hello @Nikhil-Nandagopal @samhithav27 , can I work on this issue ?
solution:
The back button which is used in multiple places is accepting a prop "goTo" and if noting is sent then it is going back in history.
back button used:
https://github.com/appsmithorg/appsmith/blob/release/app/client/src/components/utils/helperComponents.tsx#L42-L51

so we can pass the path so that would append to the history and redirect to that previous page insted of going back in the history.

@saicharan-zemoso
Copy link
Contributor

The same component was used in workspace setting, user profile page, members setting page for workspace,etc. so we can see the same behaviour in all this pages.

@saicharan-zemoso saicharan-zemoso mentioned this issue Aug 27, 2024
Merged
@ankitakinger ankitakinger mentioned this issue Sep 3, 2024
Closed
2 tasks
abhvsn pushed a commit that referenced this issue Sep 4, 2024
@saicharan-zemoso
fix: fixed back button to redirect to applications page (#35900)
420dc9b 
added the changes to redirect to application pages instead of going back
in the history.

issue: [#34431](#34431)

fixed the navigation to not go back in history
The navigation of the back button used to go back in history. Now it
will be redirected to the expected page.

added the test for profile page:

![image](https://github.com/user-attachments/assets/18dcd56f-dab9-4b9c-8ade-9976b96a361f)

added the tests for settings page:

![image](https://github.com/user-attachments/assets/869fd21a-edf3-4ec9-ad68-bf3eea5d54e1)

video:


https://github.com/user-attachments/assets/35a805ec-a579-4571-b4c6-e415f0f5c5f3



## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10659602683>
> Commit: 23f2285
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10659602683&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 02 Sep 2024 04:52:56 UTC
<!-- end of auto-generated comment: Cypress test results  -->





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced navigation for the BackButton in both UserProfile and
Settings components, directing users to the applications page and
specific workspace pages, respectively.

- **Bug Fixes**
- Improved test coverage for BackButton interactions in both UserProfile
and Settings components, ensuring correct navigation behavior is
verified.

- **Tests**
- Expanded test suite for UserProfile and Settings components,
incorporating better routing and interaction simulations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@ankitakinger
Copy link
Contributor

This was completed with #35900

Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@saicharan-zemoso @Shivam-z
fix: fixed back button to redirect to applications page (appsmithorg#…
791477d 
…35900)

added the changes to redirect to application pages instead of going back
in the history.

issue: [appsmithorg#34431](appsmithorg#34431)

fixed the navigation to not go back in history
The navigation of the back button used to go back in history. Now it
will be redirected to the expected page.

added the test for profile page:

![image](https://github.com/user-attachments/assets/18dcd56f-dab9-4b9c-8ade-9976b96a361f)

added the tests for settings page:

![image](https://github.com/user-attachments/assets/869fd21a-edf3-4ec9-ad68-bf3eea5d54e1)

video:


https://github.com/user-attachments/assets/35a805ec-a579-4571-b4c6-e415f0f5c5f3



## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10659602683>
> Commit: 23f2285
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10659602683&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 02 Sep 2024 04:52:56 UTC
<!-- end of auto-generated comment: Cypress test results  -->





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced navigation for the BackButton in both UserProfile and
Settings components, directing users to the applications page and
specific workspace pages, respectively.

- **Bug Fixes**
- Improved test coverage for BackButton interactions in both UserProfile
and Settings components, ensuring correct navigation behavior is
verified.

- **Tests**
- Expanded test suite for UserProfile and Settings components,
incorporating better routing and interaction simulations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikhil-Nandagopal Nikhil-Nandagopal

@pranavkanade pranavkanade

@infinitetrooper infinitetrooper

@riteshkew riteshkew

Labels
Bug Something isn't working Community Reported issues reported by community members Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Platform Administration Pod Issues related to platform administration & management Production Workspace Product Issues related to workspaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: shadow PR for external contribution 35900 appsmithorg/appsmith
7 participants
@Nikhil-Nandagopal @pranavkanade @infinitetrooper @riteshkew @ankitakinger @samhithav27 @saicharan-zemoso