Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mongodb collections are not in sorted order in schemas. #35842

Closed
1 task done
Naveen-Goud opened this issue Aug 22, 2024 · 8 comments · Fixed by #36062
Closed
1 task done

[Bug]: Mongodb collections are not in sorted order in schemas. #35842

Naveen-Goud opened this issue Aug 22, 2024 · 8 comments · Fixed by #36062
Assignees
Labels
Bug Something isn't working Integrations Product Issues related to a specific integration Inviting Contribution Issues that we would like contributions to Low An issue that is neither critical nor breaks a user flow Mongo Issues related to Mongo DB plugin Needs Triaging Needs attention from maintainers to triage Query & JS Pod Issues related to the query & JS Pod

Comments

@Naveen-Goud
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

when we connect with mongodb database and execute any query the collections after getting from db are not in sorted order in schemas.

Steps To Reproduce

1.login into the appsmith application.

2.open the data tab in app and add mongodb data source.

3.add some collections in mongodb, ignore if present.

4.try to execute any query .

5.after that when we open the schemas , we observe that the collections are in not sorted manner.

Screenshot from 2024-08-05 16-07-18

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

release

@Naveen-Goud Naveen-Goud added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Aug 22, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Mongo Issues related to Mongo DB plugin label Aug 22, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod labels Aug 22, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow and removed Query & JS Pod Issues related to the query & JS Pod labels Aug 22, 2024
@github-actions github-actions bot added the Query & JS Pod Issues related to the query & JS Pod label Aug 22, 2024
@raushan3737
Copy link
Contributor

raushan3737 commented Aug 22, 2024

Hi @Nikhil-Nandagopal , @rohan-arthur, I would like to work on this Issue. Can i pick this issue?

@rohan-arthur rohan-arthur added the Inviting Contribution Issues that we would like contributions to label Aug 22, 2024
@rohan-arthur
Copy link
Contributor

sure, @raushan3737
In future, please pick one from this list: https://github.com/appsmithorg/appsmith/issues?q=is%3Aopen+is%3Aissue+label%3A%22Inviting+Contribution%22

For now, I've added the tag Inviting contribution to this issue as well.

@raushan3737
Copy link
Contributor

Sure @rohan-arthur, Thank you.
I have a small request for you and the team. If possible, could you please proceed with the other issue PRs that have been in an open state for weeks?
PR Link:
#35363
#35099
#34977
#35391

@rohan-arthur
Copy link
Contributor

@raushan3737 thanks, will remind the respective teams of these.

@NilanshBansal
Copy link
Contributor

@Naveen-Goud I assume you have already raised a fix for this issue in this PR -#35413
Also this issue is a duplicate of #28190

@NilanshBansal
Copy link
Contributor

@raushan3737 please don't work on this as the fix has already been raised in this PR -#35413

@Naveen-Goud
Copy link
Contributor Author

Hi @NilanshBansal , I have worked on issue #28190 , it was filtering in dropdown, but the in schemas the collections need to be sorted as the PR #35413 does solve sorting collectiond in schemas , it solves the filtering in drop down only.

so I have raised this bug.

@NilanshBansal
Copy link
Contributor

Thanks @Naveen-Goud I have reopened this issue and updated the original filtering issue.

@raushan3737 apologies for the confusion, you can go ahead working on this issue.

@nerbos nerbos closed this as completed in cdb22f4 Sep 25, 2024
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
### PR Description: 
- **File changes in the PR**:
  - Integrated the sorting feature to the mongo collections.
  - Added the unit test for sorting.

Fixes appsmithorg#35842

- **Snapshots**:
  
  **Before resolving bug:**
  

![image](https://github.com/user-attachments/assets/34c04ebc-e81b-480c-9a54-1b643b68ffb2)
  
  **After resolving bug:**
  

![image](https://github.com/user-attachments/assets/fd7155e1-e261-491a-b912-7d482b8a9386)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the MongoDB plugin to return collection names in a
case-insensitive sorted order, improving predictability and user
experience.
  
- **Tests**
- Added a new test to validate that collections returned by the plugin
are sorted correctly, ensuring consistent functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Integrations Product Issues related to a specific integration Inviting Contribution Issues that we would like contributions to Low An issue that is neither critical nor breaks a user flow Mongo Issues related to Mongo DB plugin Needs Triaging Needs attention from maintainers to triage Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
7 participants