Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: In the properties pane of the JSON Form widget, the icon is missing when binding data in the source data field. #36353

Closed
1 task done
phennapa-saeliw opened this issue Sep 17, 2024 · 1 comment · Fixed by #36703
Closed
1 task done

[Bug]: In the properties pane of the JSON Form widget, the icon is missing when binding data in the source data field. #36353

phennapa-saeliw opened this issue Sep 17, 2024 · 1 comment · Fixed by #36703
Assignees
@Nikhil-Nandagopal @rahulbarwal @somangshu @pranavkanade @jacquesikot @carinanfonseca
Labels
Bug Something isn't working Community Reported issues reported by community members Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage One-click Binding Issues related to the One click binding epic Production QA Pod Issues under the QA Pod QA Needs QA attention Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@phennapa-saeliw
Copy link
Contributor

phennapa-saeliw commented Sep 17, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

In the properties pane of the JSON Form widget, the icon is missing when binding data in the source data field.

2567-09-17 at 10 36

Steps To Reproduce

  1. Drag & drop Table and JSON Form widget on Canvas.
  2. Connect the data to the Table widget first.
  3. After that, click on the "Generate form" button to generate a form from the data in the table, but you will find that the icon is missing.

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

https://jam.dev/c/e4df3d6d-8892-4c74-8ac8-980f9c8ccadc

Version

Cloud - v1.41.0-SNAPSHOT
@phennapa-saeliw phennapa-saeliw added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Sep 17, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Community Reported issues reported by community members Low An issue that is neither critical nor breaks a user flow Production One-click Binding Issues related to the One click binding epic labels Sep 17, 2024
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Widgets & Accelerators Pod Issues related to widgets & Accelerators labels Sep 23, 2024
@Nikhil-Nandagopal
Copy link
Contributor

This seems to be an issue with the oneclick binding menu icon that is using a table icon that no longer exists

@jacquesikot jacquesikot self-assigned this Sep 24, 2024
@rahulbarwal rahulbarwal mentioned this issue Oct 4, 2024
Merged
2 tasks
rahulbarwal added a commit that referenced this issue Oct 7, 2024
@rahulbarwal @jacquesikot
fix: widget icon in Connect To options in oneclick binding menu (#36703)
d15eea3 
## Description
This pull request fixes the issue with the widget icon not displaying
correctly in the Connect To options.
The `useConnectToOptions` function now correctly retrieves the widget
config for the current widget and uses the `iconSVG` property from the
config to display the widget icon.


Fixes #`Issue Number`  
_or_  
Fixes #36353
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11208692370>
> Commit: 80a6355
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11208692370&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 07 Oct 2024 09:25:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced datasource selection validation by ensuring images associated
with queried items are present and valid.
- Improved icon retrieval for connectable widgets in the dropdown,
allowing for more accurate icon displays based on widget types.

- **Bug Fixes**
- Fixed icon rendering issues in dropdown options to ensure the correct
icons are displayed.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Jacques Ikot <[email protected]>
@appsmith-bot appsmith-bot added the QA Needs QA attention label Oct 7, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikhil-Nandagopal Nikhil-Nandagopal

@rahulbarwal rahulbarwal

@somangshu somangshu

@pranavkanade pranavkanade

@jacquesikot jacquesikot

@carinanfonseca carinanfonseca

Labels
Bug Something isn't working Community Reported issues reported by community members Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage One-click Binding Issues related to the One click binding epic Production QA Pod Issues under the QA Pod QA Needs QA attention Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: widget icon in Connect To options in oneclick binding menu appsmithorg/appsmith
8 participants
@Nikhil-Nandagopal @rahulbarwal @somangshu @pranavkanade @phennapa-saeliw @jacquesikot @appsmith-bot @carinanfonseca