Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Button sizes have changes #37623

Closed
1 task done
hetunandu opened this issue Nov 21, 2024 · 0 comments · Fixed by #37624
Closed
1 task done

[Bug]: Button sizes have changes #37623

hetunandu opened this issue Nov 21, 2024 · 0 comments · Fixed by #37624
Assignees
@hetunandu @momcilo-appsmith
Labels
ADS Components All issues related ADS components ADS Visual Styles All issues related to ADS visual styles Bug Something isn't working Design System Product Appsmith design system related issues IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Production QA Pod Issues under the QA Pod QA Needs QA attention

Comments

@hetunandu
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Description

After the min width update of ADS Button, there are a few places it looks odd and needs to be fixed

  • Workspace add button is tall
  • Debugger trigger in the bottom bar is very wide

Steps To Reproduce

Nov 19 Screenshot from Slack
Screenshot 2024-11-21 at 12 48 24 PM

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

Cloud
@hetunandu hetunandu added Bug Something isn't working ADS Components All issues related ADS components ADS Visual Styles All issues related to ADS visual styles labels Nov 21, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow Production labels Nov 21, 2024
@github-actions github-actions bot added the Design System Product Appsmith design system related issues label Nov 21, 2024
@hetunandu hetunandu mentioned this issue Nov 21, 2024
Merged
2 tasks
@hetunandu hetunandu added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Nov 21, 2024
@appsmith-bot appsmith-bot added the QA Needs QA attention label Nov 22, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Nov 22, 2024
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Nov 27, 2024
@hetunandu @sharat87
fix: Min width in certain ADS Button usage (appsmithorg#37624)
80da01d 
## Description

1. Remove height override in Workspace add button
2. Remove min width in Debugger trigger button 


Fixes appsmithorg#37623

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11953373643>
> Commit: 9acd2b9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11953373643&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 21 Nov 2024 13:18:43 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced new styled components for enhanced workspace layout:
`WorkspaceDropDown`, `WorkspaceSection`, and `ApplicationContainer`.
- Added functionality for creating and managing workspaces, including a
new button in the `LeftPaneSection`.
	- Enhanced application display logic based on Anvil feature status.

- **Bug Fixes**
- Improved error handling and state management for workspace and
application fetching.

- **Style**
- Updated `DebuggerTrigger` to use a new styled button for improved
design consistency.
- Customized button appearance in the debugger with a new styled
component.

- **Documentation**
- Enhanced overall component structure for better readability and
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Shrikant Sharat Kandula <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

@momcilo-appsmith momcilo-appsmith

Labels
ADS Components All issues related ADS components ADS Visual Styles All issues related to ADS visual styles Bug Something isn't working Design System Product Appsmith design system related issues IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Low An issue that is neither critical nor breaks a user flow Production QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Min width in certain ADS Button usage appsmithorg/appsmith
4 participants
@Nikhil-Nandagopal @hetunandu @appsmith-bot @momcilo-appsmith