Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: UI of Function names list items in the module instance editor seems broken and partially unclickable #38444

Closed
1 task done
kamakshibhat-appsmith opened this issue Jan 2, 2025 · 0 comments · Fixed by #38453
Closed
1 task done

[Bug]: UI of Function names list items in the module instance editor seems broken and partially unclickable #38444

kamakshibhat-appsmith opened this issue Jan 2, 2025 · 0 comments · Fixed by #38453
Assignees
@ankitakinger
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage QA Pod Issues under the QA Pod QA Needs QA attention Regressed Scenarios that were working before but have now regressed Release Blocker This issue must be resolved before the release Release

Comments

@kamakshibhat-appsmith
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

The UI of the function names list items in the module instance editor appears to be broken, making them partially or entirely unclickable.

Steps To Reproduce

Screenshot 2025-01-02 at 1 17 56 PM

Public Sample App

No response

Environment

Release

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Self-Hosted
@kamakshibhat-appsmith kamakshibhat-appsmith added Bug Something isn't working Regressed Scenarios that were working before but have now regressed Needs Triaging Needs attention from maintainers to triage IDE Navigation Issues/feature requests related to IDE navigation, and context switching labels Jan 2, 2025
@Nikhil-Nandagopal Nikhil-Nandagopal added High This issue blocks a user from building or impacts a lot of users Release labels Jan 2, 2025
@github-actions github-actions bot added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Jan 2, 2025
@kamakshibhat-appsmith kamakshibhat-appsmith changed the title [Bug]: UI of Function names list item in the module instance editor is broken and not clickable entirely [Bug]: UI of Function names list items in the module instance editor seems broken and partially unclickable Jan 2, 2025
@kamakshibhat-appsmith kamakshibhat-appsmith added Release Blocker This issue must be resolved before the release and removed High This issue blocks a user from building or impacts a lot of users labels Jan 2, 2025
@ankitakinger ankitakinger mentioned this issue Jan 2, 2025
Merged
2 tasks
ankitakinger added a commit that referenced this issue Jan 2, 2025
@ankitakinger
fix: Updating the click functionalities in list item component (#38453)
99a10e4 
## Description

Updating the click functionalities in list item component to fix the
partial clickable issue on JS module instance editor in EE.

Fixes [#38444](#38444)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12582242512>
> Commit: a936b58
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12582242512&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource, @tag.IDE`
> Spec:
> <hr>Thu, 02 Jan 2025 14:17:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed `description` and `descriptionType` properties from various
`List` component items across multiple components
- Simplified keyboard interaction model in `List` component by removing
keyboard event handling
- Modified click event handling in `ListItem` to focus on mouse
interactions

- **Bug Fixes**
	- Prevented event propagation for right control clicks in `ListItem`

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Jan 2, 2025
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Jan 2, 2025
ankitakinger added a commit that referenced this issue Jan 3, 2025
@ankitakinger
fix: Updating the click functionalities in list item component (#38453)
8fb677f 
## Description

Updating the click functionalities in list item component to fix the
partial clickable issue on JS module instance editor in EE.

Fixes [#38444](#38444)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12582242512>
> Commit: a936b58
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12582242512&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource, @tag.IDE`
> Spec:
> <hr>Thu, 02 Jan 2025 14:17:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed `description` and `descriptionType` properties from various
`List` component items across multiple components
- Simplified keyboard interaction model in `List` component by removing
keyboard event handling
- Modified click event handling in `ListItem` to focus on mouse
interactions

- **Bug Fixes**
	- Prevented event propagation for right control clicks in `ListItem`

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@ankitakinger ankitakinger mentioned this issue Jan 3, 2025
Merged
4 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@ankitakinger
fix: Updating the click functionalities in list item component (appsm…
d44f8d9 
…ithorg#38453)

## Description

Updating the click functionalities in list item component to fix the
partial clickable issue on JS module instance editor in EE.

Fixes [appsmithorg#38444](appsmithorg#38444)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12582242512>
> Commit: a936b58
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12582242512&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource, @tag.IDE`
> Spec:
> <hr>Thu, 02 Jan 2025 14:17:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed `description` and `descriptionType` properties from various
`List` component items across multiple components
- Simplified keyboard interaction model in `List` component by removing
keyboard event handling
- Modified click event handling in `ListItem` to focus on mouse
interactions

- **Bug Fixes**
	- Prevented event propagation for right control clicks in `ListItem`

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Needs Triaging Needs attention from maintainers to triage QA Pod Issues under the QA Pod QA Needs QA attention Regressed Scenarios that were working before but have now regressed Release Blocker This issue must be resolved before the release Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Updating the click functionalities in list item component appsmithorg/appsmith
4 participants
@Nikhil-Nandagopal @ankitakinger @appsmith-bot @kamakshibhat-appsmith