Code

feat: Improve Linting performance #23865

Code

Merged

ohansFavour merged 65 commits intoreleaseappsmithorg/appsmith:releasefrom feat/separate-linting-from-evalappsmithorg/appsmith:feat/separate-linting-from-evalCopy head branch name to clipboardJul 5, 2023

+2,087-438

Commits

Commits on Jul 4, 2023

• Use linting service

  ohansFavour

  committed
  477a150

  Copy full SHA for 477a150

• Fix file import issues

  ohansFavour

  committed
  c880818

  Copy full SHA for c880818

• Create first tree dependencyMap using graph

  ohansFavour

  committed
  69a3fbd

  Copy full SHA for 69a3fbd

• Complete dependency update flow

  ohansFavour

  committed
  d0e2b8f

  Copy full SHA for d0e2b8f

• Complete sort order

  ohansFavour

  committed
  049c514

  Copy full SHA for 049c514

• Add initialize method to linter

  ohansFavour

  committed
  3734a50

  Copy full SHA for 3734a50

• async function bound to sync fields

  ohansFavour

  committed
  86192d7

  Copy full SHA for 86192d7

• Replace classes

  ohansFavour

  committed
  263c16b

  Copy full SHA for 263c16b

• Refactor code

  ohansFavour

  committed
  dac1306

  Copy full SHA for dac1306

• Remove unsed utils

  ohansFavour

  committed
  5f98952

  Copy full SHA for 5f98952

• Fix race condition in dependency map update

  ohansFavour

  committed
  69ce3be

  Copy full SHA for 69ce3be

• Fix race condition in dependencyMap update

  ohansFavour

  committed
  73525e6

  Copy full SHA for 73525e6

• Add entity fns as async trigger

  ohansFavour

  committed
  ebc2521

  Copy full SHA for ebc2521

• Fix type minor bug

  ohansFavour

  committed
  ad8e10b

  Copy full SHA for ad8e10b

• Use cached entity in delete operation

  ohansFavour

  committed
  054f8a9

  Copy full SHA for 054f8a9

• Temp commit

  ohansFavour

  committed
  db4ac3f

  Copy full SHA for db4ac3f

• Populate old linting errors

  ohansFavour

  committed
  61d194a

  Copy full SHA for 61d194a

• Introduce hashed string in jsobject diff

  ohansFavour

  committed
  ea154e1

  Copy full SHA for ea154e1

• Initiate linting from main thread

  ohansFavour

  committed
  6f59363

  Copy full SHA for 6f59363

• Fix lint error during entity rename

  ohansFavour

  committed
  5d6b31f

  Copy full SHA for 5d6b31f

• Fix failing tests

  ohansFavour

  committed
  02160d5

  Copy full SHA for 02160d5

• Delete lintreev1

  ohansFavour

  committed
  40961f8

  Copy full SHA for 40961f8

• Show lint error when keys are duplicate

  ohansFavour

  committed
  672d5d1

  Copy full SHA for 672d5d1

• Fix failing test

  ohansFavour

  committed
  3f8d2e8

  Copy full SHA for 3f8d2e8

• Fix failing cypress tests

  ohansFavour

  committed
  9d1c4d2

  Copy full SHA for 9d1c4d2

• Inject parser and diffGenerator on entity creation

  ohansFavour

  committed
  106ad5b

  Copy full SHA for 106ad5b

• Improve linting performance

  ohansFavour

  committed
  5e1adca

  Copy full SHA for 5e1adca

• Fix failing cypress tests

  ohansFavour

  committed
  1902197

  Copy full SHA for 1902197

• Create uneval dataTree once per eval-lint cycle

  ohansFavour

  committed
  c2ad6cd

  Copy full SHA for c2ad6cd

• Move path functions to PathUtils class

  ohansFavour

  committed
  109679f

  Copy full SHA for 109679f

• Create parser and diff generator class

  ohansFavour

  committed
  2759920

  Copy full SHA for 2759920

• Files rename

  ohansFavour

  committed
  03b5a4a

  Copy full SHA for 03b5a4a

• variable rename

  ohansFavour

  committed
  3edeb13

  Copy full SHA for 3edeb13

• Fix cypress issues

  ohansFavour

  committed
  23385d1

  Copy full SHA for 23385d1

• Covert jsActionsInDataFields to a function

  ohansFavour

  committed
  b4ca211

  Copy full SHA for b4ca211

• Introduce lintService

  ohansFavour

  committed
  683e021

  Copy full SHA for 683e021

• Add cypress tests

  ohansFavour

  committed
  39241fe

  Copy full SHA for 39241fe

• temp commit

  

  arunvjn

  authored and

  ohansFavour

  committed
  01b9f27

  Copy full SHA for 01b9f27

• temp commit

  

  arunvjn

  authored and

  ohansFavour

  committed
  93df86a

  Copy full SHA for 93df86a

• Temp

  ohansFavour

  committed
  653700f

  Copy full SHA for 653700f

• Renamed functions

  Show description for 6052718
  

  arunvjn

  authored and

  ohansFavour

  committed
  6052718

  Copy full SHA for 6052718

• temp commit

  

  arunvjn

  authored and

  ohansFavour

  committed
  a9f91cd

  Copy full SHA for a9f91cd

• Types fix

  

  arunvjn

  authored and

  ohansFavour

  committed
  2262faa

  Copy full SHA for 2262faa

• Fix type issues

  ohansFavour

  committed
  ce4e57a

  Copy full SHA for ce4e57a

• Fix type issues

  ohansFavour

  committed
  435670c

  Copy full SHA for 435670c

• Parse js entities and update raw entity

  ohansFavour

  committed
  bef7baa

  Copy full SHA for bef7baa

• Add type to parsed entity

  ohansFavour

  committed
  7da442a

  Copy full SHA for 7da442a

• Code refactor

  ohansFavour

  committed
  c41012a

  Copy full SHA for c41012a

• generate async funcs after dependencyMap update

  ohansFavour

  committed
  23974ee

  Copy full SHA for 23974ee

• Add ".data" to all js functions

  ohansFavour

  committed
  d832b3f

  Copy full SHA for d832b3f

• Fix wrong lint error path

  ohansFavour

  committed
  7f37d28

  Copy full SHA for 7f37d28

• prevent cyclic deps

  ohansFavour

  committed
  8945a74

  Copy full SHA for 8945a74

• Add entity actions to isAsync check

  ohansFavour

  committed
  5b3d727

  Copy full SHA for 5b3d727

• Refactor code

  ohansFavour

  committed
  c203d4e

  Copy full SHA for c203d4e

• Fix type issues

  ohansFavour

  committed
  aaaf746

  Copy full SHA for aaaf746

• Add preprocess step to entityParser

  ohansFavour

  committed
  40f20f0

  Copy full SHA for 40f20f0

• Fix cypress test

  ohansFavour

  committed
  687c7e5

  Copy full SHA for 687c7e5

• Rename linter

  ohansFavour

  committed
  4b67bd3

  Copy full SHA for 4b67bd3

• preEvalLintingProcessor => evalAndLintingHandler

  ohansFavour

  committed
  d527be1

  Copy full SHA for d527be1

• Make lintFirstTree and LintUpdateTree private

  ohansFavour

  committed
  cd522a9

  Copy full SHA for cd522a9

• Fix minor issue with geolocation

  ohansFavour

  committed
  5257ebc

  Copy full SHA for 5257ebc

• Instrument linting

  ohansFavour

  committed
  fce8ec5

  Copy full SHA for fce8ec5

• Make first call non blocking

  ohansFavour

  committed
  9e9630b

  Copy full SHA for 9e9630b

Commits on Jul 5, 2023

• Rename the lint worker + add comments clarifying the significance of the name

  iamakulov

  committed
  98acded

  Copy full SHA for 98acded

• Disable preloading when running LinkRelPreload_Spec

  iamakulov

  committed
  e1b5045

  Copy full SHA for e1b5045