Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove BaseLinter implementation #25335

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

iamakulov
Copy link
Contributor

Description

This PR is a follow-up to #23865. It removes the main thread linter implementation which isn’t used today but does affect the bundle size, increasing it by ~1 MB of minified code:

CleanShot 2023-07-12 at 12 00 52@2x

Context: https://3perf.slack.com/archives/C01SGCF8PM0/p1689156352117669 (to open in Appsmith workspace, replace 3perf.slack.com with the Appsmith Slack domain)

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

  • Manual
  • Jest
  • Cypress

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

It’s not currently used (it only exists as an abstraction for the future), but it does currently have bundle size costs (~1 MB of minified code).

Context: https://3perf.slack.com/archives/C01SGCF8PM0/p1689156352117669 (to open in Appsmith workspace, replace `3perf.slack.com` with the Appsmith Slack domain)
@iamakulov iamakulov requested a review from ohansFavour July 12, 2023 12:50
@iamakulov
Copy link
Contributor Author

/ok-to-test

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5531809810.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25335.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25335&runId=5531809810_1

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5531809810.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js

  2. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePickerV2_Widget_Reskinning_spec.js
To know the list of identified flaky tests - Refer here

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5531809810.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Widgets/Filepicker/FilePickerV2_Widget_Reskinning_spec.js

To know the list of identified flaky tests - Refer here

@github-actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5531809810.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/FilePickerV2_Widget_Reskinning_spec.js

To know the list of identified flaky tests - Refer here

@SatishGandham
Copy link
Contributor

/ok-to-test

@SatishGandham SatishGandham merged commit 8fbfefe into perf/bundle-size-v2 Jul 12, 2023
@SatishGandham SatishGandham deleted the perf/remove-baselinter branch July 12, 2023 16:57
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5534341207.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25335.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25335&runId=5534341207_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants