-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove BaseLinter implementation #25335
Conversation
It’s not currently used (it only exists as an abstraction for the future), but it does currently have bundle size costs (~1 MB of minified code). Context: https://3perf.slack.com/archives/C01SGCF8PM0/p1689156352117669 (to open in Appsmith workspace, replace `3perf.slack.com` with the Appsmith Slack domain)
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5531809810. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5531809810.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5531809810.
To know the list of identified flaky tests - Refer here |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5531809810.
To know the list of identified flaky tests - Refer here |
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5534341207. |
Description
This PR is a follow-up to #23865. It removes the main thread linter implementation which isn’t used today but does affect the bundle size, increasing it by ~1 MB of minified code:
Context: https://3perf.slack.com/archives/C01SGCF8PM0/p1689156352117669 (to open in Appsmith workspace, replace
3perf.slack.com
with the Appsmith Slack domain)Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approved
label after Cypress tests were reviewedTest Plan Approved
label after JUnit tests were reviewed