-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allowing bottom tabs to be selectable as text #33263
Conversation
WalkthroughThe recent changes involve adding the Changes
Assessment against linked issues
The changes align with the requirements outlined in the linked issue by enhancing user experience through text selection capabilities, resolving the regression where copying error logs was not possible directly from the UI. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
/build-deploy-preview skip-tests=true recreate=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8997713589. |
Deploy-Preview-URL: https://ce-33263.dp.appsmith.com |
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8998822590. |
Deploy-Preview-URL: https://ce-33263.dp.appsmith.com |
…755-copyable-bottom-tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, can we explore if any tests can be added here?
…755-copyable-bottom-tab
…755-copyable-bottom-tab
Multiple components collapsible, json viewer etc inside this have |
…755-copyable-bottom-tab
…755-copyable-bottom-tab
…755-copyable-bottom-tab
Description
Enabling the bottom tabs overall for users to select the test for errors, response, logs etc. The tailwind css class
select-none
which was added to the whole of the application was getting applied to this area as well by inheriting the properties. Addedselect-text
property which enables the user to select anything inside the container as text.Fixes #32755
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.IDE"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9065702943
Commit: 9aeb5f4
Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?