chore: Remove unused ACL fields on User entity
#34634
Conversation
WalkthroughThe changes remove the Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- app/server/appsmith-server/src/main/java/com/appsmith/server/domains/User.java (1 hunks)
- app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/UsagePulseServiceCEImpl.java (1 hunks)
Additional comments not posted (2)
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/UsagePulseServiceCEImpl.java (1)
95-95: Verify the impact of removingupdateUser.setPolicies(null)The removal of setting user policies to null might have implications on the user policy management. Ensure that this change does not lead to unintended side effects.
Verification successful
Verify indirect references or dependencies related to setting user policies to null
The removal of
updateUser.setPolicies(null)appears to have no direct impact. However, ensure there are no indirect references or dependencies withinUsagePulseServiceCEImplor related classes that might be affected.
Verification successful: No unintended side effects from the removal of
updateUser.setPolicies(null)The removal of
updateUser.setPolicies(null)in theUsagePulseServiceCEImplclass does not introduce any unintended side effects or impact the functionality.
- The only occurrence of
updateUser.setPolicieswas in the line that was removed.- No other references to
policieswere found within the class.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing `updateUser.setPolicies(null)` in `UsagePulseServiceCEImpl`. # Test: Search for the usage of `updateUser.setPolicies` to ensure no unintended side effects. rg --type java $'updateUser.setPolicies'Length of output: 183
Script:
#!/bin/bash # Description: Verify indirect references or dependencies related to setting user policies to null. # Test 1: Search for all methods in the `UsagePulseServiceCEImpl` class to identify potential dependencies. ast-grep --lang java --pattern $'class UsagePulseServiceCEImpl { $$$ }' > methods_in_UsagePulseServiceCEImpl.txt # Test 2: Search for any method calls or references to user policies within the `UsagePulseServiceCEImpl` class. rg --type java 'policies' app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/UsagePulseServiceCEImpl.javaLength of output: 241
app/server/appsmith-server/src/main/java/com/appsmith/server/domains/User.java (1)
Line range hint
1-1: Verify the impact of removinggroupIdsandpermissionsfieldsThe removal of the
groupIdsandpermissionsfields might have implications on user-group relationships and individual permissions management. Ensure that this change does not lead to unintended side effects.Verification successful
Verification complete: No issues found with the removal of
groupIdsandpermissionsfieldsThe search results indicate that the
permissionsfield is not used within theUserclass, andgroupIdsis not referenced elsewhere in the codebase. Therefore, their removal does not introduce any unintended side effects.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing `groupIds` and `permissions` fields in `User.java`. # Test: Search for the usage of `groupIds` and `permissions` fields to ensure no unintended side effects. rg --type java $'groupIds' rg --type java $'permissions'Length of output: 24186
Script:
#!/bin/bash # Description: Verify the impact of removing `groupIds` and `permissions` fields in `User.java` by narrowing down the search. # Search for the usage of `permissions` within the User class ast-grep --lang java --pattern $'class User { $$$ $_ permissions; $$$ }' # Verify if `groupIds` is referenced in any other context outside of the `User` class rg --type java $'groupIds'Length of output: 105
/test sanity <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified user data structure by removing unused `groupIds` and `permissions` fields, improving efficiency in user-group relationships and permissions handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9759459682> > Commit: 9d42126 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9759459682&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results -->
/test sanity
Summary by CodeRabbit
groupIdsandpermissionsfields, improving efficiency in user-group relationships and permissions handling.Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9759459682
Commit: 9d42126
Cypress dashboard.
Tags:
@tag.Sanity