fix: comment the flaky test to unblock TBP #35540

AnaghHegde · 2024-08-08T08:17:39Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Bug Fixes
- Adjusted the test execution context by removing outdated annotations, improving the relevance and accuracy of the theme import tests.

coderabbitai · 2024-08-08T08:17:47Z

Warning

Rate limit exceeded

@AnaghHegde has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 56 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between dc97ebc and 5744cdf.

Walkthrough

The recent changes involve the removal of two annotations from a specific test method in the ThemeImportableServiceCETest class. This adjustment means that the test method will no longer be recognized as a test case and will not execute during the test suite run, potentially indicating a shift in focus or relevance concerning the functionality of theme imports when no application theme is found.

Changes

Files	Change Summary
`app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java`	Removed `@WithUserDetails("api_user")` and `@Test` annotations from the `importThemesToApplication_ApplicationThemeNotFound_DefaultThemeImported()` method, rendering it non-executable as a test.

Poem

In code we weave, a story unfolds,
A test once bright, now quietly cold.
Annotations gone, a shift in the air,
Themes linger lost, but do we still care?
Yet in every change, new paths may ignite,
A dance of the code, from shadow to light. ✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between aaadbc6 and 37d2814.

Files selected for processing (1)

app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java (1 hunks)

Files skipped from review due to trivial changes (1)

app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java

abhvsn

Can we add @Disabled("reason: flaky test") for the concerned test to be more specific around the cause.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 37d2814 and dc97ebc.

Files selected for processing (1)

app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java (2 hunks)

Files skipped from review as they are similar to previous changes (1)

app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java

## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Bug Fixes** - Adjusted the test execution context by removing outdated annotations, improving the relevance and accuracy of the theme import tests.

github-actions · 2024-08-08T08:44:14Z

Failed server tests

com.appsmith.server.services.ThemeServiceTest#getApplicationTheme_WhenUserHasNoPermission_ExceptionThrows

github-actions · 2024-08-08T08:50:31Z

Failed server tests

com.appsmith.server.services.ce.ApplicationServiceCETest#publishApplication_withPageIconSet_success

github-actions · 2024-08-08T08:50:39Z

Failed server tests

com.appsmith.server.services.ThemeServiceTest#publishTheme_WhenSystemThemeIsSet_NoNewThemeCreated

comment the flaky test

37d2814

AnaghHegde self-assigned this Aug 8, 2024

AnaghHegde requested a review from a team as a code owner August 8, 2024 08:17

github-actions bot added the Bug Something isn't working label Aug 8, 2024

coderabbitai bot reviewed Aug 8, 2024

View reviewed changes

abhvsn reviewed Aug 8, 2024

View reviewed changes

review comment

dc97ebc

AnaghHegde requested a review from abhvsn August 8, 2024 08:22

review comment

5744cdf

coderabbitai bot reviewed Aug 8, 2024

View reviewed changes

abhvsn approved these changes Aug 8, 2024

View reviewed changes

abhvsn merged commit 81ef501 into release Aug 8, 2024
11 of 12 checks passed

abhvsn deleted the fix/theme-tests branch August 8, 2024 08:29

coderabbitai bot mentioned this pull request Nov 12, 2024

test: Analyse TBP failure WidgetPropertyNavigation #37336

Closed

This was referenced Nov 21, 2024

test: new test cases framework functions and Action selector #37566

Merged

fix: picking settingsConfig from ApiEditorContext instead of props #37758

Closed

This was referenced Dec 12, 2024

test: fix test data migration issue #38118

Closed

fix: gsheets all sheets option enabled behind a feature flag #37942

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: comment the flaky test to unblock TBP #35540

fix: comment the flaky test to unblock TBP #35540

AnaghHegde commented Aug 8, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 8, 2024 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

abhvsn left a comment

coderabbitai bot left a comment

github-actions bot commented Aug 8, 2024

github-actions bot commented Aug 8, 2024

github-actions bot commented Aug 8, 2024

fix: comment the flaky test to unblock TBP #35540

fix: comment the flaky test to unblock TBP #35540

Conversation

AnaghHegde commented Aug 8, 2024 • edited by coderabbitai bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Aug 8, 2024 • edited Loading

Rate limit exceeded

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

abhvsn left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 8, 2024

Failed server tests

github-actions bot commented Aug 8, 2024

Failed server tests

github-actions bot commented Aug 8, 2024

Failed server tests

AnaghHegde commented Aug 8, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 8, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)