Do not merge: Flaky test : Peekoverlay #36183
Conversation
WalkthroughThe pull request modifies the test specifications listed in the Changes
Possibly related PRs
Suggested labels
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/ci-test-limit-count run_count=20 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10767300099. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/client/cypress/limited-tests.txt (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/cypress/limited-tests.txt
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10767300099. |
sagar-qa007
force-pushed
the
fix/peekoverlay
branch
from
81e0415 to
5d98fe2
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- app/client/cypress/e2e/Regression/ClientSide/Templates/Fork_Template_To_App_spec.ts (2 hunks)
- app/client/cypress/limited-tests.txt (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/cypress/limited-tests.txt
Additional context used
Path-based instructions (1)
app/client/cypress/e2e/Regression/ClientSide/Templates/Fork_Template_To_App_spec.ts (1)
Pattern
app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
Learnings (2)
Common learnings
Learnt from: dipyamanbiswas07 PR: appsmithorg/appsmith#29282 File: app/client/cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js:11-17 Timestamp: 2024-01-09T08:39:59.723Z Learning: The user has clarified that intercepts are called in end-to-end tests, and therefore resetting the feature flag in an `afterEach` hook is not required in their test setup.app/client/cypress/e2e/Regression/ClientSide/Templates/Fork_Template_To_App_spec.ts (1)
Learnt from: dipyamanbiswas07 PR: appsmithorg/appsmith#29282 File: app/client/cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js:11-17 Timestamp: 2024-01-09T08:39:59.723Z Learning: The user has clarified that intercepts are called in end-to-end tests, and therefore resetting the feature flag in an `afterEach` hook is not required in their test setup.
Additional comments not posted (2)
app/client/cypress/e2e/Regression/ClientSide/Templates/Fork_Template_To_App_spec.ts (2)
18-23: Well done on enhancing the test reliability!The modifications in this test case, including the use of direct clicks on template cards and the addition of a new page creation step, are well thought out. These changes should help in reducing the flakiness by making the test actions more deterministic and less prone to errors related to UI changes.
Also applies to: 25-25
35-35: Excellent work on structuring the test case!This test case is well-organized and includes comprehensive checks and assertions that enhance its reliability and robustness. The use of specific locators and helper functions contributes to making the test more maintainable and less prone to errors.
sagar-qa007
added
ok-to-test
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10775624863
Commit: 5d98fe2
Cypress dashboard.
Tags:
@tag.AllSpec:
Mon, 09 Sep 2024 16:05:04 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
PeekOverlaycomponent and theFork_Template_To_Appcomponent.