Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mongo uri spec flakiness #36249

Merged
merged 56 commits into from
Sep 17, 2024
Merged

fix: mongo uri spec flakiness #36249

merged 56 commits into from
Sep 17, 2024

Conversation

AmanAgarwal041
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 commented Sep 11, 2024

Description

There were two things that were making this spec file act flaky:

  • The delete query wasn't working as the id was being converted to ObjectId('id') but since the id was expected to be int, it was failing. So converting the default delete query generated from crud operation to { _id: {{data_table.triggeredRow._id}}} actually started passing the whole of test.
  • Second thing was, since the spec was updating some records and verifying, running it multiple times was causing the failures in the next runs, Hence instead of using the default data table from the ted suite, the data is being dumped to a new collection that is dynamically generated in the spec using the new fixture that is added in the pr. Hence, after this change the spec started passing in every multiple runs.

Fixes #35148
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10891454490
Commit: 3aef2d2
Cypress dashboard.
Tags: @tag.Datasource
Spec:


Mon, 16 Sep 2024 21:03:05 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Added a comprehensive dataset for MongoDB-related merchandise, improving product management and display features.
  • Bug Fixes

    • Updated test case logic to focus on deletion operations and enhance validation processes.
    • Removed redundant assertions for table data verification to improve test clarity.
  • Chores

    • Streamlined validation of loaded table data for clearer test output, consolidating multiple assertions into a single verification method.

Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10885288503.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 24 Total Passed: 24 Total Failed: 0 Total Skipped: 0 *****************************

@AmanAgarwal041
Copy link
Contributor Author

/ci-test-limit-count run_count=20

Copy link

@AmanAgarwal041 AmanAgarwal041 changed the title Fix/mongo uri cypress fix: mongo uri spec flakiness Sep 16, 2024
@github-actions github-actions bot added Bug Something isn't working cypress-flaky-fix This label is auto-added when a PR which only has Cypress fixes are merged to release Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Stability Pod For all issues/tasks to be prioritized under Stability pod Task A simple Todo labels Sep 16, 2024
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10889253849.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 120 Total Passed: 120 Total Failed: 0 Total Skipped: 0 *****************************

@AmanAgarwal041 AmanAgarwal041 merged commit 8474c20 into release Sep 17, 2024
42 checks passed
@AmanAgarwal041 AmanAgarwal041 deleted the fix/mongo-uri-cypress branch September 17, 2024 05:31
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working cypress-flaky-fix This label is auto-added when a PR which only has Cypress fixes are merged to release Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration ok-to-test Required label for CI Query & JS Pod Issues related to the query & JS Pod Stability Pod For all issues/tasks to be prioritized under Stability pod Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix flakiness of cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
3 participants