-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mongo uri spec flakiness #36249
Conversation
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10885288503.
|
/ci-test-limit-count run_count=20 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10889253849. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10889253849.
|
Description
There were two things that were making this spec file act flaky:
ObjectId('id')
but since the id was expected to be int, it was failing. So converting the default delete query generated from crud operation to{ _id: {{data_table.triggeredRow._id}}}
actually started passing the whole of test.Fixes #35148
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10891454490
Commit: 3aef2d2
Cypress dashboard.
Tags:
@tag.Datasource
Spec:
Mon, 16 Sep 2024 21:03:05 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores