Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove pg build input for build docker as not needed anymore #36436

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

abhvsn
Copy link
Contributor

@abhvsn abhvsn commented Sep 20, 2024

Description

We removed is-pg-build input for .github/workflows/build-docker-image.yml via commit as this is not being used anywhere in that workflow. This PR makes sure to remove the references in other workflows.

Ref : https://theappsmith.slack.com/archives/CGBPVEJ5C/p1726808452890429

/test Sanity

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10953584231
Commit: c1d45ca
Cypress dashboard.
Tags: @tag.Sanity
Spec:
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Sanity/Datasources/GraphQL_spec.ts
List of identified flaky tests.
Fri, 20 Sep 2024 05:42:08 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Simplified the GitHub Actions workflow by removing the unnecessary is-pg-build input parameter from the build-docker-image job.

@abhvsn abhvsn requested a review from sharat87 as a code owner September 20, 2024 05:13
@abhvsn abhvsn added the ok-to-test Required label for CI label Sep 20, 2024
Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Walkthrough

The pull request introduces a modification to the GitHub Actions workflow by removing the is-pg-build input parameter from the build-docker-image job in the .github/workflows/pr-cypress.yml file. This change streamlines the job configuration while maintaining the overall structure of the workflow, which continues to ensure that the ci-test job is dependent on the successful completion of the build-docker-image job.

Changes

File Change Summary
.github/workflows/pr-cypress.yml Removed is-pg-build input from the build-docker-image job.

Possibly related PRs

Suggested labels

skip-changelog

Poem

In the workflow’s dance, a step was shed,
The is-pg-build input, now gently fed,
Simplicity reigns, as jobs intertwine,
A smoother build path, oh how divine!
Cheers to the changes, let progress unfold,
In the realm of code, new stories are told! 🎉


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cbf8291 and c1d45ca.

Files selected for processing (1)
  • .github/workflows/pr-cypress.yml (0 hunks)
Files not reviewed due to no reviewable changes (1)
  • .github/workflows/pr-cypress.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 20, 2024
@abhvsn abhvsn requested a review from rahulbarwal September 20, 2024 05:14
@abhvsn abhvsn merged commit 6224ffb into release Sep 20, 2024
46 of 47 checks passed
@abhvsn abhvsn deleted the fix/pr-cypress-run branch September 20, 2024 05:22
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
…ppsmithorg#36436)

## Description
We removed is-pg-build input for
`.github/workflows/build-docker-image.yml` via
[commit](appsmithorg@115ed5a#diff-5b40193e09025fd041de92d38c976d0b469e3ee85bef45a71d05d8b5078b1ee8L12)
as this is not being used anywhere in that workflow. This PR makes sure
to remove the references in other workflows.

Ref : https://theappsmith.slack.com/archives/CGBPVEJ5C/p1726808452890429

/test Sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/10953584231>
> Commit: c1d45ca
> Workflow: `PR Automation test suite`
> Tags: `@tag.Sanity`
> Spec: ``
> <hr>Fri, 20 Sep 2024 05:14:18 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Simplified the GitHub Actions workflow by removing the unnecessary
`is-pg-build` input parameter from the `build-docker-image` job.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2024
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 30, 2024
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants