-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove pg build input for build docker as not needed anymore #36436
Conversation
WalkthroughThe pull request introduces a modification to the GitHub Actions workflow by removing the Changes
Possibly related PRs
Suggested labels
Poem
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files not reviewed due to no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…ppsmithorg#36436) ## Description We removed is-pg-build input for `.github/workflows/build-docker-image.yml` via [commit](appsmithorg@115ed5a#diff-5b40193e09025fd041de92d38c976d0b469e3ee85bef45a71d05d8b5078b1ee8L12) as this is not being used anywhere in that workflow. This PR makes sure to remove the references in other workflows. Ref : https://theappsmith.slack.com/archives/CGBPVEJ5C/p1726808452890429 /test Sanity ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/10953584231> > Commit: c1d45ca > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Fri, 20 Sep 2024 05:14:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Simplified the GitHub Actions workflow by removing the unnecessary `is-pg-build` input parameter from the `build-docker-image` job. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
We removed is-pg-build input for
.github/workflows/build-docker-image.yml
via commit as this is not being used anywhere in that workflow. This PR makes sure to remove the references in other workflows.Ref : https://theappsmith.slack.com/archives/CGBPVEJ5C/p1726808452890429
/test Sanity
🔍 Cypress test results
Caution
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10953584231
Commit: c1d45ca
Cypress dashboard.
Tags: @tag.Sanity
Spec:
The following are new failures, please fix them before merging the PR:
Fri, 20 Sep 2024 05:42:08 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
is-pg-build
input parameter from thebuild-docker-image
job.