Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused code #36461

Merged
merged 1 commit into from
Sep 23, 2024
Merged

chore: delete unused code #36461

merged 1 commit into from
Sep 23, 2024

Conversation

KelvinOm
Copy link
Collaborator

@KelvinOm KelvinOm commented Sep 20, 2024

Description

The second round of deleting unused files, .ts were added to the check.

Related EE PR

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10991435044
Commit: 7cfbcb9
Cypress dashboard.
Tags: @tag.All
Spec:


Mon, 23 Sep 2024 10:51:02 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Expanded project file scope to include JavaScript files alongside TypeScript files.
  • Bug Fixes
    • Removed obsolete functions and constants related to help, tour, and API functionalities, improving overall code clarity and maintenance.
  • Chores
    • Deleted several unused files and constants across various components, enhancing project organization and reducing clutter.

Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Walkthrough

The changes involve the removal of multiple files and their associated functionalities within the application. Key components include the deletion of action creators, API classes, configuration files, and utility functions. The modifications primarily focus on streamlining the codebase by eliminating unused or redundant elements, thereby simplifying the overall structure of the application.

Changes

Files Change Summary
app/client/knip.json Updated "project" field to include .js and .ts files; added multiple paths to the "ignore" field.
app/client/src/actions/helpActions.ts, app/client/src/actions/tourActions.ts Removed action creator functions related to help and tour functionalities.
app/client/src/api/SaasApi.ts, app/client/src/ce/api/GitExtendedApi.ts Completely removed API classes and their methods.
app/client/src/assets/icons/blueprintjs/svgo.config.js Deleted SVG optimization configuration file.
app/client/src/ce/actions/auditLogsAction.ts, app/client/src/ee/actions/auditLogsAction.ts Removed audit log action functions and their re-exports, eliminating audit logging capabilities.
app/client/src/ce/entities/DataTree/actionTriggers.ts Deleted action triggers and their associated type definitions, affecting action management.
app/client/src/ce/mocks/handlers.ts, app/client/src/ee/mocks/handlers.ts Removed mock service worker handlers, impacting testing capabilities.
app/client/src/ce/workers/Evaluation/PlatformFunctions.ts Deleted platform functions related to various UI actions.
app/client/src/components/editorComponents/CodeEditor/utils/entityNavigationUtils.ts Removed utility function for entity navigation.
app/client/src/constants/ProductUpdate.ts, app/client/src/constants/serverAssets.ts Deleted constants related to product updates and server assets, removing references to various URLs and configurations.
app/client/src/layoutSystems/..., app/client/src/widgets/... Multiple files removed, including utility functions, constants, and configuration files for various widgets, affecting layout and widget management.
app/client/src/utils/... Removed utility functions and constants related to layout properties and memoization, simplifying the utility layer of the application.

Suggested reviewers

  • ApekshaBhosale
  • sharat87

🎉 In the codebase, a tidy sweep,
Files removed, no longer to keep.
Actions and APIs, all gone away,
Simplifying paths for a brighter day!
Clean and clear, the structure shines,
In this realm of code, harmony aligns! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 20, 2024
@KelvinOm KelvinOm force-pushed the chore/delete-unused-files-2 branch from 8efd0bf to 7cfbcb9 Compare September 23, 2024 09:25
@KelvinOm KelvinOm added the ok-to-test Required label for CI label Sep 23, 2024
@KelvinOm KelvinOm marked this pull request as ready for review September 23, 2024 09:27
@KelvinOm KelvinOm merged commit cd3472a into release Sep 23, 2024
98 checks passed
@KelvinOm KelvinOm deleted the chore/delete-unused-files-2 branch September 23, 2024 10:52
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
## Description
The second round of deleting unused files, `.ts` were added to the
check.

[Related EE PR](https://github.com/appsmithorg/appsmith-ee/pull/5205)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10991435044>
> Commit: 7cfbcb9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10991435044&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 23 Sep 2024 10:51:02 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Expanded project file scope to include JavaScript files alongside
TypeScript files.
- **Bug Fixes**
- Removed obsolete functions and constants related to help, tour, and
API functionalities, improving overall code clarity and maintenance.
- **Chores**
- Deleted several unused files and constants across various components,
enhancing project organization and reducing clutter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants