chore: Add server artifacts in ad hoc image builder

[abhvsn]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Chores
  • Updated the workflow for the Ad-hoc Docker Image to include a new step for preparing server artifacts, enhancing the packaging process.

[coderabbitai]

Walkthrough

The pull request introduces an update to the GitHub Actions workflow for the Ad-hoc Docker Image. A new step, "Place server artifacts-es," is added to the package job, which depends on the successful completion of three prior jobs: server-build, client-build, and rts-build. This step checks for the presence of the prepare_server_artifacts.sh script and executes it if found; otherwise, it logs an error and exits with a non-zero status.

Changes

File Path	Change Summary
.github/workflows/ad-hoc-docker-image.yml	Added a new step "Place server artifacts-es" in the package job to prepare server artifacts.

Possibly related PRs

• chore: Add server artifacts for pg and mongodb for github release workflow #36516: This PR adds a new step named "Place server artifacts-es" to the GitHub Actions workflow, which directly relates to the main PR's update that also includes a step for preparing server artifacts.
• chore: Exit the script if server artifact placer is not available #36569: This PR modifies the script execution logic for preparing server artifacts, ensuring that the absence of the prepare_server_artifacts.sh script is handled, which aligns with the main PR's focus on checking for this script's existence.
• chore: Add polling for embedded pg start to create appsmith DB #36854: This PR enhances the entrypoint.sh script to improve the initialization process for PostgreSQL, which is relevant as it deals with the setup of the environment where server artifacts may be utilized.

Suggested labels

skip-changelog, ok-to-test, Task

Suggested reviewers

• sharat87
• pratapaprasanna
• AnaghHegde

🎉 In the land of code where workflows thrive,
A new step was added, oh how it will jive!
"Place server artifacts-es," a name so grand,
Checks for a script, ready to take a stand.
If it’s not found, an error will show,
Ensuring our packaging workflow will flow! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

.github/workflows/ad-hoc-docker-image.yml (1)

93-102: Class, let's review this new step in our workflow!

Good job on adding this new step to prepare server artifacts! It's like making sure you have all your school supplies ready before starting a big project. However, there are a few things we need to address:

1. There's a small typo in your code, dear. You've written run: twice. Let's fix that, shall we?

2. Your error handling is a bit strict, like giving a student detention for forgetting their pencil. Instead of failing the entire workflow, we could make it a warning. This way, the workflow can continue even if the script is missing.

3. It would be helpful to add a comment explaining what this script does. Remember, good documentation is like leaving clear instructions for a substitute teacher!

Let's make these improvements together:

- name: Place server artifacts-es
  run: |
    # This script prepares server artifacts for the Docker image
    if [[ -f scripts/prepare_server_artifacts.sh ]]; then
      scripts/prepare_server_artifacts.sh
    else
      echo "Warning: No script found to prepare server artifacts. Continuing without it."
    fi

Now, doesn't that look better? Remember, clear communication in our code is just as important as in the classroom!

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e094bf2 and f0566d8.

📒 Files selected for processing (1)

• .github/workflows/ad-hoc-docker-image.yml (1 hunks)

🧰 Additional context used