fix: shared drive support added for google sheets #37602
Conversation
WalkthroughThe changes in this pull request involve modifications to the URI construction in the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11934033608. |
github-actions
bot
added
Google Sheets
sneha122
added
ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/config/FileListMethod.java (1)
Line range hint
1-100: Consider extracting API URL construction to a dedicated utility classSince both
FileListMethodandFileInfoMethodhandle Google Drive API URLs with similar parameters, consider creating a shared utility class to manage URL construction.This would:
- Centralize shared drive configuration
- Make future API parameter updates easier to maintain
- Reduce code duplication
app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/config/FileInfoMethod.java (1)
105-105: Consider using UriComponentsBuilder for query parametersInstead of string concatenation, consider using UriComponentsBuilder's queryParam method for better URL encoding and maintainability.
- methodConfig.getSpreadsheetId() - + "?supportsAllDrives=true&fields=id,name,permissions/role,permissions/emailAddress,createdTime,modifiedTime"); + methodConfig.getSpreadsheetId()); + uriBuilder.queryParam("supportsAllDrives", true) + .queryParam("fields", "id,name,permissions/role,permissions/emailAddress,createdTime,modifiedTime");
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/config/FileInfoMethod.java(1 hunks)app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/config/FileListMethod.java(1 hunks)
🔇 Additional comments (2)
app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/config/FileListMethod.java (1)
43-43: LGTM! Verify shared drive access permissions
The addition of includeItemsFromAllDrives and supportsAllDrives parameters correctly implements shared drive support.
Please ensure that:
- The application has the necessary OAuth scopes for shared drive access
- Error handling adequately covers shared drive permission denied scenarios
app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/config/FileInfoMethod.java (1)
105-105: LGTM: Shared drive support correctly implemented
The addition of supportsAllDrives=true properly enables shared drive access as per Google Drive API specifications.
|
Deploy-Preview-URL: https://ce-37602.dp.appsmith.com |
## Description This PR adds support for accessing shared drive files for google sheets integration Fixes appsmithorg#37598 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11934080947> > Commit: ac6eade > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11934080947&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Wed, 20 Nov 2024 13:51:58 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced API requests for Google Sheets and Drive to include items from all drives. - **Bug Fixes** - Improved data retrieval processes by adjusting query parameters for API calls. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“[email protected]”>
Description
This PR adds support for accessing shared drive files for google sheets integration
Fixes #37598
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11934080947
Commit: ac6eade
Cypress dashboard.
Tags:
@tag.DatasourceSpec:
Wed, 20 Nov 2024 13:51:58 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Bug Fixes