Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci : fix git lfs migrate #37716

Merged
merged 2 commits into from
Nov 26, 2024
Merged

ci : fix git lfs migrate #37716

merged 2 commits into from
Nov 26, 2024

Conversation

yatinappsmith
Copy link
Contributor

@yatinappsmith yatinappsmith commented Nov 26, 2024

Description

fix git lfs migrate

Fixes #Issue Number
or
Fixes Issue URL

Automation

/ok-to-test tags=""

🔍 Cypress test results

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Enhanced client and server build workflows for better adaptability and control.
    • Added a new branch input for specifying the build branch.
    • Improved caching mechanisms and automated confirmation for large file handling.
  • Bug Fixes

    • Refined error handling and logging for better feedback during test executions.
  • Chores

    • Streamlined build processes and organized workflow steps for different scenarios.

Copy link
Contributor

coderabbitai bot commented Nov 26, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the GitHub workflows for both client and server builds. Key changes include the addition of a branch input parameter in the client build workflow and a type change for skip-tests. The server build workflow has been updated to streamline the handling of Git LFS and improve error management. Both workflows now include enhanced caching mechanisms and refined job conditions to better control execution based on specific events and scenarios.

Changes

File Path Change Summary
.github/workflows/client-build.yml - Added branch input parameter.
- Changed skip-tests type from boolean to string.
- Improved job conditions and checkout steps.
- Added compliance check step for pull requests.
- Enhanced caching mechanisms and build environment setup.
.github/workflows/server-build.yml - Updated git lfs migrate import command with --yes flag.
- Refined conditional checks for skip-tests and is-pg-build.
- Improved logging, error handling, and artifact uploading.

Possibly related PRs

  • ci: Add pre push hook to not allow ee changes in ce #35276: This PR modifies the .github/workflows/client-build.yml file by adding a command to update Git LFS, which is relevant to the changes made in the main PR regarding the handling of Git LFS in the client build workflow.
  • CI : fix build cache #37712: This PR also focuses on the .github/workflows/client-build.yml file, addressing the build cache and introducing a new input parameter branch, which aligns with the changes made in the main PR regarding the branch input and caching mechanisms.

Suggested labels

CI, Bug, ok-to-test

Suggested reviewers

  • sharat87
  • sagar-qa007
  • ApekshaBhosale

🎉 In the land of code, where workflows thrive,
New branches sprout, keeping builds alive.
With tests that skip and caches that save,
Our builds now dance, oh how they behave!
From client to server, improvements galore,
Cheers to the changes, let’s build even more! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yatinappsmith yatinappsmith merged commit 1274da2 into release Nov 26, 2024
5 of 7 checks passed
@yatinappsmith yatinappsmith deleted the ci/fixlfsmigrate branch November 26, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants