fix: Show bindings hiding behind scroll

[hetunandu]

Description

Fixes the show bindings been hidden because of the overflow setting. This was introduced in #38274
To fix the original issue, we have made sure property pane does not render when in preview mode

Fixes #38547

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12686267032
Commit: e374708
Cypress dashboard.
Tags: @tag.IDE
Spec:

---

Thu, 09 Jan 2025 09:08:23 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Added preview mode detection in the Property Pane Sidebar
• Style
  • Removed overflow restriction in Layout Container
• Bug Fixes
  • Adjusted property pane rendering logic to respect preview mode state

[coderabbitai]

Walkthrough

The pull request introduces changes to the PropertyPaneSidebar and StaticLayout components. A new selector selectCombinedPreviewMode is added to the PropertyPaneSidebar, which modifies the rendering logic by introducing an isPreviewMode state. In the StaticLayout, the overflow property of the LayoutContainer is removed, potentially allowing content to extend beyond its bounds.

Changes

File	Change Summary
app/client/src/components/editorComponents/PropertyPaneSidebar.tsx	Added isPreviewMode selector, modified rendering logic to check preview mode
app/client/src/pages/Editor/IDE/Layout/StaticLayout.tsx	Removed overflow property from LayoutContainer styled component

Assessment against linked issues

Objective	Addressed	Explanation
Fix "Show bindings" menu in split pane mode [#38547]	❓	Unable to definitively confirm if the changes directly address the binding menu issue

Possibly related PRs

• chore: use overflow: auto instead of scroll in widget explorer #33342: Overflow property changes in AddWidgets component
• chore: Transitions for IDE #35714: New layout manager for editor interface
• fix: Focus retention on inputs #36770: Maintaining focus in the editor
• fix: Min width in certain ADS Button usage #37624: Button sizing issues
• chore: Visual changes for core navigation elements on IDE #37880: Visual changes for core navigation elements
• fix: add check to avoid NPE when binding value is null #38104: Null pointer exception checks

Suggested labels

Bug, IDE Product, IDE Pod, ok-to-test, User Testing

Suggested reviewers

• ApekshaBhosale
• albinAppsmith
• ankitakinger

Poem

In the realm of code, where pixels dance,
A sidebar shifts with preview's glance,
Overflow freed, boundaries blur,
Where logic and design confer! 🖥️✨
A tale of bits, both bold and bright! 🚀

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

app/client/src/components/editorComponents/PropertyPaneSidebar.tsx (2)

19-19: Consider relocating the preview mode selector

The preview mode selector might be better placed in a dedicated UI or preview-related selector file rather than gitModSelectors.

---

35-39: Consider a more descriptive variable name

The variable name shouldNotRenderPane could be more specific to better reflect its expanded purpose, e.g., shouldHidePropertyPane or isPropertyPaneHidden.

-  const shouldNotRenderPane =
+  const isPropertyPaneHidden =
     isPreviewMode ||
     (isDraggingOrResizing &&
       selectedWidgetIds[0] !== prevSelectedWidgetId.current) ||
     selectedWidgetIds[0] === MAIN_CONTAINER_WIDGET_ID;

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4662317 and e374708.

📒 Files selected for processing (2)

• app/client/src/components/editorComponents/PropertyPaneSidebar.tsx (2 hunks)
• app/client/src/pages/Editor/IDE/Layout/StaticLayout.tsx (0 hunks)

💤 Files with no reviewable changes (1)

• app/client/src/pages/Editor/IDE/Layout/StaticLayout.tsx

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-build / client-build

🔇 Additional comments (2)

app/client/src/components/editorComponents/PropertyPaneSidebar.tsx (2)

26-26: Clean implementation of preview mode state

The preview mode state is well-implemented using the selector pattern.

---

Line range hint 26-39: Verify test coverage for preview mode behavior

The new preview mode functionality should be covered by tests to ensure proper behavior.