refactor: remove deprecated table widget tests #38733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deletes multiple obsolete Cypress test files related to the Table Widget, including tests for button icon validation, color specifications, column resizing, derived column data validation, and various property pane functionalities. - Deleted tests for button icon validation, color specifications, and column resizing. - Removed tests for derived column data and property pane functionalities. - Cleaned up the test suite to enhance maintainability and focus on current features.
rahulbarwal
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
rahulbarwal
requested review from
jacquesikot
and removed request for
ApekshaBhosale and
sagar-qa007
WalkthroughThe pull request involves the deletion of multiple Cypress end-to-end test specification files for the Table V1 widget within the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (29)
💤 Files with no reviewable changes (29)
⏰ Context from checks skipped due to timeout of 90000ms (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
Table Widget
Task
sagar-qa007
approved these changes
Jan 17, 2025
rahulbarwal
deleted the
rahulbarwal/38691/remove-Table-V1-cypress-specs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deletes multiple obsolete Cypress test files related to the Table Widget, including tests for button icon validation, color specifications, column resizing, derived column data validation, and various property pane functionalities.
EE PR for sanity testing: https://github.com/appsmithorg/appsmith-ee/pull/5965
Fixes #38691
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12826545188
Commit: 107a26f
Cypress dashboard.
Tags:
@tag.AllSpec:
Fri, 17 Jan 2025 11:14:13 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Based on the provided information, here's a concise release note:
The release notes focus on the high-level action of removing test files without diving into specific implementation details. The goal is to provide a clear, user-friendly summary of the changes.