Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Chart widget respects theme font #38777

Merged
merged 3 commits into from
Jan 21, 2025
Merged

fix: Chart widget respects theme font #38777

merged 3 commits into from
Jan 21, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 20, 2025 •
edited by github-actions bot
Loading

Ensuring the Chart widget's text uses the dynamic theme font from props.

Fixes: #38776

Automation

/ok-to-test tags="@tag.Widget"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12880224250
Commit: 3e7fca5
Cypress dashboard.
Tags: @tag.Widget
Spec:

Tue, 21 Jan 2025 05:55:04 UTC

Link to Devin run: https://app.devin.ai/sessions/a2491d1e9fb3466c9b28586686134aa6

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Bug Something isn't working label Jan 20, 2025
@rahulbarwal rahulbarwal changed the title fix: Chart widget respects theme font (#38776) fix: Chart widget respects theme font Jan 21, 2025
@rahulbarwal rahulbarwal self-assigned this Jan 21, 2025
@github-actions github-actions bot added Chart Widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets labels Jan 21, 2025
@rahulbarwal
Copy link
Contributor

/build-deploy-preview skip-tests=true

@rahulbarwal rahulbarwal added the ok-to-test Required label for CI label Jan 21, 2025
@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12880222836.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38777.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-38777.dp.appsmith.com

@rahulbarwal rahulbarwal merged commit 8e9db85 into release Jan 21, 2025
53 checks passed
@rahulbarwal rahulbarwal deleted the devin/1737377585-chart-widget-theme-font branch January 21, 2025 06:44
rahulbarwal added a commit that referenced this pull request Jan 21, 2025
@rahulbarwal
fix: Update ChartWidget fontFamily handling to respect system default (…
d7e8bb5 
…#38777)
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Feb 7, 2025
@devin-ai-integration @rahulbarwal
fix: Chart widget respects theme font (appsmithorg#38777)
b734a0c 
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulbarwal rahulbarwal rahulbarwal approved these changes

Assignees

@rahulbarwal rahulbarwal

Labels
Bug Something isn't working Chart Widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Chart widget should adopt the font from the theme settings.
1 participant
@rahulbarwal