chore: skipping cases for mockdb usage #38888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request involves systematically skipping multiple Cypress test suites and individual test cases across various specification files in the client-side testing directory. The changes primarily use the Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
app/client/cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts (1)
Line range hint
68-85: Approve skipping mockdb test but refactor sleep usage.The decision to skip this test aligns with the PR objective of handling mockdb issues. However, when this test is re-enabled:
- Replace
agHelper.Sleepwith proper Cypress wait commands- Consider using data-* attributes for selectors
- agHelper.Sleep(1500); + cy.waitUntil(() => { + return cy.get('[data-testid="schema-loaded"]').should('be.visible'); + });app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts (1)
Line range hint
80-119: Consider consolidating duplicate test implementations.While skipping the mockdb test aligns with PR objectives, there's a duplicate implementation of this test for airgap environments. Consider consolidating these tests using conditional logic.
- it.skip( - "5. Query bottom bar should be collapsable", - { tags: ["@tag.excludeForAirgap"] }, - () => { - // ... test implementation - } - ); - - it("airgap", "5. Query bottom bar should be collapsable - airgap", () => { + it( + "5. Query bottom bar should be collapsable", + { tags: ["@tag.excludeForAirgap"] }, + () => { + if (Cypress.env("IS_AIRGAP")) { + // airgap implementation + } else { + // regular implementation + } + } + );
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
app/client/cypress/e2e/Regression/ClientSide/BugTests/DS_Bug26716_Spec.ts(1 hunks)app/client/cypress/e2e/Regression/ClientSide/BugTests/DS_Bug28750_Spec.ts(1 hunks)app/client/cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts(2 hunks)app/client/cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts(1 hunks)app/client/cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Generated_App_spec.ts(1 hunks)app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts(1 hunks)app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts(1 hunks)app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js(1 hunks)app/client/cypress/e2e/Sanity/Datasources/MockDBs_Spec.ts(1 hunks)app/client/cypress/e2e/Sanity/Datasources/Styles_spec.js(1 hunks)app/client/cypress/e2e/Smoke/GenerateCRUD/Generate_Crud_New_Page_spec.ts(1 hunks)
✅ Files skipped from review due to trivial changes (9)
- app/client/cypress/e2e/Smoke/GenerateCRUD/Generate_Crud_New_Page_spec.ts
- app/client/cypress/e2e/Regression/ClientSide/BugTests/DS_Bug28750_Spec.ts
- app/client/cypress/e2e/Sanity/Datasources/MockDBs_Spec.ts
- app/client/cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Generated_App_spec.ts
- app/client/cypress/e2e/Regression/ClientSide/BugTests/DS_Bug26716_Spec.ts
- app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js
- app/client/cypress/e2e/Sanity/Datasources/Styles_spec.js
- app/client/cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
- app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts
🧰 Additional context used
📓 Path-based instructions (2)
app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
- GitHub Check: client-build / client-build
🔇 Additional comments (1)
app/client/cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts (1)
Line range hint
86-102: Approve skipping mockdb test.The decision to skip this test aligns with the PR objective of handling mockdb-related test failures.
NandanAnantharamu
approved these changes
Jan 30, 2025
github-actions bot
pushed a commit
to Zeral-Zhang/appsmith
that referenced
this pull request
Feb 7, 2025
## Description There were cases where mockdb is corrupt and we do see cypress failure. As it is not controlled by any of the team member to remain unchnaged, skipping test cases related to it. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38889 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13028133245> > Commit: 20e983d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13028133245&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 29 Jan 2025 12:03:43 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Skipped multiple test suites and individual test cases across various test specification files. - Temporarily disabled tests related to datasources, widget validation, mobile responsiveness, and CRUD operations. - Modifications made to prevent specific tests from running during test execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were cases where mockdb is corrupt and we do see cypress failure. As it is not controlled by any of the team member to remain unchnaged, skipping test cases related to it.
Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38889
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13028133245
Commit: 20e983d
Cypress dashboard.
Tags:
@tag.AllSpec:
Wed, 29 Jan 2025 12:03:43 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit