Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add AI related env variables to dps #38927

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

pratapaprasanna
Copy link
Contributor

@pratapaprasanna pratapaprasanna commented Jan 30, 2025

Summary by CodeRabbit

  • Configuration
    • Added new environment variables for OpenAI and Appsmith Carbon services in deployment workflow
    • Updated deployment script to support new configuration parameters
    • Enhanced preview deployment configuration with additional service-related settings

Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several new environment variables related to OpenAI and Appsmith Carbon services in the GitHub Actions workflow and the deployment script. These changes enhance the configuration options for the deployment process by adding secret-based environment variables to the build-deploy-preview job and the deploy_preview.sh script. The modifications allow for the utilization of these variables during the Helm chart deployment without altering the existing logic or control flow.

Changes

File Change Summary
.github/workflows/on-demand-build-docker-image-deploy-preview.yml Added 6 new environment variables sourced from repository secrets in the build-deploy-preview job
scripts/deploy_preview.sh Exported 6 new environment variables and integrated them into Helm chart deployment parameters

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

  • mohanarpit
  • zbuildz

Possibly related PRs

Poem

🚀 Secrets whisper, variables dance,
Deployment's magic in a single glance.
Docker and AI, hand in hand,
Configuration's power, now firsthand!
Helm charts sing their secret song 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 213db55 and 320c4bc.

📒 Files selected for processing (2)
  • .github/workflows/on-demand-build-docker-image-deploy-preview.yml (1 hunks)
  • scripts/deploy_preview.sh (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jan 30, 2025
@pratapaprasanna pratapaprasanna merged commit f8e7368 into release Jan 30, 2025
14 of 15 checks passed
@pratapaprasanna pratapaprasanna deleted the chore/add/ai/dp branch January 30, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant