Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Appsody stack fails since #397 was merged #416

Closed
NottyCode opened this issue Oct 7, 2019 · 1 comment
Closed

Appsody stack fails since #397 was merged #416

NottyCode opened this issue Oct 7, 2019 · 1 comment
Milestone

Comments

@NottyCode
Copy link

Describe the bug
When doing appsody run with a java-microprofile projectt created since #397 was merged you get this error:

[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] BUILD SUCCESS
[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] Total time:  4.569 s
[Container] [INFO] Finished at: 2019-10-07T21:31:56Z
[Container] [INFO] ------------------------------------------------------------------------
[Container] Should be a loose application:
[Container]   <configuration>
[Container]     <looseApplication>true</looseApplication>
[Container]   </configuration>
[Container] [Error] FATAL error APPSODY_PREP command received an error.  The controller is exiting: exit status 1
[Error] Error in 'appsody run': exit status 1

This is because validate.sh needs to have the following removed:

# Enforcing loose application
l_looseConfig=$(xmlstarlet sel -T -N x="http://maven.apache.org/POM/4.0.0" -t -v "/x:project/x:build/x:plugins/x:plugin[x:artifactId='liberty-maven-plugin']/x:configuration/x:looseApplication" pom.xml)
if ! [ "${l_looseConfig}" == "true" ]; then
  echo "Should be a loose application:
  <configuration>
    <looseApplication>true</looseApplication>
  </configuration>"
  exit 1
fi

To Reproduce
Steps to reproduce the behavior:

  1. appsody init java-microprofile
  2. appsody run

Expected behavior
Expect it to build without failure.

Actual behaviour

[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] BUILD SUCCESS
[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] Total time:  4.569 s
[Container] [INFO] Finished at: 2019-10-07T21:31:56Z
[Container] [INFO] ------------------------------------------------------------------------
[Container] Should be a loose application:
[Container]   <configuration>
[Container]     <looseApplication>true</looseApplication>
[Container]   </configuration>
[Container] [Error] FATAL error APPSODY_PREP command received an error.  The controller is exiting: exit status 1
[Error] Error in 'appsody run': exit status 1

Environment Details (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

If applicable please specify:

  • CLI version:
  • Stack you are using (including the version): java-microprofile v0.2.16
NottyCode added a commit to NottyCode/stacks that referenced this issue Oct 7, 2019
PR appsody#397 was integrated without fixing validate.sh to pass. Fixing
validate.sh and incrementing version on the assumption that a new
version would be required.

Fixes: appsody#416
@neeraj-laad
Copy link
Contributor

Apologies for this. This was not detected in our CI and clearly should not have been merged. We have reverted this PR and released a new functioning stack. Will work with @Emily-Jiang to submit an updated PR.

@neeraj-laad neeraj-laad added this to the Milestone-8 milestone Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants