Skip to content

Commit

Permalink
Change word 'injections' to 'configuration'
Browse files Browse the repository at this point in the history
  • Loading branch information
Jasper Blues committed Apr 10, 2014
1 parent c8fefc0 commit d11792d
Show file tree
Hide file tree
Showing 23 changed files with 112 additions and 106 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ + (instancetype)propertyPlaceholderWithResource:(id <TyphoonResource>)resource

+ (instancetype)propertyPlaceholderWithResources:(NSArray *)resources
{
return [self withClass:[TyphoonPropertyPlaceholderConfigurer class] injections:^(TyphoonDefinition *definition) {
return [self withClass:[TyphoonPropertyPlaceholderConfigurer class] configuration:^(TyphoonDefinition *definition) {
[definition injectInitializer:@selector(configurerWithResourceList:) parameters:^(TyphoonMethod *initializer) {
[initializer injectParameterWith:resources];
}];
Expand Down
2 changes: 1 addition & 1 deletion Source/Definition/TyphoonDefinition.h
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ typedef void(^TyphoonDefinitionBlock)(TyphoonDefinition *definition);

+ (TyphoonDefinition *)withClass:(Class)clazz;

+ (TyphoonDefinition *)withClass:(Class)clazz injections:(TyphoonDefinitionBlock)injections;
+ (TyphoonDefinition *)withClass:(Class)clazz configuration:(TyphoonDefinitionBlock)injections;

+ (TyphoonDefinition *)withClass:(Class)clazz factory:(TyphoonDefinition *)definition selector:(SEL)selector;

Expand Down
4 changes: 2 additions & 2 deletions Source/Definition/TyphoonDefinition.m
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ + (TyphoonDefinition *)withClass:(Class)clazz
return [[TyphoonDefinition alloc] initWithClass:clazz key:nil];
}

+ (TyphoonDefinition *)withClass:(Class)clazz injections:(TyphoonDefinitionBlock)injections
+ (TyphoonDefinition *)withClass:(Class)clazz configuration:(TyphoonDefinitionBlock)injections
{
return [TyphoonDefinition withClass:clazz key:nil injections:injections];
}
Expand All @@ -81,7 +81,7 @@ + (TyphoonDefinition *)withClass:(Class)clazz key:(NSString *)key injections:(Ty

+ (TyphoonDefinition *)withClass:(Class)clazz factory:(TyphoonDefinition *)_definition selector:(SEL)selector
{
return [TyphoonDefinition withClass:clazz injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:clazz configuration:^(TyphoonDefinition *definition) {
[definition injectInitializer:selector parameters:nil];
[definition setFactory:_definition];
}];
Expand Down
6 changes: 3 additions & 3 deletions Source/Factory/Provider/TyphoonFactoryProvider.m
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ @implementation TyphoonFactoryProvider
+ (TyphoonDefinition *)withProtocol:(Protocol *)protocol dependencies:(TyphoonDefinitionBlock)dependenciesBlock factory:(id)factoryBlock
{
Class factoryClass = [[TyphoonAssistedFactoryCreator creatorWithProtocol:protocol factoryBlock:factoryBlock] factoryClass];
return [TyphoonDefinition withClass:factoryClass injections:dependenciesBlock];
return [TyphoonDefinition withClass:factoryClass configuration:dependenciesBlock];
}

+ (TyphoonDefinition *)withProtocol:(Protocol *)protocol dependencies:(TyphoonDefinitionBlock)dependenciesBlock returns:(Class)returnType
{
Class factoryClass = [[TyphoonAssistedFactoryCreator creatorWithProtocol:protocol returns:returnType] factoryClass];
return [TyphoonDefinition withClass:factoryClass injections:dependenciesBlock];
return [TyphoonDefinition withClass:factoryClass configuration:dependenciesBlock];
}

+ (TyphoonDefinition *)withProtocol:(Protocol *)protocol dependencies:(TyphoonDefinitionBlock)dependenciesBlock
factories:(TyphoonAssistedFactoryDefinitionBlock)definitionBlock
{
Class factoryClass = [[TyphoonAssistedFactoryCreator creatorWithProtocol:protocol factories:definitionBlock] factoryClass];
return [TyphoonDefinition withClass:factoryClass injections:dependenciesBlock];
return [TyphoonDefinition withClass:factoryClass configuration:dependenciesBlock];
}

@end
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ - (id)injectionAwareObject;

- (id)injectionByProperty
{
return [TyphoonDefinition withClass:[ComponentFactoryAwareObject class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[ComponentFactoryAwareObject class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(componentFactory) with:self];
}];
}

- (id)injectionByInitialization
{
return [TyphoonDefinition withClass:[ComponentFactoryAwareObject class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[ComponentFactoryAwareObject class] configuration:^(TyphoonDefinition *definition) {
[definition injectInitializer:@selector(initWithComponentFactory) parameters:^(TyphoonMethod *initializer) {
[initializer injectParameterWith:self];
}];
Expand All @@ -39,14 +39,14 @@ - (id)injectionByInitialization

- (id)injectionByPropertyAssemblyType
{
return [TyphoonDefinition withClass:[ComponentFactoryAwareObject class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[ComponentFactoryAwareObject class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(assembly)];
}];
}

- (id)injectionByPropertyFactoryType
{
return [TyphoonDefinition withClass:[ComponentFactoryAwareObject class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[ComponentFactoryAwareObject class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(componentFactory)];
}];
}
Expand Down
14 changes: 7 additions & 7 deletions Tests/Definition/Properties/FactoryReferenceInjectionsTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ @implementation ClassWithKnightSettingsAssembly

- (id)knightSettings
{
return [TyphoonDefinition withClass:[ClassWithKnightSettings class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[ClassWithKnightSettings class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(damselsRescued) with:@(currentDamselsRescued)];
[definition injectProperty:@selector(hasHorseWillTravel) with:@(currentHasHorseWillTravel)];
[definition injectProperty:@selector(fooString) with:currentFooString];
Expand Down Expand Up @@ -70,7 +70,7 @@ - (void)test_inject_int_bool
{
Knight *knight = [Knight new];

TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(damselsRescued) with:@(30)];
[definition injectProperty:@selector(hasHorseWillTravel) with:@(YES)];
}];
Expand All @@ -87,7 +87,7 @@ - (void)test_inject_object

NSString *testString = @"Hello Knights";

TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(foobar) with:testString];
}];
[factory doInjectionEventsOn:(id) knight withDefinition:knightDefinition args:nil];
Expand All @@ -106,7 +106,7 @@ - (void)test_inject_factorydefinition_selector

TyphoonDefinition *settings = [factory definitionForType:[ClassWithKnightSettings class]];

TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(damselsRescued) with:[settings property:@selector(damselsRescued)]];
[definition injectProperty:@selector(hasHorseWillTravel) with:[settings property:@selector(hasHorseWillTravel)]];
[definition injectProperty:@selector(foobar) with:[settings property:@selector(fooString)]];
Expand All @@ -128,7 +128,7 @@ - (void)test_inject_factorydefinition_keyPath

TyphoonDefinition *settings = [factory definitionForType:[ClassWithKnightSettings class]];

TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(foobar) with:[settings keyPath:@"fooString.uppercaseString"]];
}];
[factory doInjectionEventsOn:(id) knight withDefinition:knightDefinition args:nil];
Expand All @@ -145,7 +145,7 @@ - (void)test_inject_factorydefinition_on_init

TyphoonDefinition *settings = [factory definitionForType:[ClassWithKnightSettings class]];

TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectInitializer:@selector(initWithDamselsRescued:foo:) parameters:^(TyphoonMethod *initializer) {
[initializer injectParameterWith:[settings property:@selector(damselsRescued)]];
[initializer injectParameterWith:[settings keyPath:@"fooString.uppercaseString"]];
Expand All @@ -165,7 +165,7 @@ - (void)test_injection_readonly_properties
{
TyphoonDefinition *quest = [TyphoonDefinition withClass:[CampaignQuest class]];

TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *knightDefinition = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(readOnlyQuest)];
}];
[factory registerDefinition:quest];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,28 @@ @implementation StoryboardViewControllerAssembly

- (id)initialViewController
{
return [TyphoonDefinition withClass:[UIViewController class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[UIViewController class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(title) with:@"Initial"];
}];
}

- (id)firstViewController
{
return [TyphoonDefinition withClass:[UIViewController class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[UIViewController class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(title) with:@"First"];
}];
}

- (id)secondViewController
{
return [TyphoonDefinition withClass:[UIViewController class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[UIViewController class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(title) with:@"Second"];
}];
}

- (id)uniqueViewController
{
return [TyphoonDefinition withClass:[UniqueViewController class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[UniqueViewController class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(title) with:@"Unique"];
}];
}
Expand Down
22 changes: 11 additions & 11 deletions Tests/Definition/TyphoonDefinitionTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,16 @@ - (void)test_enumerates_properties_injected_by_reference

- (void)test_inherits_all_parent_properties
{
TyphoonDefinition *longLostAncestor = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *longLostAncestor = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(hasHorseWillTravel) with:@(YES)];
}];

TyphoonDefinition *parent = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *parent = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(damselsRescued) with:@(12)];
[definition setParent:longLostAncestor];
}];

TyphoonDefinition *child = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *child = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(foobar) with:@"foobar!"];
[definition setParent:parent];
}];
Expand All @@ -129,11 +129,11 @@ - (void)test_inherits_all_parent_properties

- (void)test_child_properties_override_parent_properties
{
TyphoonDefinition *parent = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *parent = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(damselsRescued) with:@(12)];
}];

TyphoonDefinition *child = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *child = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(damselsRescued) with:@(346)];
[definition setParent:parent];
}];
Expand All @@ -146,11 +146,11 @@ - (void)test_child_properties_override_parent_properties

- (void)test_child_inherits_parent_scope_if_not_explicitly_set
{
TyphoonDefinition *parent = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *parent = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition setScope:TyphoonScopeSingleton];
}];

TyphoonDefinition *child = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *child = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(damselsRescued) with:@(346)];
[definition setParent:parent];
}];
Expand All @@ -160,11 +160,11 @@ - (void)test_child_inherits_parent_scope_if_not_explicitly_set

- (void)test_child_overrides_parent_scope_if_explicitly_set
{
TyphoonDefinition *parent = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *parent = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition setScope:TyphoonScopeSingleton];
}];

TyphoonDefinition *child = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *child = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(damselsRescued) with:@(346)];
[definition setScope:TyphoonScopePrototype];
[definition setParent:parent];
Expand Down Expand Up @@ -196,13 +196,13 @@ - (void)test_autoWired_properties
- (void)test_performs_copy
{

TyphoonDefinition *definition = [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
TyphoonDefinition *definition = [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {

[definition injectInitializer:@selector(initWithQuest:damselsRescued:) parameters:^(TyphoonMethod *initializer) {
[initializer injectParameterWith:nil];
[initializer injectParameterWith:@(12)];
}];

[definition injectProperty:@selector(favoriteDamsels) with:@[
[TyphoonReferenceDefinition definitionReferringToComponent:@"mary"],
[TyphoonReferenceDefinition definitionReferringToComponent:@"mary"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ @implementation InvalidCollaboratingAssembly

- (id)knightWithExternalQuest
{
return [TyphoonDefinition withClass:[Knight class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[Knight class] configuration:^(TyphoonDefinition *definition) {
[definition injectProperty:@selector(quest) with:[[MiddleAgesAssembly assembly] environmentDependentQuest]];
}];
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ @implementation InvalidCollaboratingAssembly_Initializer

- (id)knightWithExternalQuest
{
return [TyphoonDefinition withClass:[CavalryMan class] injections:^(TyphoonDefinition *definition) {
return [TyphoonDefinition withClass:[CavalryMan class] configuration:^(TyphoonDefinition *definition) {
[definition injectInitializer:@selector(initWithQuest:) parameters:^(TyphoonMethod *initializer) {
[initializer injectParameterWith:[[MiddleAgesAssembly assembly] environmentDependentQuest]];
}];
Expand Down
Loading

0 comments on commit d11792d

Please sign in to comment.