Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow --home to still work with "mount home = no" #1496

Merged
merged 1 commit into from
May 22, 2018
Merged

allow --home to still work with "mount home = no" #1496

merged 1 commit into from
May 22, 2018

Conversation

DrDaveD
Copy link
Collaborator

@DrDaveD DrDaveD commented Apr 30, 2018

Description of the Pull Request (PR):

This allows the --home command line option to still work even when "mount home = no" is set in singularity.conf. The comments in singularity.conf don't say anything about this option disabling setting the home directory on the command line, so although this changes functionality, it fixes a bug in the currently documented behavior.

This affects all versions of singularity that I know about, but it was particularly noticed with 2.4.6 because before that some of my users had specified both --bind and --home for the same mapping. With 2.4.6 the duplication was rejected, so the users removed the --bind, and then ran into one site that had set mount home = no, where the --home was silently ignored.

This fixes or addresses the following GitHub issues:

  • None

Checkoff for all PRs:

  • I have read the Guidelines for Contributing, and this PR conforms to the stated requirements.
  • I have added changes to the CHANGELOG and and documentation updates to the singularityware documentation base.
  • I have tested this PR locally with a make test
  • This PR is NOT against the project's master branch
  • I have added myself as a contributor to the contributors's file
  • This PR is ready for review and/or merge

Attn: @singularityware-admin

@DrDaveD
Copy link
Collaborator Author

DrDaveD commented May 15, 2018

I rebased on the current developement-2.x.

Copy link
Collaborator

@GodloveD GodloveD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dctrud, @jmstover, @gmkurtzer and I had a convo about this some time ago to determine whether or not this is something we want to do. We determined with @gmkurtzer's input that this was indeed his original intention. Therefore, I propose that we merge.

@GodloveD
Copy link
Collaborator

Oh, also, I tested this and it works and the code seems sensible to me as well.

@GodloveD GodloveD merged commit b9acc68 into apptainer:development-2.x May 22, 2018
@GodloveD
Copy link
Collaborator

Thanks @DrDaveD !

@DrDaveD DrDaveD deleted the allow-user-home-without-default-home branch May 22, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants