allow --home to still work with "mount home = no" #1496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
This allows the --home command line option to still work even when "mount home = no" is set in singularity.conf. The comments in singularity.conf don't say anything about this option disabling setting the home directory on the command line, so although this changes functionality, it fixes a bug in the currently documented behavior.
This affects all versions of singularity that I know about, but it was particularly noticed with 2.4.6 because before that some of my users had specified both --bind and --home for the same mapping. With 2.4.6 the duplication was rejected, so the users removed the --bind, and then ran into one site that had set mount home = no, where the --home was silently ignored.
This fixes or addresses the following GitHub issues:
Checkoff for all PRs:
make test
Attn: @singularityware-admin