Ignore spec.replicas for autoscaled MachineSets in ArgoCD sync
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template version: main (98d16f9)
We need to ignore changes to `spec.replica` when diffing *and* syncing MachineSets which are managed by a `MachineAutoscaler`. To do so we 1) dynamically configure `spec.ignoreDifferences` in the ArgoCD app to ignore `spec.replicas` of each `MachineSet` that's targeted by a `MachineAutoscaler` and 2) set ArgoCD sync option `RespectIgnoreDifferences=true` to ensure that we don't overwrite the machine autoscaler's value in `spec.replicas` if we're applying other changes.
simu
force-pushed
the
fix/autoscaling-sync
branch
from
a92cf7b to
51a65f8
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
|
Also folding the template update from #92 into this PR |
simu
changed the title
spec.replicas for autoscaled MachineSets during ArgoCD syncspec.replicas for autoscaled MachineSets in ArgoCD sync
DebakelOrakel
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ignore changes to
spec.replicawhen diffing and syncing MachineSets which are managed by aMachineAutoscaler.To do so we 1) dynamically configure
spec.ignoreDifferencesin the ArgoCD app to ignorespec.replicasof eachMachineSetthat's targeted by aMachineAutoscalerand 2) set ArgoCD sync optionRespectIgnoreDifferences=trueto ensure that we don't overwrite the machine autoscaler's value inspec.replicasif we're applying other changes.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.