[WIP] Nonnull operator #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…graphql#3088) using this `find src -name "*.js" -exec sh -c 'git mv "$0" "${0%.js}.ts"' {} \;` shell command renamed all files in `src`
Find this pattern `(\$)FlowFixMe\[(.*?)\]` and replace all
Co-Authored-By: Kamil Kisiela <[email protected]>
Using this patttern`(\$)FlowExpectedError\[(.*?)\]`
twof
commented
May 29, 2021
Comment on lines
+658
to
+661
| // This is invalid since an object could potentially be both the Object | ||
| // type IntBox and the interface type NonNullStringBox1. While that | ||
| // condition does not exist in the current schema, the schema could | ||
| // expand in the future to allow this. Thus it is invalid. |
There was a problem hiding this comment.
I think this comment needs to be updated to describe the test. It looks like this test is expected to succeed, but the comment indicates that it should fail
twof
commented
May 29, 2021
Comment on lines
+711
to
+714
| // This is invalid since an object could potentially be both the Object | ||
| // type IntBox and the interface type NonNullStringBox1. While that | ||
| // condition does not exist in the current schema, the schema could | ||
| // expand in the future to allow this. Thus it is invalid. |
twof
commented
Jun 9, 2021
Comment on lines
+1331
to
+1332
| message: 'Cannot return null for non-nullable field Food.name.', | ||
| path: ['food', 'theNameOfTheFood'], |
There was a problem hiding this comment.
In this case, we'd want the message to use the alias instead of the field name right?
|
Added a bunch of cases to |
twof
assigned aprilrd, magicmark, xuewei8910 and twof and unassigned aprilrd, magicmark and xuewei8910
magicmark
reviewed
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.