Integrate G4VG for use of in-memory conversion of Geant4->VecGeom geometries #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide new CreateVecGeomWorld static function taking a Geant4 physical volume, using G4VG to convert this in-memory using G4VG. Update AdePTTrackingManager to use this function if the GDML file entry in the configuration is empty, otherwise falling back to the VGDML convertor.
Reproduce example1's large stack test, leaving the AdePTTrackingManager GDML file configuration empty so that G4VG conversion is used. At present this is a pure check on a successful run with no reproducibility check between GDML/G4VG outputs.
Use of find_package with G4VG seems to encounter a few issues. Whilst those are resolved, just use FetchContent to get and use G4VG.
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #289 to integrate the now standalone celeritas-project/G4VG library into AdePT for in-memory geometry conversions without an intermediate GDML file. The as-submitted implementation is:
FetchContentmechanism to build it as part of AdePT.AdePTGeant4Integration::CreateVecGeomWorld(G4VPhysicalVolume const *physvol)is implemented to use G4VG to do the in-memory conversion.AdePTTrackingManager::InitializeAdePT()is updated to use that function ifAdePTConfiguration::fVecGeomGDMLis empty.AdePTConfiguration::fVecGeomGDML.I'm marking as draft as there's a final merge to do upstream in G4VG to get a proper commit to use, however, I wanted to start things off to get some initial CI checks done and for initial comments.That's done, so fully ready for review!