Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Combine some tools to a single binary. #10709

Merged
merged 1 commit into from
Oct 29, 2023
Merged

[Tooling] Combine some tools to a single binary. #10709

merged 1 commit into from
Oct 29, 2023

Conversation

grao1991
Copy link
Contributor

@grao1991 grao1991 commented Oct 27, 2023

Description

Combine aptos-debugger, db-tool, db-bootstrapper to one binary.

Test Plan

Existing tests.

@grao1991 grao1991 added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Oct 27, 2023
@grao1991 grao1991 force-pushed the grao_tool branch 4 times, most recently from 4642b80 to 2f36971 Compare October 27, 2023 21:17
@grao1991 grao1991 marked this pull request as ready for review October 27, 2023 21:18
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@grao1991 grao1991 force-pushed the grao_tool branch 4 times, most recently from 9bcf13e to fdc4070 Compare October 27, 2023 22:47
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@msmouse
Copy link
Contributor

msmouse commented Oct 28, 2023

Summary and test plan would be nice

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.2 ==> e24905109325ffa6cb92c6328923d88457c9dfb8

Compatibility test results for aptos-node-v1.7.2 ==> e24905109325ffa6cb92c6328923d88457c9dfb8 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.2
compatibility::simple-validator-upgrade::liveness-check : committed: 5088 txn/s, latency: 6609 ms, (p50: 6600 ms, p90: 9300 ms, p99: 12600 ms), latency samples: 188280
2. Upgrading first Validator to new version: e24905109325ffa6cb92c6328923d88457c9dfb8
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1720 txn/s, latency: 16392 ms, (p50: 19200 ms, p90: 22300 ms, p99: 24200 ms), latency samples: 92920
3. Upgrading rest of first batch to new version: e24905109325ffa6cb92c6328923d88457c9dfb8
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1777 txn/s, latency: 16504 ms, (p50: 19000 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92440
4. upgrading second batch to new version: e24905109325ffa6cb92c6328923d88457c9dfb8
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3620 txn/s, latency: 8729 ms, (p50: 9900 ms, p90: 11900 ms, p99: 12300 ms), latency samples: 144800
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> e24905109325ffa6cb92c6328923d88457c9dfb8 passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e24905109325ffa6cb92c6328923d88457c9dfb8

two traffics test: inner traffic : committed: 7872 txn/s, latency: 4977 ms, (p50: 4800 ms, p90: 6000 ms, p99: 9900 ms), latency samples: 3400880
two traffics test : committed: 100 txn/s, latency: 2246 ms, (p50: 2100 ms, p90: 2700 ms, p99: 4700 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.275, avg: 0.205", "QsPosToProposal: max: 0.183, avg: 0.156", "ConsensusProposalToOrdered: max: 0.646, avg: 0.615", "ConsensusOrderedToCommit: max: 0.574, avg: 0.523", "ConsensusProposalToCommit: max: 1.198, avg: 1.138"]
Max round gap was 1 [limit 4] at version 1554779. Max no progress secs was 4.441215 [limit 10] at version 1554779.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.2 ==> e24905109325ffa6cb92c6328923d88457c9dfb8

Compatibility test results for aptos-node-v1.7.2 ==> e24905109325ffa6cb92c6328923d88457c9dfb8 (PR)
Upgrade the nodes to version: e24905109325ffa6cb92c6328923d88457c9dfb8
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4129 txn/s, latency: 4961 ms, (p50: 4800 ms, p90: 7900 ms, p99: 8600 ms), latency samples: 256040
5. check swarm health
Compatibility test for aptos-node-v1.7.2 ==> e24905109325ffa6cb92c6328923d88457c9dfb8 passed
Test Ok

@grao1991 grao1991 merged commit b55ad61 into main Oct 29, 2023
11 of 14 checks passed
@grao1991 grao1991 deleted the grao_tool branch October 29, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants