Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cargo] Bump mini-moka to 0.10.3 #11604

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[Cargo] Bump mini-moka to 0.10.3 #11604

merged 1 commit into from
Jan 9, 2024

Conversation

JoshLind
Copy link
Contributor

@JoshLind JoshLind commented Jan 9, 2024

Description

This PR bumps mini-moka to 0.10.3 (in response to this known issue with 0.10.2: moka-rs/mini-moka#21)

Test Plan

Existing test infrastructure.

Copy link

trunk-io bot commented Jan 9, 2024

⏱️ 11h 51m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 4h 22m 🟩
rust-smoke-coverage 3h 1m 🟩
rust-unit-tests 53m 🟩
forge-framework-upgrade-test / forge 37m 🟥
rust-smoke-tests 30m 🟩
windows-build 29m 🟩🟩
execution-performance / single-node-performance 23m 🟩
forge-e2e-test / forge 16m 🟩
rust-lints 16m 🟩🟩
forge-compat-test / forge 15m 🟩
rust-images / rust-all 12m 🟩
run-tests-main-branch 8m 🟩🟩
check 8m 🟩🟩
cli-e2e-tests / run-cli-tests 7m 🟩
general-lints 5m 🟩🟩
check-dynamic-deps 4m 🟩🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 2m 🟩
node-api-compatibility-tests / node-api-compatibility-tests 58s 🟩
semgrep/ci 41s 🟩🟩
file_change_determinator 25s 🟩🟩
file_change_determinator 18s 🟩🟩
upload-to-codecov 16s 🟩
file_change_determinator 12s 🟩
execution-performance / file_change_determinator 9s 🟩
permission-check 8s 🟩🟩
execution-performance / sequential-execution-performance 7s 🟩
execution-performance / parallel-execution-performance 7s 🟩
permission-check 6s 🟩🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩
permission-check 1s 🟩
determine-docker-build-metadata 1s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
cli-e2e-tests / run-cli-tests 7m 9m -21%
windows-build 11m 19m -41%

settingsfeedbackdocs ⋅ learn more about trunk.io

@JoshLind JoshLind added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Jan 9, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 7a00c114f3c80117d0c57d101e7831ab4051a33a

Compatibility test results for aptos-node-v1.8.3 ==> 7a00c114f3c80117d0c57d101e7831ab4051a33a (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 3284 txn/s, latency: 6639 ms, (p50: 6300 ms, p90: 9600 ms, p99: 17200 ms), latency samples: 180640
2. Upgrading first Validator to new version: 7a00c114f3c80117d0c57d101e7831ab4051a33a
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1854 txn/s, latency: 15722 ms, (p50: 18600 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92700
3. Upgrading rest of first batch to new version: 7a00c114f3c80117d0c57d101e7831ab4051a33a
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1828 txn/s, latency: 16017 ms, (p50: 18900 ms, p90: 22200 ms, p99: 22300 ms), latency samples: 93260
4. upgrading second batch to new version: 7a00c114f3c80117d0c57d101e7831ab4051a33a
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3403 txn/s, latency: 9081 ms, (p50: 9800 ms, p90: 12900 ms, p99: 13200 ms), latency samples: 146360
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 7a00c114f3c80117d0c57d101e7831ab4051a33a passed
Test Ok

Copy link
Contributor

github-actions bot commented Jan 9, 2024

✅ Forge suite realistic_env_max_load success on 7a00c114f3c80117d0c57d101e7831ab4051a33a

two traffics test: inner traffic : committed: 7566 txn/s, latency: 5116 ms, (p50: 4800 ms, p90: 6300 ms, p99: 12800 ms), latency samples: 3276460
two traffics test : committed: 100 txn/s, latency: 2394 ms, (p50: 2200 ms, p90: 2600 ms, p99: 9400 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.205, avg: 0.197", "QsPosToProposal: max: 0.200, avg: 0.154", "ConsensusProposalToOrdered: max: 0.614, avg: 0.565", "ConsensusOrderedToCommit: max: 0.534, avg: 0.509", "ConsensusProposalToCommit: max: 1.114, avg: 1.074"]
Max round gap was 1 [limit 4] at version 1450533. Max no progress secs was 4.271841 [limit 10] at version 1450533.
Test Ok

Copy link
Contributor

github-actions bot commented Jan 9, 2024

❌ Forge suite framework_upgrade failure on aptos-node-v1.8.3 ==> 7a00c114f3c80117d0c57d101e7831ab4051a33a

Compatibility test results for aptos-node-v1.8.3 ==> 7a00c114f3c80117d0c57d101e7831ab4051a33a (PR)
Upgrade the nodes to version: 7a00c114f3c80117d0c57d101e7831ab4051a33a
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-11604.svc:8080/v1/estimate_gas_price): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>
Trailing Log Lines:
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at testsuite/forge/src/backend/k8s/swarm.rs:676:18:
called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-11604" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-11604\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-11604" not found: NotFound

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: __libc_start_main
  16: <unknown>
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

@JoshLind JoshLind merged commit 123de83 into main Jan 9, 2024
82 of 84 checks passed
@JoshLind JoshLind deleted the bump_mini_moka branch January 9, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants