Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out collection creator and owner permissions (#14307) #14376

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JohnChangUK
Copy link
Member

Description

Cherry pick of #14307

* Separate out collection creator and owner permissions
Copy link

trunk-io bot commented Aug 22, 2024

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (aptos-release-v1.18@7ccf8a5). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             aptos-release-v1.18   #14376   +/-   ##
======================================================
  Coverage                       ?    59.1%           
======================================================
  Files                          ?      828           
  Lines                          ?   201867           
  Branches                       ?        0           
======================================================
  Hits                           ?   119332           
  Misses                         ?    82535           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnChangUK JohnChangUK enabled auto-merge (squash) August 22, 2024 17:17

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 9802bd084aadcd3565e95ca7f72ff940212875e5 ==> 49e38f52855b264980a30b032eb30fff4dcf11c6

Compatibility test results for 9802bd084aadcd3565e95ca7f72ff940212875e5 ==> 49e38f52855b264980a30b032eb30fff4dcf11c6 (PR)
1. Check liveness of validators at old version: 9802bd084aadcd3565e95ca7f72ff940212875e5
compatibility::simple-validator-upgrade::liveness-check : committed: 9029.40 txn/s, latency: 3223.37 ms, (p50: 2400 ms, p90: 6000 ms, p99: 15700 ms), latency samples: 358980
2. Upgrading first Validator to new version: 49e38f52855b264980a30b032eb30fff4dcf11c6
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7268.37 txn/s, latency: 3885.14 ms, (p50: 4400 ms, p90: 4800 ms, p99: 5000 ms), latency samples: 135080
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 8022.35 txn/s, latency: 4027.90 ms, (p50: 4200 ms, p90: 4500 ms, p99: 4700 ms), latency samples: 266060
3. Upgrading rest of first batch to new version: 49e38f52855b264980a30b032eb30fff4dcf11c6
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7065.13 txn/s, latency: 3769.17 ms, (p50: 4000 ms, p90: 5300 ms, p99: 5400 ms), latency samples: 127740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7417.42 txn/s, latency: 4253.61 ms, (p50: 4100 ms, p90: 6700 ms, p99: 7000 ms), latency samples: 245840
4. upgrading second batch to new version: 49e38f52855b264980a30b032eb30fff4dcf11c6
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10621.01 txn/s, latency: 2600.52 ms, (p50: 2700 ms, p90: 3300 ms, p99: 4600 ms), latency samples: 194800
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10640.21 txn/s, latency: 3005.92 ms, (p50: 2800 ms, p90: 3700 ms, p99: 4600 ms), latency samples: 361480
5. check swarm health
Compatibility test for 9802bd084aadcd3565e95ca7f72ff940212875e5 ==> 49e38f52855b264980a30b032eb30fff4dcf11c6 passed
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on 9802bd084aadcd3565e95ca7f72ff940212875e5 ==> 49e38f52855b264980a30b032eb30fff4dcf11c6

Compatibility test results for 9802bd084aadcd3565e95ca7f72ff940212875e5 ==> 49e38f52855b264980a30b032eb30fff4dcf11c6 (PR)
Upgrade the nodes to version: 49e38f52855b264980a30b032eb30fff4dcf11c6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1188.52 txn/s, submitted: 1191.65 txn/s, failed submission: 3.14 txn/s, expired: 3.14 txn/s, latency: 2450.86 ms, (p50: 2100 ms, p90: 4400 ms, p99: 6300 ms), latency samples: 106060
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1228.05 txn/s, submitted: 1231.30 txn/s, failed submission: 3.25 txn/s, expired: 3.25 txn/s, latency: 2631.03 ms, (p50: 2100 ms, p90: 5100 ms, p99: 6600 ms), latency samples: 105680
5. check swarm health
Compatibility test for 9802bd084aadcd3565e95ca7f72ff940212875e5 ==> 49e38f52855b264980a30b032eb30fff4dcf11c6 passed
Upgrade the remaining nodes to version: 49e38f52855b264980a30b032eb30fff4dcf11c6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1221.05 txn/s, submitted: 1222.85 txn/s, failed submission: 1.80 txn/s, expired: 1.80 txn/s, latency: 2546.30 ms, (p50: 2100 ms, p90: 4200 ms, p99: 6500 ms), latency samples: 108300
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 49e38f52855b264980a30b032eb30fff4dcf11c6

two traffics test: inner traffic : committed: 11631.94 txn/s, latency: 3416.70 ms, (p50: 3300 ms, p90: 3900 ms, p99: 7500 ms), latency samples: 4422680
two traffics test : committed: 100.01 txn/s, latency: 2920.97 ms, (p50: 2600 ms, p90: 3900 ms, p99: 5100 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.261, avg: 0.230", "QsPosToProposal: max: 0.712, avg: 0.481", "ConsensusProposalToOrdered: max: 0.367, avg: 0.337", "ConsensusOrderedToCommit: max: 0.728, avg: 0.679", "ConsensusProposalToCommit: max: 1.051, avg: 1.015"]
Max round gap was 1 [limit 4] at version 1308403. Max no progress secs was 7.983776 [limit 15] at version 4896731.
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants