Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cp][aptos-release-v1.24] [loader-v2] Addressing simple loader V2 TODOs #15342

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[cp][aptos-release-v1.24] [loader-v2] Addressing simple loader V2 TODOs #15342

merged 1 commit into from
Nov 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport

This will backport the following commits from main to aptos-release-v1.24:

Questions ?

Please refer to the Backport tool documentation

@georgemitenkov
[loader-v2] Addressing TODOs (#15316)
8038146 
- Switching from undefined to script location
- Keeping error remapping because the status code exists on-chain.
   It is probably fine t keep it as is.
- Removed useless TODO for alerts on concurrent manager uses.
- Changed errors.rs TODO into a note, as it is not a P0/P1/P2 to fix.

(cherry picked from commit dbdb613)
@github-actions github-actions bot requested a review from gelash as a code owner November 20, 2024 22:26
@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 20, 2024 •
edited
Loading

⏱️ 1h 18m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 25m 🟩 
rust-unit-tests 22m 🟩 
rust-move-tests 9m 🟩 
rust-doc-tests 5m 🟩 
test-target-determinator 4m 🟩 
execution-performance / test-target-determinator 4m 🟩 
check 4m 🟩 
rust-cargo-deny 2m 🟩 
fetch-last-released-docker-image-tag 2m 🟩 
check-dynamic-deps 35s 🟩 
general-lints 26s 🟩 
semgrep/ci 23s 🟩 
file_change_determinator 21s 🟩 
file_change_determinator 11s 🟩 
permission-check 7s 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
9 tasks
@georgemitenkov georgemitenkov enabled auto-merge (squash) November 21, 2024 19:32
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor Author

✅ Forge suite realistic_env_max_load success on 8038146d181fbfbfc2d172e83dea4cd87a255b5e

two traffics test: inner traffic : committed: 14521.23 txn/s, latency: 2738.99 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 5521340
two traffics test : committed: 99.96 txn/s, latency: 1413.63 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 1800 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.944, avg: 1.520", "ConsensusProposalToOrdered: max: 0.316, avg: 0.291", "ConsensusOrderedToCommit: max: 0.375, avg: 0.361", "ConsensusProposalToCommit: max: 0.661, avg: 0.653"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.02s no progress at version 2516344 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.45s no progress at version 2516342 (avg 8.45s) [limit 15].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor Author

✅ Forge suite framework_upgrade success on 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> 8038146d181fbfbfc2d172e83dea4cd87a255b5e

Compatibility test results for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> 8038146d181fbfbfc2d172e83dea4cd87a255b5e (PR)
Upgrade the nodes to version: 8038146d181fbfbfc2d172e83dea4cd87a255b5e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1305.33 txn/s, submitted: 1308.04 txn/s, failed submission: 2.71 txn/s, expired: 2.71 txn/s, latency: 2450.97 ms, (p50: 2100 ms, p70: 2700, p90: 4200 ms, p99: 5700 ms), latency samples: 115620
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1260.06 txn/s, submitted: 1261.81 txn/s, failed submission: 1.76 txn/s, expired: 1.76 txn/s, latency: 2408.08 ms, (p50: 2300 ms, p70: 2400, p90: 3900 ms, p99: 5400 ms), latency samples: 114800
5. check swarm health
Compatibility test for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> 8038146d181fbfbfc2d172e83dea4cd87a255b5e passed
Upgrade the remaining nodes to version: 8038146d181fbfbfc2d172e83dea4cd87a255b5e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1290.68 txn/s, submitted: 1294.06 txn/s, failed submission: 3.37 txn/s, expired: 3.37 txn/s, latency: 2364.14 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5100 ms), latency samples: 114780
Test Ok

@github-actions GitHub Actions
Copy link
Contributor Author

✅ Forge suite compat success on 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> 8038146d181fbfbfc2d172e83dea4cd87a255b5e

Compatibility test results for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> 8038146d181fbfbfc2d172e83dea4cd87a255b5e (PR)
1. Check liveness of validators at old version: 78db50320d1ba1ca1a61adb189b0b4fde0098f27
compatibility::simple-validator-upgrade::liveness-check : committed: 15301.80 txn/s, latency: 2073.79 ms, (p50: 1900 ms, p70: 2000, p90: 2200 ms, p99: 7600 ms), latency samples: 584260
2. Upgrading first Validator to new version: 8038146d181fbfbfc2d172e83dea4cd87a255b5e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8033.01 txn/s, latency: 3590.29 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4400 ms), latency samples: 147820
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 8164.55 txn/s, latency: 3976.92 ms, (p50: 4300 ms, p70: 4300, p90: 4400 ms, p99: 4500 ms), latency samples: 270840
3. Upgrading rest of first batch to new version: 8038146d181fbfbfc2d172e83dea4cd87a255b5e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7924.18 txn/s, latency: 3492.20 ms, (p50: 3600 ms, p70: 4000, p90: 4800 ms, p99: 5100 ms), latency samples: 146040
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7694.28 txn/s, latency: 4152.50 ms, (p50: 4300 ms, p70: 4300, p90: 6300 ms, p99: 6600 ms), latency samples: 256380
4. upgrading second batch to new version: 8038146d181fbfbfc2d172e83dea4cd87a255b5e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12190.54 txn/s, latency: 2277.75 ms, (p50: 2400 ms, p70: 2600, p90: 2900 ms, p99: 3100 ms), latency samples: 208520
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11841.91 txn/s, latency: 2672.52 ms, (p50: 2600 ms, p70: 2800, p90: 3000 ms, p99: 4200 ms), latency samples: 384040
5. check swarm health
Compatibility test for 78db50320d1ba1ca1a61adb189b0b4fde0098f27 ==> 8038146d181fbfbfc2d172e83dea4cd87a255b5e passed
Test Ok

@georgemitenkov georgemitenkov merged commit a734d23 into aptos-release-v1.24 Nov 21, 2024
45 of 46 checks passed
@georgemitenkov georgemitenkov deleted the backport/aptos-release-v1.24/pr-15316 branch November 21, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-aptos igor-aptos igor-aptos approved these changes

@georgemitenkov georgemitenkov georgemitenkov approved these changes

@gelash gelash Awaiting requested review from gelash gelash is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 is a code owner

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl danielxiangzl is a code owner

@davidiw davidiw Awaiting requested review from davidiw

@grao1991 grao1991 Awaiting requested review from grao1991

@lightmark lightmark Awaiting requested review from lightmark

@msmouse msmouse Awaiting requested review from msmouse

@runtian-zhou runtian-zhou Awaiting requested review from runtian-zhou

@vgao1996 vgao1996 Awaiting requested review from vgao1996

@wrwg wrwg Awaiting requested review from wrwg

@ziaptos ziaptos Awaiting requested review from ziaptos

Assignees

@thepomeranian thepomeranian

Labels
cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgemitenkov @igor-aptos @thepomeranian