Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Remove hardhat on Move #15462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Dec 3, 2024

Description

We do not need hardhat on Move.

  1. No one work or will work on this in the near future.
  2. If ecosystem builds things, it is better that we keep move repo small and nice, and things like "move-on-evm" are built around. Otherwise we end up changing Move in order to make sure EVM things work (which is the case of V1 compiler, and its EVM and async flavours)
  3. Even if we want to keep Move to yul, etc., hardhat is really not needed, + we have Aptos workspace.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 3, 2024

⏱️ 17m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-cargo-deny 2m 🟩
check-dynamic-deps 40s 🟩
general-lints 31s 🟩
semgrep/ci 20s 🟩
file_change_determinator 14s 🟩
permission-check 4s 🟩
permission-check 2s 🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

georgemitenkov commented Dec 3, 2024

@georgemitenkov georgemitenkov marked this pull request as ready for review December 3, 2024 15:42
@georgemitenkov georgemitenkov force-pushed the george/move-on-aptos-fixes branch from b020c0c to e88cfa2 Compare December 5, 2024 18:35
Base automatically changed from george/move-on-aptos-fixes to main December 5, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants