Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler-v2] Do not include vector module for compiler v1 #15484

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

vineethk
Copy link
Contributor

@vineethk vineethk commented Dec 4, 2024

Description

Since a previous PR (#12534), we have always been including the vector module explicitly for both compiler v1 and v2. Due to how compiler v1 handles this in the naming stage, we can run into errors (https://github.com/aptos-labs/aptos-core/actions/runs/12148042105/job/33875645489?pr=14862#step:5:16470) when the vector module includes additional dependencies (such as in this PR: #14862).

In this PR, we only (implicitly) include vector module for v2, and not for v1.

How Has This Been Tested?

Type of Change

  • Bug fix

Which Components or Systems Does This Change Impact?

  • Move Compiler

Copy link

trunk-io bot commented Dec 4, 2024

⏱️ 6h 25m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 2h 🟩🟥🟥🟥🟩 (+1 more)
execution-performance / test-target-determinator 27m 🟩🟩🟩🟩🟩 (+1 more)
test-target-determinator 26m 🟩🟩🟩🟩🟩 (+1 more)
check 22m 🟩🟩🟩🟩🟩 (+1 more)
rust-targeted-unit-tests 20m 🟩
forge-framework-upgrade-test / forge 15m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 11m 🟩🟩🟩🟩🟩 (+1 more)
forge-compat-test / forge 9m 🟥
rust-move-tests 8m

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

vineethk commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vineethk vineethk marked this pull request as ready for review December 4, 2024 00:52
@vineethk vineethk enabled auto-merge (squash) December 4, 2024 01:50

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite realistic_env_max_load success on 949071799ec0b5bbaff397caec3846026b3b866a

two traffics test: inner traffic : committed: 14846.05 txn/s, latency: 2675.48 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5644780
two traffics test : committed: 100.02 txn/s, latency: 1401.61 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 2600 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.558, avg: 1.493", "ConsensusProposalToOrdered: max: 0.311, avg: 0.287", "ConsensusOrderedToCommit: max: 0.387, avg: 0.373", "ConsensusProposalToCommit: max: 0.673, avg: 0.660"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 6375922 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.62s no progress at version 2072993 (avg 0.57s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite compat success on 3527aa2e299553b759c515d9843586bad48c802c ==> 949071799ec0b5bbaff397caec3846026b3b866a

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> 949071799ec0b5bbaff397caec3846026b3b866a (PR)
1. Check liveness of validators at old version: 3527aa2e299553b759c515d9843586bad48c802c
compatibility::simple-validator-upgrade::liveness-check : committed: 14619.33 txn/s, latency: 2282.98 ms, (p50: 2000 ms, p70: 2200, p90: 3300 ms, p99: 4500 ms), latency samples: 479620
2. Upgrading first Validator to new version: 949071799ec0b5bbaff397caec3846026b3b866a
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5956.06 txn/s, latency: 4859.01 ms, (p50: 5400 ms, p70: 6000, p90: 6100 ms, p99: 6300 ms), latency samples: 111900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6418.37 txn/s, latency: 5117.61 ms, (p50: 5100 ms, p70: 5700, p90: 6100 ms, p99: 6900 ms), latency samples: 209060
3. Upgrading rest of first batch to new version: 949071799ec0b5bbaff397caec3846026b3b866a
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7388.61 txn/s, latency: 3882.05 ms, (p50: 4300 ms, p70: 4500, p90: 4700 ms, p99: 4800 ms), latency samples: 139080
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7058.92 txn/s, latency: 4638.43 ms, (p50: 4800 ms, p70: 4900, p90: 5800 ms, p99: 6700 ms), latency samples: 227220
4. upgrading second batch to new version: 949071799ec0b5bbaff397caec3846026b3b866a
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12915.11 txn/s, latency: 2137.50 ms, (p50: 2200 ms, p70: 2500, p90: 2800 ms, p99: 2900 ms), latency samples: 223180
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 13126.88 txn/s, latency: 2395.48 ms, (p50: 2200 ms, p70: 2800, p90: 2900 ms, p99: 3400 ms), latency samples: 425140
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> 949071799ec0b5bbaff397caec3846026b3b866a passed
Test Ok

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ Forge suite framework_upgrade success on 3527aa2e299553b759c515d9843586bad48c802c ==> 949071799ec0b5bbaff397caec3846026b3b866a

Compatibility test results for 3527aa2e299553b759c515d9843586bad48c802c ==> 949071799ec0b5bbaff397caec3846026b3b866a (PR)
Upgrade the nodes to version: 949071799ec0b5bbaff397caec3846026b3b866a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1462.04 txn/s, submitted: 1466.52 txn/s, failed submission: 4.48 txn/s, expired: 4.48 txn/s, latency: 2096.60 ms, (p50: 1800 ms, p70: 2100, p90: 3400 ms, p99: 4700 ms), latency samples: 123920
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1427.40 txn/s, submitted: 1430.11 txn/s, failed submission: 2.71 txn/s, expired: 2.71 txn/s, latency: 2153.31 ms, (p50: 2000 ms, p70: 2300, p90: 3600 ms, p99: 4600 ms), latency samples: 126620
5. check swarm health
Compatibility test for 3527aa2e299553b759c515d9843586bad48c802c ==> 949071799ec0b5bbaff397caec3846026b3b866a passed
Upgrade the remaining nodes to version: 949071799ec0b5bbaff397caec3846026b3b866a
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1389.50 txn/s, submitted: 1393.33 txn/s, failed submission: 3.83 txn/s, expired: 3.83 txn/s, latency: 2175.98 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4200 ms), latency samples: 123340
Test Ok

@vineethk vineethk merged commit 966452a into main Dec 4, 2024
43 of 46 checks passed
@vineethk vineethk deleted the vk/vector-module-inclusion-fix branch December 4, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants