Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable delegation_pool_partial_governance_voting by default #15549

Merged

Conversation

junkil-park
Copy link
Contributor

@junkil-park junkil-park commented Dec 10, 2024

Description

The feature flag delegation_pool_partial_governance_voting has been successfully enabled on both the testnet and mainnet. However, it is not part of the default feature set for devnet.

Including this feature in the default feature set causes many Move unit tests to fail, as they were not written to accommodate the feature. The affected unit tests have been updated accordingly, and a new test case has been added to test the behavior of the feature enabled.

Partially resolves #15305.

How Has This Been Tested?

Move Unit Test

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (Devnet)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

- enable DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING
- fix the broken tests due to that.
Copy link

trunk-io bot commented Dec 10, 2024

⏱️ 1h 24m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 30m 🟥🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-doc-tests 5m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 5m 🟩
rust-cargo-deny 4m 🟩🟩
check 4m 🟩
fetch-last-released-docker-image-tag 2m 🟩
check-dynamic-deps 1m 🟩🟩
general-lints 55s 🟩🟩
semgrep/ci 49s 🟩🟩
file_change_determinator 18s 🟩🟩
file_change_determinator 10s 🟩
permission-check 10s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 24m 18m +30%

settingsfeedbackdocs ⋅ learn more about trunk.io

@junkil-park junkil-park changed the title Enable DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING by default Enable delegation_pool_partial_governance_voting by default Dec 10, 2024
@junkil-park junkil-park requested a review from sherry-x December 10, 2024 17:25
@junkil-park junkil-park enabled auto-merge (squash) December 11, 2024 20:50

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 16736.95 txn/s, latency: 1998.29 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2500 ms), latency samples: 550340
2. Upgrading first Validator to new version: 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6901.77 txn/s, latency: 4135.22 ms, (p50: 4600 ms, p70: 5000, p90: 5000 ms, p99: 5100 ms), latency samples: 128940
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6787.63 txn/s, latency: 4713.99 ms, (p50: 5000 ms, p70: 5100, p90: 5200 ms, p99: 5300 ms), latency samples: 233160
3. Upgrading rest of first batch to new version: 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7867.82 txn/s, latency: 3638.10 ms, (p50: 4100 ms, p70: 4200, p90: 4300 ms, p99: 4500 ms), latency samples: 145600
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 8095.18 txn/s, latency: 4025.91 ms, (p50: 4300 ms, p70: 4400, p90: 4400 ms, p99: 4800 ms), latency samples: 271440
4. upgrading second batch to new version: 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11614.50 txn/s, latency: 2371.58 ms, (p50: 2500 ms, p70: 2700, p90: 3000 ms, p99: 3100 ms), latency samples: 202000
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11922.04 txn/s, latency: 2665.35 ms, (p50: 2700 ms, p70: 3000, p90: 3100 ms, p99: 3300 ms), latency samples: 386980
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9

two traffics test: inner traffic : committed: 13414.22 txn/s, submitted: 13414.90 txn/s, expired: 0.68 txn/s, latency: 2958.08 ms, (p50: 2700 ms, p70: 3000, p90: 3400 ms, p99: 5100 ms), latency samples: 5100380
two traffics test : committed: 100.03 txn/s, latency: 1489.87 ms, (p50: 1400 ms, p70: 1500, p90: 1700 ms, p99: 3500 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.741, avg: 1.540", "ConsensusProposalToOrdered: max: 0.330, avg: 0.310", "ConsensusOrderedToCommit: max: 0.387, avg: 0.365", "ConsensusProposalToCommit: max: 0.704, avg: 0.676"]
Max non-epoch-change gap was: 1 rounds at version 632735 (avg 0.00) [limit 4], 1.92s no progress at version 5018861 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.83s no progress at version 5802998 (avg 0.77s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9 (PR)
Upgrade the nodes to version: 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1622.26 txn/s, submitted: 1626.00 txn/s, failed submission: 3.75 txn/s, expired: 3.75 txn/s, latency: 1935.36 ms, (p50: 1800 ms, p70: 2100, p90: 2400 ms, p99: 3600 ms), latency samples: 138580
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1541.24 txn/s, submitted: 1545.96 txn/s, failed submission: 4.72 txn/s, expired: 4.72 txn/s, latency: 1939.87 ms, (p50: 1800 ms, p70: 2100, p90: 2400 ms, p99: 3600 ms), latency samples: 137080
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9 passed
Upgrade the remaining nodes to version: 48a8e553801faa0b49eb6d0a19ce2b248cbb92d9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1422.59 txn/s, submitted: 1425.68 txn/s, failed submission: 3.09 txn/s, expired: 3.09 txn/s, latency: 2112.78 ms, (p50: 2100 ms, p70: 2400, p90: 2900 ms, p99: 3900 ms), latency samples: 129000
Test Ok

@junkil-park junkil-park merged commit 652be07 into main Dec 11, 2024
87 of 90 checks passed
@junkil-park junkil-park deleted the jpark/enable-DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING branch December 11, 2024 21:57
georgemitenkov pushed a commit that referenced this pull request Jan 6, 2025
- enable DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING
- fix the broken tests due to that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain Staking-Related Feature Flags Excluded from Devnet Default Set
3 participants