-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable delegation_pool_partial_governance_voting by default #15549
Merged
junkil-park
merged 1 commit into
main
from
jpark/enable-DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING
Dec 11, 2024
Merged
Enable delegation_pool_partial_governance_voting by default #15549
junkil-park
merged 1 commit into
main
from
jpark/enable-DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING - fix the broken tests due to that.
junkil-park
requested review from
davidiw,
movekevin and
wrwg
as code owners
December 10, 2024 05:56
⏱️ 1h 24m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
junkil-park
changed the title
Enable DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING by default
Enable delegation_pool_partial_governance_voting by default
Dec 10, 2024
sherry-x
approved these changes
Dec 11, 2024
JohnChangUK
approved these changes
Dec 11, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
junkil-park
deleted the
jpark/enable-DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING
branch
December 11, 2024 21:57
georgemitenkov
pushed a commit
that referenced
this pull request
Jan 6, 2025
- enable DELEGATION_POOL_PARTIAL_GOVERNANCE_VOTING - fix the broken tests due to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The feature flag
delegation_pool_partial_governance_voting
has been successfully enabled on both the testnet and mainnet. However, it is not part of the default feature set for devnet.Including this feature in the default feature set causes many Move unit tests to fail, as they were not written to accommodate the feature. The affected unit tests have been updated accordingly, and a new test case has been added to test the behavior of the feature enabled.
Partially resolves #15305.
How Has This Been Tested?
Move Unit Test
Type of Change
Which Components or Systems Does This Change Impact?
Checklist