Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable partial_governance_voting #15553

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

junkil-park
Copy link
Contributor

Description

The feature flag partial_governance_voting has been successfully enabled on both the testnet and mainnet. However, it is not part of the default feature set for devnet.

Including this feature in the default feature set causes many Move unit tests to fail, as they were not written to accommodate the feature. The affected unit tests have been updated accordingly.

Partially resolves #15305.

How Has This Been Tested?

Move unit tests

Key Areas to Review

Unit test updates

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (Devnet)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 10, 2024

⏱️ 3h 10m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 6m 🟩🟩🟩
rust-move-tests 14m 🟩
execution-performance / test-target-determinator 13m 🟩🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟥
test-target-determinator 10m 🟩🟩
check 9m 🟩🟩
rust-cargo-deny 8m 🟩🟩🟩🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩 (+1 more)
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 5m 🟩🟩🟩
general-lints 3m 🟩🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩 (+1 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@junkil-park junkil-park force-pushed the jpark/enable_partial_governance_voting branch 2 times, most recently from 1975f65 to fb462c3 Compare December 11, 2024 02:31
@junkil-park junkil-park enabled auto-merge (squash) December 11, 2024 02:31
- Enable the feature flag partial_governance_voting by default
- Adjust the Move unit tests
@junkil-park junkil-park force-pushed the jpark/enable_partial_governance_voting branch from fb462c3 to 0449ceb Compare December 11, 2024 02:33

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@junkil-park junkil-park disabled auto-merge December 11, 2024 04:32
@junkil-park junkil-park enabled auto-merge (squash) December 11, 2024 04:32

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0449ceb60e73ce35274830847b956d71c79c983b

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0449ceb60e73ce35274830847b956d71c79c983b (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 16868.04 txn/s, latency: 1982.22 ms, (p50: 1900 ms, p70: 2100, p90: 2400 ms, p99: 3600 ms), latency samples: 553040
2. Upgrading first Validator to new version: 0449ceb60e73ce35274830847b956d71c79c983b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7545.01 txn/s, latency: 3801.19 ms, (p50: 4200 ms, p70: 4500, p90: 4600 ms, p99: 4700 ms), latency samples: 141760
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7646.48 txn/s, latency: 4256.23 ms, (p50: 4600 ms, p70: 4700, p90: 5000 ms, p99: 5300 ms), latency samples: 252900
3. Upgrading rest of first batch to new version: 0449ceb60e73ce35274830847b956d71c79c983b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6850.33 txn/s, latency: 4166.50 ms, (p50: 4700 ms, p70: 4900, p90: 5200 ms, p99: 5600 ms), latency samples: 129220
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7135.40 txn/s, latency: 4635.86 ms, (p50: 5000 ms, p70: 5100, p90: 5300 ms, p99: 5400 ms), latency samples: 235060
4. upgrading second batch to new version: 0449ceb60e73ce35274830847b956d71c79c983b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11770.86 txn/s, latency: 2335.10 ms, (p50: 2300 ms, p70: 2700, p90: 3200 ms, p99: 3300 ms), latency samples: 208000
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12129.86 txn/s, latency: 2560.94 ms, (p50: 2300 ms, p70: 3100, p90: 3400 ms, p99: 3500 ms), latency samples: 397680
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0449ceb60e73ce35274830847b956d71c79c983b passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 0449ceb60e73ce35274830847b956d71c79c983b

two traffics test: inner traffic : committed: 14623.81 txn/s, latency: 2716.57 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5560280
two traffics test : committed: 99.91 txn/s, latency: 1405.56 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1800 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.552, avg: 1.519", "ConsensusProposalToOrdered: max: 0.323, avg: 0.294", "ConsensusOrderedToCommit: max: 0.377, avg: 0.366", "ConsensusProposalToCommit: max: 0.667, avg: 0.660"]
Max non-epoch-change gap was: 1 rounds at version 28989 (avg 0.00) [limit 4], 2.17s no progress at version 28989 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.65s no progress at version 2873667 (avg 0.65s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0449ceb60e73ce35274830847b956d71c79c983b

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0449ceb60e73ce35274830847b956d71c79c983b (PR)
Upgrade the nodes to version: 0449ceb60e73ce35274830847b956d71c79c983b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1462.38 txn/s, submitted: 1465.49 txn/s, failed submission: 3.11 txn/s, expired: 3.11 txn/s, latency: 2249.10 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 4500 ms), latency samples: 122220
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1408.31 txn/s, submitted: 1412.85 txn/s, failed submission: 4.54 txn/s, expired: 4.54 txn/s, latency: 2112.17 ms, (p50: 1900 ms, p70: 2400, p90: 3000 ms, p99: 5400 ms), latency samples: 124080
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 0449ceb60e73ce35274830847b956d71c79c983b passed
Upgrade the remaining nodes to version: 0449ceb60e73ce35274830847b956d71c79c983b
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1396.52 txn/s, submitted: 1399.84 txn/s, failed submission: 3.32 txn/s, expired: 3.32 txn/s, latency: 2114.95 ms, (p50: 2100 ms, p70: 2400, p90: 2900 ms, p99: 4000 ms), latency samples: 126360
Test Ok

@junkil-park junkil-park merged commit eb23d6f into main Dec 11, 2024
87 of 89 checks passed
@junkil-park junkil-park deleted the jpark/enable_partial_governance_voting branch December 11, 2024 05:04
georgemitenkov pushed a commit that referenced this pull request Jan 6, 2025
- Enable the feature flag partial_governance_voting by default
- Adjust the Move unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain Staking-Related Feature Flags Excluded from Devnet Default Set
3 participants