Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Bump version to 5.0.0 #15562

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[CLI] Bump version to 5.0.0 #15562

merged 1 commit into from
Dec 11, 2024

Conversation

banool
Copy link
Contributor

@banool banool commented Dec 11, 2024

Description

Version bump for CLI release.

How Has This Been Tested?

N/A, see CI.

Key Areas to Review

N/A

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@banool banool requested a review from gregnazario as a code owner December 11, 2024 19:22
Copy link

trunk-io bot commented Dec 11, 2024

⏱️ 40m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-doc-tests 5m 🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
check-dynamic-deps 3m 🟩🟩
rust-cargo-deny 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 58s 🟩🟩
semgrep/ci 44s 🟩🟩
rust-move-tests 25s
file_change_determinator 22s 🟩🟩
file_change_determinator 12s 🟩
execution-performance / single-node-performance 10s 🟩
permission-check 6s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +98%
execution-performance / single-node-performance 10s 16m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@banool banool enabled auto-merge (squash) December 11, 2024 19:22

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on fb1d2637d998a4f4321bd1aefd5619a80d675c57

two traffics test: inner traffic : committed: 14650.01 txn/s, latency: 2710.33 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5570260
two traffics test : committed: 100.01 txn/s, latency: 1429.23 ms, (p50: 1400 ms, p70: 1500, p90: 1500 ms, p99: 1700 ms), latency samples: 1640
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.557, avg: 1.512", "ConsensusProposalToOrdered: max: 0.326, avg: 0.293", "ConsensusOrderedToCommit: max: 0.375, avg: 0.366", "ConsensusProposalToCommit: max: 0.666, avg: 0.660"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.05s no progress at version 31145 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.69s no progress at version 2746209 (avg 0.69s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> fb1d2637d998a4f4321bd1aefd5619a80d675c57

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> fb1d2637d998a4f4321bd1aefd5619a80d675c57 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 15821.92 txn/s, latency: 2115.00 ms, (p50: 2100 ms, p70: 2200, p90: 2700 ms, p99: 4200 ms), latency samples: 515540
2. Upgrading first Validator to new version: fb1d2637d998a4f4321bd1aefd5619a80d675c57
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5888.39 txn/s, latency: 4977.63 ms, (p50: 5600 ms, p70: 5900, p90: 6100 ms, p99: 6200 ms), latency samples: 111900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5808.84 txn/s, latency: 5643.62 ms, (p50: 6000 ms, p70: 6100, p90: 6200 ms, p99: 6300 ms), latency samples: 201460
3. Upgrading rest of first batch to new version: fb1d2637d998a4f4321bd1aefd5619a80d675c57
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6867.72 txn/s, latency: 4181.40 ms, (p50: 4800 ms, p70: 5000, p90: 5200 ms, p99: 5400 ms), latency samples: 125300
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6939.05 txn/s, latency: 4730.07 ms, (p50: 5100 ms, p70: 5200, p90: 5300 ms, p99: 5600 ms), latency samples: 233460
4. upgrading second batch to new version: fb1d2637d998a4f4321bd1aefd5619a80d675c57
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11311.58 txn/s, latency: 2441.91 ms, (p50: 2600 ms, p70: 2900, p90: 3100 ms, p99: 3300 ms), latency samples: 195680
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12027.56 txn/s, latency: 2647.44 ms, (p50: 2600 ms, p70: 2900, p90: 3100 ms, p99: 3600 ms), latency samples: 390460
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> fb1d2637d998a4f4321bd1aefd5619a80d675c57 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> fb1d2637d998a4f4321bd1aefd5619a80d675c57

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> fb1d2637d998a4f4321bd1aefd5619a80d675c57 (PR)
Upgrade the nodes to version: fb1d2637d998a4f4321bd1aefd5619a80d675c57
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 668.08 txn/s, submitted: 668.97 txn/s, failed submission: 0.89 txn/s, expired: 0.89 txn/s, latency: 4568.94 ms, (p50: 4200 ms, p70: 6400, p90: 8300 ms, p99: 9000 ms), latency samples: 59900
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1434.92 txn/s, submitted: 1436.93 txn/s, failed submission: 2.01 txn/s, expired: 2.01 txn/s, latency: 2091.85 ms, (p50: 1800 ms, p70: 2300, p90: 3300 ms, p99: 4800 ms), latency samples: 128640
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> fb1d2637d998a4f4321bd1aefd5619a80d675c57 passed
Upgrade the remaining nodes to version: fb1d2637d998a4f4321bd1aefd5619a80d675c57
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1394.24 txn/s, submitted: 1396.02 txn/s, failed submission: 1.78 txn/s, expired: 1.78 txn/s, latency: 2167.10 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4300 ms), latency samples: 125380
Test Ok

@banool banool merged commit ab6d0ee into main Dec 11, 2024
86 of 90 checks passed
@banool banool deleted the banool/cli-5.0.0 branch December 11, 2024 19:54
georgemitenkov pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants