Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loader-v2] More tests for global manager #15563

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Dec 11, 2024

Description

Addressing loader V2 todo: adding more test cases for module manager cache flushing conditions.

How Has This Been Tested?

N/A

Key Areas to Review

Ensure all corner cases are covered.

Type of Change

  • Tests

Which Components or Systems Does This Change Impact?

  • Move/Aptos Virtual Machine

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 11, 2024

⏱️ 2h 52m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 44m 🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
check-dynamic-deps 13m 🟩🟩🟩🟩🟩 (+2 more)
rust-move-tests 13m 🟩
rust-cargo-deny 10m 🟩🟩🟩 (+2 more)
test-target-determinator 9m 🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
check 7m 🟩🟩
rust-doc-tests 6m 🟩
rust-doc-tests 5m 🟩
rust-move-tests 4m
fetch-last-released-docker-image-tag 3m 🟩🟩
general-lints 3m 🟩🟩🟩🟩 (+2 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

georgemitenkov commented Dec 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@georgemitenkov georgemitenkov marked this pull request as ready for review December 11, 2024 19:24
@georgemitenkov georgemitenkov requested review from runtian-zhou, vgao1996, igor-aptos and ziaptos and removed request for sasha8 and danielxiangzl December 11, 2024 19:24
@georgemitenkov georgemitenkov force-pushed the george/loader-tests branch 2 times, most recently from b6cc482 to 9e2b857 Compare December 14, 2024 01:42
@georgemitenkov georgemitenkov enabled auto-merge (squash) December 14, 2024 01:47

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 15061.69 txn/s, latency: 2128.23 ms, (p50: 1800 ms, p70: 1800, p90: 2100 ms, p99: 19300 ms), latency samples: 521380
2. Upgrading first Validator to new version: 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6387.58 txn/s, latency: 4374.13 ms, (p50: 4700 ms, p70: 5100, p90: 5800 ms, p99: 6300 ms), latency samples: 115600
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7239.12 txn/s, latency: 4494.30 ms, (p50: 4800 ms, p70: 4900, p90: 4900 ms, p99: 5000 ms), latency samples: 244060
3. Upgrading rest of first batch to new version: 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5403.66 txn/s, latency: 5419.76 ms, (p50: 6000 ms, p70: 6400, p90: 6700 ms, p99: 7500 ms), latency samples: 103720
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5435.63 txn/s, latency: 6139.27 ms, (p50: 6700 ms, p70: 6800, p90: 7000 ms, p99: 7100 ms), latency samples: 186260
4. upgrading second batch to new version: 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10556.56 txn/s, latency: 2592.32 ms, (p50: 2300 ms, p70: 3100, p90: 4100 ms, p99: 4300 ms), latency samples: 191640
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10825.65 txn/s, latency: 2850.70 ms, (p50: 2400 ms, p70: 3800, p90: 4300 ms, p99: 4500 ms), latency samples: 359960
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3

two traffics test: inner traffic : committed: 14845.54 txn/s, latency: 2678.24 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5644640
two traffics test : committed: 100.04 txn/s, latency: 1330.79 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 1600 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.583, avg: 1.537", "ConsensusProposalToOrdered: max: 0.303, avg: 0.291", "ConsensusOrderedToCommit: max: 0.297, avg: 0.292", "ConsensusProposalToCommit: max: 0.587, avg: 0.582"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.93s no progress at version 23330 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 2786349 (avg 0.55s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3 (PR)
Upgrade the nodes to version: 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1398.44 txn/s, submitted: 1400.92 txn/s, failed submission: 2.48 txn/s, expired: 2.48 txn/s, latency: 2208.51 ms, (p50: 2100 ms, p70: 2300, p90: 3000 ms, p99: 4700 ms), latency samples: 124120
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1381.83 txn/s, submitted: 1385.18 txn/s, failed submission: 3.36 txn/s, expired: 3.36 txn/s, latency: 2188.18 ms, (p50: 2100 ms, p70: 2400, p90: 3000 ms, p99: 4500 ms), latency samples: 123460
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3 passed
Upgrade the remaining nodes to version: 1bfc0a1aca7cff695a5887b7e4f5a482b704dca3
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1396.10 txn/s, submitted: 1398.36 txn/s, failed submission: 2.26 txn/s, expired: 2.26 txn/s, latency: 2176.97 ms, (p50: 2100 ms, p70: 2400, p90: 3100 ms, p99: 4400 ms), latency samples: 123300
Test Ok

@georgemitenkov georgemitenkov merged commit f69598f into main Dec 16, 2024
46 checks passed
@georgemitenkov georgemitenkov deleted the george/loader-tests branch December 16, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants