-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loader-v2] More tests for global manager #15563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 2h 52m total CI duration on this PR
|
georgemitenkov
requested review from
gelash,
zekun000,
sasha8 and
danielxiangzl
as code owners
December 11, 2024 19:24
georgemitenkov
requested review from
runtian-zhou,
vgao1996,
igor-aptos and
ziaptos
and removed request for
sasha8 and
danielxiangzl
December 11, 2024 19:24
gelash
approved these changes
Dec 11, 2024
gelash
reviewed
Dec 11, 2024
georgemitenkov
force-pushed
the
george/loader-tests
branch
from
December 11, 2024 21:55
17c16db
to
ed536e3
Compare
zekun000
approved these changes
Dec 11, 2024
runtian-zhou
approved these changes
Dec 12, 2024
georgemitenkov
force-pushed
the
george/loader-tests
branch
2 times, most recently
from
December 14, 2024 01:42
b6cc482
to
9e2b857
Compare
georgemitenkov
force-pushed
the
george/loader-tests
branch
from
December 14, 2024 01:46
9e2b857
to
fff4bbf
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gelash
approved these changes
Dec 14, 2024
georgemitenkov
force-pushed
the
george/loader-tests
branch
from
December 16, 2024 00:56
fff4bbf
to
1bfc0a1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing loader V2 todo: adding more test cases for module manager cache flushing conditions.
How Has This Been Tested?
N/A
Key Areas to Review
Ensure all corner cases are covered.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist