Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dummy #15815

Draft
wants to merge 1 commit into
base: aptos-release-v1.25
Choose a base branch
from
Draft

dummy #15815

wants to merge 1 commit into from

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Jan 25, 2025

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 25, 2025

⏱️ 58m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-unit-tests 26m 🟥
forge-framework-upgrade-test / forge 14m 🟩
rust-move-tests 7m 🟥
test-target-determinator 4m 🟩
rust-cargo-deny 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
check-dynamic-deps 1m 🟩🟩
semgrep/ci 48s 🟩🟩
general-lints 27s 🟩
file_change_determinator 20s 🟩
file_change_determinator 10s 🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩
determine-docker-build-metadata 3s 🟩
permission-check 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 39s 2m -72%

settingsfeedbackdocs ⋅ learn more about trunk.io

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite framework_upgrade success on e07212d19a17186e03260fcc1bce53b4ffbadc64 ==> 35eeab4ef1e111fecd30be9b267cbf5152177513

Compatibility test results for e07212d19a17186e03260fcc1bce53b4ffbadc64 ==> 35eeab4ef1e111fecd30be9b267cbf5152177513 (PR)
Upgrade the nodes to version: 35eeab4ef1e111fecd30be9b267cbf5152177513
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1480.63 txn/s, submitted: 1482.85 txn/s, failed submission: 2.23 txn/s, expired: 2.23 txn/s, latency: 2099.23 ms, (p50: 1800 ms, p70: 2100, p90: 3400 ms, p99: 5100 ms), latency samples: 133020
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1326.48 txn/s, submitted: 1330.11 txn/s, failed submission: 3.63 txn/s, expired: 3.63 txn/s, latency: 2197.56 ms, (p50: 1800 ms, p70: 2400, p90: 3600 ms, p99: 4500 ms), latency samples: 116880
5. check swarm health
Compatibility test for e07212d19a17186e03260fcc1bce53b4ffbadc64 ==> 35eeab4ef1e111fecd30be9b267cbf5152177513 passed
Upgrade the remaining nodes to version: 35eeab4ef1e111fecd30be9b267cbf5152177513
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1431.64 txn/s, submitted: 1433.91 txn/s, failed submission: 2.26 txn/s, expired: 2.26 txn/s, latency: 2122.92 ms, (p50: 1800 ms, p70: 2100, p90: 3300 ms, p99: 4700 ms), latency samples: 126580
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant