Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Rest api docs #3774

Merged
merged 3 commits into from
Sep 7, 2022
Merged

[api] Rest api docs #3774

merged 3 commits into from
Sep 7, 2022

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Sep 2, 2022

Description

I went through and added documentation to every single object. I did do it late at night, so it might not be the most comprehensive, but it does give some better documentation accordingly.

(If you guys need to see the site, I can always bring it up for you)

Test Plan

Tested locally with my browser and a local testnet node


This change is Reviewable

banool
banool previously requested changes Sep 2, 2022
api/src/accounts.rs Show resolved Hide resolved
api/src/accounts.rs Outdated Show resolved Hide resolved
api/src/accounts.rs Show resolved Hide resolved
api/src/accounts.rs Show resolved Hide resolved
api/src/accounts.rs Outdated Show resolved Hide resolved
api/src/transactions.rs Outdated Show resolved Hide resolved
api/types/src/derives.rs Outdated Show resolved Hide resolved
api/types/src/event_key.rs Outdated Show resolved Hide resolved
api/types/src/mime_types.rs Outdated Show resolved Hide resolved
api/types/src/move_types.rs Outdated Show resolved Hide resolved
Now all objects have documentation in the OpenAPI spec, along with
in the website that gives information accordingly
@gregnazario gregnazario requested a review from banool September 3, 2022 07:01
@gregnazario gregnazario dismissed banool’s stale review September 3, 2022 07:02

Adjusted based on requests

Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay, will leave it to @banool to do a more thorough review.

@gregnazario
Copy link
Contributor Author

@banool can you take a look?

api/src/state.rs Show resolved Hide resolved
@@ -30,7 +33,11 @@ impl BlocksApi {
async fn get_block_by_height(
&self,
accept_type: AcceptType,
/// Block height to lookup. Starts at 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: too many spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants