Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Remove conflicting documentation for OpenAPI spec #4007

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Sep 9, 2022

Description

Turns out open API spec generation was building a version that wasn't compatible with some client generators. This removes conflicting documentation for now

Test Plan

Runs with a Go generator


This change is Reviewable

Turns out open API spec generation was building a version that wasn't compatible
with some client generators.
@gregnazario gregnazario enabled auto-merge (rebase) September 9, 2022 00:32
@gregnazario gregnazario disabled auto-merge September 9, 2022 00:36
@gregnazario gregnazario merged commit df2b4b0 into aptos-labs:main Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Forge is running suite compat on testnet ==> 58626e984f19e02e2631b690dadede2124f0b778

Forge is running suite land_blocking on 58626e984f19e02e2631b690dadede2124f0b778

✅ Forge suite land_blocking success on 58626e984f19e02e2631b690dadede2124f0b778

performance benchmark with full nodes : 6854 TPS, 4355 ms latency, 6050 ms p99 latency,no expired txns
Test Ok

✅ Forge suite compat success on testnet ==> 58626e984f19e02e2631b690dadede2124f0b778

Compatibility test results for testnet ==> 58626e984f19e02e2631b690dadede2124f0b778 (PR)
1. Check liveness of validators at old version: testnet
compatibility::simple-validator-upgrade::liveness-check : 7915 TPS, 3111 ms latency, 4850 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 58626e984f19e02e2631b690dadede2124f0b778
compatibility::simple-validator-upgrade::single-validator-upgrade : 5698 TPS, 3743 ms latency, 5300 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 58626e984f19e02e2631b690dadede2124f0b778
compatibility::simple-validator-upgrade::half-validator-upgrade : 5263 TPS, 3965 ms latency, 5200 ms p99 latency,no expired txns
4. upgrading second batch to new version: 58626e984f19e02e2631b690dadede2124f0b778
compatibility::simple-validator-upgrade::rest-validator-upgrade : 5941 TPS, 3199 ms latency, 4150 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet ==> 58626e984f19e02e2631b690dadede2124f0b778 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants