[refactor] cleanup warnings

package.json

@@ -11,7 +11,7 @@
     }
   },
   "dependencies": {
-    "@apollo/client": "^3.12.3",
+    "@apollo/client": "^3.12.5",
     "@aptos-labs/ts-sdk": "^1.33.1",
     "@aptos-labs/wallet-adapter-mui-design": "3.0.23",
     "@aptos-labs/wallet-adapter-react": "3.7.9",

src/api/hooks/useGetANS.ts

@@ -65,7 +65,7 @@ export function useGetNameFromAddress(
   return queryResult.data ?? undefined;
 }
 
-// this function will return null if ans name not found to prevent useQuery complaining about undefined return
+// this function will return null if ANS name not found to prevent useQuery complaining about undefined return
 // source for full context: https://tanstack.com/query/v4/docs/react/guides/migrating-to-react-query-4#undefined-is-an-illegal-cache-value-for-successful-queries
 async function genANSName(
   address: string,

src/api/hooks/useGetAccount.ts

@@ -10,11 +10,9 @@ export function useGetAccount(
 ) {
   const [state] = useGlobalState();
 
-  const result = useQuery<Types.AccountData, ResponseError>({
+  return useQuery<Types.AccountData, ResponseError>({
     queryKey: ["account", {address}, state.network_value],
     queryFn: () => getAccount({address}, state.aptos_client),
     retry: options?.retry ?? false,
   });
-
-  return result;
 }

src/api/hooks/useGetAccountAllTransactions.ts

@@ -61,11 +61,9 @@ export function useGetAccountAllTransactionVersions(
     return [];
   }
 
-  const versions: number[] = data.account_transactions.map(
+  return data.account_transactions.map(
     (resource: {transaction_version: number}) => {
       return resource.transaction_version;
     },
   );
-
-  return versions;
 }

src/api/hooks/useGetAccountResources.ts

@@ -1,7 +1,7 @@
 import {Types} from "aptos";
 import {useQuery, UseQueryResult} from "@tanstack/react-query";
-import {getAccountResources} from "../../api";
-import {ResponseError} from "../../api/client";
+import {getAccountResources} from "../index";
+import {ResponseError} from "../client";
 import {useGlobalState} from "../../global-config/GlobalConfig";
 
 export function useGetAccountResources(

src/api/hooks/useGetAccountTransactions.ts

@@ -11,10 +11,7 @@ export function useGetAccountTransactions(
 ): UseQueryResult<Array<Types.Transaction>, ResponseError> {
   const [state] = useGlobalState();
 
-  const accountTransactionsResult = useQuery<
-    Array<Types.Transaction>,
-    ResponseError
-  >({
+  return useQuery<Array<Types.Transaction>, ResponseError>({
     queryKey: [
       "accountTransactions",
       {address, start, limit},
@@ -23,6 +20,4 @@ export function useGetAccountTransactions(
     queryFn: () =>
       getAccountTransactions({address, start, limit}, state.aptos_client),
   });
-
-  return accountTransactionsResult;
 }

src/api/hooks/useGetPrice.ts

@@ -36,7 +36,8 @@ export async function getPrice(
     });
 
     if (!response.ok) {
-      throw new Error(`HTTP error! Status: ${response.status}`);
+      console.error(`HTTP error! Status: ${response.status}`);
+      return null;
     }
 
     const data = await response.json();

src/api/hooks/useGetTransaction.ts

@@ -1,16 +1,14 @@
 import {Types} from "aptos";
 import {useQuery} from "@tanstack/react-query";
-import {getTransaction} from "../../api";
-import {ResponseError} from "../../api/client";
+import {getTransaction} from "../index";
+import {ResponseError} from "../client";
 import {useGlobalState} from "../../global-config/GlobalConfig";
 
 export function useGetTransaction(txnHashOrVersion: string) {
   const [state] = useGlobalState();
 
-  const result = useQuery<Types.Transaction, ResponseError>({
+  return useQuery<Types.Transaction, ResponseError>({
     queryKey: ["transaction", {txnHashOrVersion}, state.network_value],
     queryFn: () => getTransaction({txnHashOrVersion}, state.aptos_client),
   });
-
-  return result;
 }

src/api/hooks/useGetUserTransactionVersions.ts

@@ -36,11 +36,7 @@ export default function useGetUserTransactionVersions(
     return [];
   }
 
-  const versions: number[] = data.user_transactions.map(
-    (txn: {version: number}) => {
-      return txn.version;
-    },
-  );
-
-  return versions;
+  return data.user_transactions.map((txn: {version: number}) => {
+    return txn.version;
+  });
 }

src/api/hooks/useGraphqlClient.tsx

@@ -1,14 +1,13 @@
-import React from "react";
+import React, {useEffect, useState} from "react";
 import {
   ApolloClient,
-  InMemoryCache,
+  ApolloLink,
   ApolloProvider,
   HttpLink,
+  InMemoryCache,
   NormalizedCacheObject,
-  ApolloLink,
 } from "@apollo/client";
-import {useEffect, useState} from "react";
-import {NetworkName, getApiKey} from "../../constants";
+import {getApiKey, NetworkName} from "../../constants";
 import {useGlobalState} from "../../global-config/GlobalConfig";
 
 function getIsGraphqlClientSupportedFor(networkName: NetworkName): boolean {
@@ -81,9 +80,5 @@ export function GraphqlClientProvider({children}: GraphqlClientProviderProps) {
 
 export function useGetIsGraphqlClientSupported(): boolean {
   const [state] = useGlobalState();
-  const isGraphqlClientSupported = getIsGraphqlClientSupportedFor(
-    state.network_name,
-  );
-
-  return isGraphqlClientSupported;
+  return getIsGraphqlClientSupportedFor(state.network_name);
 }

src/api/index.ts

@@ -270,18 +270,6 @@ export async function getValidatorCommissionChange(
   return withResponseError(client.view(payload));
 }
 
-export async function getDelegationPoolExist(
-  client: AptosClient,
-  validatorAddress: Types.Address,
-): Promise<Types.MoveValue[]> {
-  const payload: Types.ViewRequest = {
-    function: "0x1::delegation_pool::delegation_pool_exists",
-    type_arguments: [],
-    arguments: [validatorAddress],
-  };
-  return withResponseError(client.view(payload));
-}
-
 // Return whether `pending_inactive` stake can be directly withdrawn from the delegation pool,
 // for the edge case when the validator had gone inactive before its lockup expired.
 export async function getCanWithdrawPendingInactive(
@@ -321,7 +309,7 @@ export async function getValidatorState(
   return withResponseError(client.view(payload));
 }
 
-export async function getValidatorCommisionAndState(
+export async function getValidatorCommissionAndState(
   client: AptosClient,
   validatorAddresses: Types.Address[],
 ): Promise<Types.MoveValue[]> {

src/api/query-utils.ts

@@ -13,7 +13,7 @@ type CombinedQueryResultState = {
  * @returns
  * @example
  * const {
- *  combinedQueryState: {error, isLoading}},
+ *  combinedQueryState: {error, isLoading},
  *  queries: [query1, query2, query3],
  * } = combineQueries([
  * useQuery(...),

src/components/AmountTextField.tsx

@@ -20,7 +20,7 @@ export default function AmountTextField({
   warnMessage,
   onAmountChange,
   balance,
-}: AmountTextFieldProps): JSX.Element {
+}: AmountTextFieldProps) {
   return (
     <FormControl fullWidth>
       <Stack direction="row" justifyContent="space-between">

src/components/GoBack.tsx

@@ -24,7 +24,7 @@ function BackButton(handleClick: () => void) {
   );
 }
 
-export default function GoBack(): JSX.Element | null {
+export default function GoBack() {
   const navigate = useNavigate();
 
   if (window.history.state && window.history.state.idx > 0) {

src/components/HashButton.tsx

@@ -54,7 +54,7 @@ function getHashLinkStr(input: string, type: HashType): string {
   }
 }
 
-function HashLink(hash: string, type: HashType): JSX.Element {
+function HashLink(hash: string, type: HashType) {
   switch (type) {
     case HashType.ACCOUNT:
     case HashType.TRANSACTION:
@@ -206,7 +206,7 @@ function HashButtonInner({
   } else if (img) {
     icon = (
       <Box component="span" sx={{mr: 1, display: "flex", alignItems: "center"}}>
-        <img src={img} height={20} width={20} />
+        <img src={img} alt={img} height={20} width={20} />
       </Box>
     );
   }

src/components/IndividualPageContent/CollapsibleCards.tsx

@@ -4,12 +4,12 @@ import {grey} from "../../themes/colors/aptosColorPalette";
 
 // return true if there is at least 1 card is not expanded
 function getNotAllExpanded(expandedList: boolean[]): boolean {
-  return expandedList.find((expanded) => expanded === false) !== undefined;
+  return expandedList.find((expanded) => !expanded) !== undefined;
 }
 
 // return true if there is at least 1 card is expanded
 function getNotAllCollapse(expandedList: boolean[]): boolean {
-  return expandedList.find((expanded) => expanded === true) !== undefined;
+  return expandedList.find((expanded) => expanded) !== undefined;
 }
 
 type ExpandAllCollapseAllButtonsProps = {

src/components/IndividualPageContent/ContentBox.tsx

@@ -6,10 +6,7 @@ interface ContentBoxProps extends BoxProps {
   children: React.ReactNode;
 }
 
-export default function ContentBox({
-  children,
-  ...props
-}: ContentBoxProps): JSX.Element {
+export default function ContentBox({children, ...props}: ContentBoxProps) {
   const theme = useTheme();
   // TODO: unify colors for the new transaction page
   const backgroundColor = theme.palette.mode === "dark" ? grey[800] : grey[50];

src/components/IndividualPageContent/ContentBoxSpaceBetween.tsx

@@ -9,7 +9,7 @@ interface ContentBoxSpaceBetweenProps extends BoxProps {
 export default function ContentBoxSpaceBetween({
   children,
   ...props
-}: ContentBoxSpaceBetweenProps): JSX.Element {
+}: ContentBoxSpaceBetweenProps) {
   const theme = useTheme();
   const backgroundColor = theme.palette.mode === "dark" ? grey[800] : grey[50];