Install go using aqua broke gopls LSP server #710

budimanjojo · 2022-05-09T07:19:11Z

aqua version

Please use the latest version.

$ aqua -v
aqua version 1.5.1 (aaf1d8beb6965d785e0b04de4ab93021f8634640)

Environment

⚠️ aqua doesn't support Windows.

OS (Linux, macOS, etc): Linux
CPU Architecture (amd64, arm64, etc): amd64

Overview

How to reproduce

aqua.yaml

# aqua.yaml
registries:
  - type: standard
    ref: v2.13.0    # renovate: depName=aquaproj/aqua-registry

packages:
  - name: twpayne/[email protected]
  - name: junegunn/[email protected]
  - name: starship/[email protected]
  - name: ajeetdsouza/[email protected]
  - name: BurntSushi/[email protected]
  - name: sharkdp/[email protected]
  - name: sharkdp/[email protected]
  - name: ogham/[email protected]
  - name: blacknon/[email protected]
  - name: FiloSottile/[email protected]
  - name: golang/[email protected]
  - name: cli/[email protected]
  - name: go-task/[email protected]
  - name: direnv/[email protected]
  - name: kubernetes/[email protected]
  - name: fluxcd/[email protected]
  - name: kubernetes-sigs/kustomize@kustomize/v4.5.4
  - name: mozilla/[email protected]
  - name: helm/[email protected]
  - name: siderolabs/[email protected]

Actual Behaviour

When golang binary is in /usr/local/go/bin/go, My neovim which is running gopls LSP client is not crashing on package or import completion. But when golang binary is in ~/.local/share/aquaproj-aqua/bin/go, it will crash neovim without any log at all.

Important Factoids

References

x/tools/gopls: gopls crashes neovim golang/go#51643

The text was updated successfully, but these errors were encountered:

suzuki-shunsuke · 2022-05-09T08:21:44Z

It's hard to reproduce the problem because the information of How to reproduce isn't enough.
This depends on NeoVim and gopls LSP client.

budimanjojo · 2022-05-09T08:55:35Z

Yes, but it's also happening with gopls running outside of neovim though.
I also just find out something here. If I set my $PATH to $HOME/.local/share/aquaproj-aqua/pkgs/http/golang.org/dl/go1.18.1.linux-amd64.tar.gz/go/bin then it works fine again.

So the problem is only happening when the exec is handled by aqua-proxy. Maybe there's something that aqua-proxy does that can cause this?

suzuki-shunsuke · 2022-05-09T09:33:49Z

https://aquaproj.github.io/docs/reference/lazy-install

aqua-proxy internally executes the command aqua exec -- <command> ....

https://github.com/aquaproj/aqua-proxy/blob/bb56ec820a8a0a0caac98563993de705465c672e/pkg/cli/proxy.go#L24-L39

budimanjojo · 2022-05-09T10:04:56Z

Very weird, I'm looking at aqua exec and it basically just run the program using os/exec, Can we have aqua to not use aqua-proxy for several command in the yaml file? maybe just symlink $ROOT_DIR/pkgs/.../binaryfile to $ROOT_DIR/bin/binaryfile

I just tried symlinking $HOME/.local/share/aquaproj-aqua/pkgs/http/golang.org/dl/go1.18.1.linux-amd64.tar.gz/go/bin/go to $HOME/.local/share/aquaproj-aqua/bin/go and it runs fine again.
Can you show me what I should do to debug this?

suzuki-shunsuke · 2022-05-09T10:37:29Z

Can we have aqua to not use aqua-proxy for several command in the yaml file?

You can execute tools installed by aqua without aqua-proxy by aqua exec.

e.g.

$ aqua exec -- go version
go version go1.18.1 darwin/arm64

suzuki-shunsuke · 2022-05-09T10:41:12Z

You can reproduce the problem by running gopls -rpc.trace -v check main.go, right?

budimanjojo · 2022-05-09T11:05:59Z

You can reproduce the problem by running gopls -rpc.trace -v check main.go, right?

I use this golang/go#51643 (comment)

I run gopls daemon, then in my LSP client (which is neovim), I use gopls -remote=localhost:8091 to connect to the server. It crashes only when I'm completing package and import with the LSP client.
I just tried to compare the output of gopls -rpc.trace -v check main.go with and without aqua-proxy and they all produce the same output except GOROOT is different. Completing everything works fine except for package and import, which is weird.

budimanjojo · 2022-05-09T11:08:31Z

@suzuki-shunsuke what code editor are u using? Maybe I can try to reproduce this in vscode too?

suzuki-shunsuke · 2022-05-09T11:14:05Z

I'm using NeoVim.

macOS arm64

$ nvim --version
NVIM v0.7.0
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by [email protected]

$ aqua which go
/Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/http/golang.org/dl/go1.18.1.darwin-arm64.tar.gz/go/bin/go

$ go version
go version go1.18.1 darwin/arm64

$ which go
/Users/shunsukesuzuki/.local/share/aquaproj-aqua/bin/go

$ gopls version
golang.org/x/tools/gopls v0.7.5
    golang.org/x/tools/[email protected] h1:8Az52YwcFXTWPvrRomns1C0N+zlgTyyPKWvRazO9GG8=

budimanjojo · 2022-05-09T12:55:57Z

Try this:

Backup your ~/.config/nvim/
Put this into ~/.config/nvim/init.lua:

local on_windows = vim.loop.os_uname().version:match 'Windows'

local function join_paths(...)
  local path_sep = on_windows and '\\' or '/'
  local result = table.concat({ ... }, path_sep)
  return result
end

vim.cmd [[set runtimepath=$VIMRUNTIME]]

local temp_dir = vim.loop.os_getenv 'TEMP' or '/tmp'

vim.cmd('set packpath=' .. join_paths(temp_dir, 'nvim', 'site'))

local package_root = join_paths(temp_dir, 'nvim', 'site', 'pack')
local install_path = join_paths(package_root, 'packer', 'start', 'packer.nvim')
local compile_path = join_paths(install_path, 'plugin', 'packer_compiled.lua')

local function load_plugins()
  require('packer').startup {
    {
      'wbthomason/packer.nvim',
      'neovim/nvim-lspconfig',
      'hrsh7th/nvim-cmp',
      'hrsh7th/cmp-nvim-lsp',
      'saadparwaiz1/cmp_luasnip',
      'L3MON4D3/LuaSnip'
    },
    config = {
      package_root = package_root,
      compile_path = compile_path,
    },
  }
end

_G.load_config = function()
  vim.lsp.set_log_level 'trace'
  if vim.fn.has 'nvim-0.5.1' == 1 then
    require('vim.lsp.log').set_format_func(vim.inspect)
  end
  local nvim_lsp = require 'lspconfig'
  local on_attach = function(_, bufnr)
    local function buf_set_keymap(...)
      vim.api.nvim_buf_set_keymap(bufnr, ...)
    end
    local function buf_set_option(...)
      vim.api.nvim_buf_set_option(bufnr, ...)
    end

    buf_set_option('omnifunc', 'v:lua.vim.lsp.omnifunc')

    -- Mappings.
    local opts = { noremap = true, silent = true }
    buf_set_keymap('n', 'gD', '<Cmd>lua vim.lsp.buf.declaration()<CR>', opts)
    buf_set_keymap('n', 'gd', '<Cmd>lua vim.lsp.buf.definition()<CR>', opts)
    buf_set_keymap('n', 'K', '<Cmd>lua vim.lsp.buf.hover()<CR>', opts)
    buf_set_keymap('n', 'gi', '<cmd>lua vim.lsp.buf.implementation()<CR>', opts)
    buf_set_keymap('n', '<C-k>', '<cmd>lua vim.lsp.buf.signature_help()<CR>', opts)
    buf_set_keymap('n', '<space>wa', '<cmd>lua vim.lsp.buf.add_workspace_folder()<CR>', opts)
    buf_set_keymap('n', '<space>wr', '<cmd>lua vim.lsp.buf.remove_workspace_folder()<CR>', opts)
    buf_set_keymap('n', '<space>wl', '<cmd>lua print(vim.inspect(vim.lsp.buf.list_workspace_folders()))<CR>', opts)
    buf_set_keymap('n', '<space>D', '<cmd>lua vim.lsp.buf.type_definition()<CR>', opts)
    buf_set_keymap('n', '<space>rn', '<cmd>lua vim.lsp.buf.rename()<CR>', opts)
    buf_set_keymap('n', 'gr', '<cmd>lua vim.lsp.buf.references()<CR>', opts)
    buf_set_keymap('n', '<space>e', '<cmd>lua vim.diagnostic.open_float()<CR>', opts)
    buf_set_keymap('n', '[d', '<cmd>lua vim.diagnostic.goto_prev()<CR>', opts)
    buf_set_keymap('n', ']d', '<cmd>lua vim.diagnostic.goto_next()<CR>', opts)
    buf_set_keymap('n', '<space>q', '<cmd>lua vim.diagnostic.setloclist()<CR>', opts)
  end

  -- Add the server that troubles you here
  local name = 'gopls'
  local cmd = { 'gopls', 'serve' } -- needed for elixirls, omnisharp, sumneko_lua
  if not name then
    print 'You have not defined a server name, please edit minimal_init.lua'
  end
  if not nvim_lsp[name].document_config.default_config.cmd and not cmd then
    print [[You have not defined a server default cmd for a server
      that requires it please edit minimal_init.lua]]
  end

  util = require 'lspconfig/util'
  nvim_lsp[name].setup {
    cmd = cmd,
    on_attach = on_attach,
    filetypes = { 'go', 'gomod' },
    root_dir = util.root_pattern('go.work', 'go.mod', '.git'),
  }

  -- luasnip setup
  local luasnip = require 'luasnip'

  -- nvim-cmp setup
  local cmp = require 'cmp'
  cmp.setup {
    snippet = {
      expand = function(args)
        luasnip.lsp_expand(args.body)
      end,
    },
    mapping = cmp.mapping.preset.insert({
      ['<C-d>'] = cmp.mapping.scroll_docs(-4),
      ['<C-f>'] = cmp.mapping.scroll_docs(4),
      ['<C-Space>'] = cmp.mapping.complete(),
      ['<CR>'] = cmp.mapping.confirm {
        behavior = cmp.ConfirmBehavior.Replace,
        select = true,
      },
      ['<Tab>'] = cmp.mapping(function(fallback)
        if cmp.visible() then
          cmp.select_next_item()
        elseif luasnip.expand_or_jumpable() then
          luasnip.expand_or_jump()
        else
          fallback()
        end
      end, { 'i', 's' }),
      ['<S-Tab>'] = cmp.mapping(function(fallback)
        if cmp.visible() then
          cmp.select_prev_item()
        elseif luasnip.jumpable(-1) then
          luasnip.jump(-1)
        else
          fallback()
        end
      end, { 'i', 's' }),
    }),
    sources = {
      { name = 'nvim_lsp' },
      { name = 'luasnip' },
    },
  }

  print [[You can find your log at $HOME/.cache/nvim/lsp.log. Please paste in a github issue under a details tag as described in the issue template.]]
end


if vim.fn.isdirectory(install_path) == 0 then
  vim.fn.system { 'git', 'clone', 'https://github.com/wbthomason/packer.nvim', install_path }
  load_plugins()
  require('packer').sync()
  vim.cmd [[autocmd User PackerComplete ++once lua load_config()]]
else
  load_plugins()
  require('packer').sync()
  _G.load_config()
end

Now, open neovim and it will install LSP and completion module then install gopls. Exit neovim.
Create a new go-project, mkdir -p ~/go/src/goproject && cd ~/go/src/goproject
go mod init github.com/hello/goproject && nvim main.go
In neovim, press q to quit packer window and in insert mode type package and press tab, it should give you completion selection, select one and press enter. If it doesn't crash, press backspace and try again, it will crash after 2 or 3 tries. Or if it doesn't crash, continue to type import " and type some characters to trigger autocompletion, like encoding/, press tab to select from menu. Sometimes pressing tab continuously also crash neovim.

Here's my recording of the crash: https://asciinema.org/a/emF4nCQnWJpLgV2qiSkdntmPq

budimanjojo · 2022-05-10T08:05:54Z

I tried VSCode and VSCode also crash immediately.

frezbo · 2022-05-10T08:42:08Z

I can confirm vscode also crashes. Cross linking the issue from vscode-go extension: golang/vscode-go#2229

frezbo · 2022-05-10T09:10:28Z

I wonder if using exec.Command from os/exec is causing issue, since it'd be a child process as opposed to syscall.Exec

Ref: aquaproj/aqua#710 Signed-off-by: Noel Georgi <[email protected]>

suzuki-shunsuke · 2022-05-10T09:43:03Z

Oh, I didn't know this package. This is interesting.
But this is low level API, so I don't know whether we should use this.
I'll take a look.

https://pkg.go.dev/golang.org/x/[email protected]/unix#pkg-overview

The primary use of this package is inside other packages that provide a more portable interface to the system, such as "os", "time" and "net". Use those packages rather than this one if you can.

https://pkg.go.dev/golang.org/x/[email protected]/unix#Exec

syscall package is locked down. https://pkg.go.dev/syscall#pkg-overview

Deprecated: this package is locked down. Callers should use the corresponding package in the golang.org/x/sys repository instead. That is also where updates required by new systems or versions should be applied. See https://golang.org/s/go1.4-syscall for more information.

frezbo · 2022-05-10T09:48:45Z

so i think the problem is that when aqua executed a package it's a subprocess as seen from the process tree

tilix─┬─fish───viddy─┬─aqua─┬─viddy───13*[{viddy}]

as opposed to calling the binary directly from the path,

─tilix─┬─fish───viddy───9*[{viddy}]

so if using the exec sycall the calling binary is replaced by the actual program and this would also help that aqua-proxy doesn;t have to deal with environment variables, stdout, stderr etc, the aqua-proxy is replaced by the actual program. Also aqua proxy doesn't have to then deal with exit codes and process reaping

frezbo · 2022-05-10T09:53:43Z

syscall package is locked down. https://pkg.go.dev/syscall#pkg-overview

thanks for finding that, I need to update some code (forgot it was moved to sys package)

budimanjojo · 2022-05-10T10:54:28Z

Here is how my pstree looks like:

        │         ├─tmux: server─┬─fish─┬─pstree
        │         │              │      └─{fish}
        │         │              ├─fish
        │         │              └─fish───nvim─┬─gopls───8*[{gopls}]
        │         │                            └─{nvim}

gopls is the one calling go command in subprocess of aqua in the background (maybe). But it's not in the processtree.

suzuki-shunsuke · 2022-05-10T13:49:24Z

WIP aquaproj/aqua-proxy#25

suzuki-shunsuke · 2022-05-10T13:53:44Z

Maybe we can replace os.Exec in aqua exec command too.

aqua/pkg/controller/exec/exec.go

Lines 79 to 107 in 849ccae

    
           func (ctrl *Controller) execCommand(ctx context.Context, exePath string, args []string, logE *logrus.Entry) error { 
        
           	logE = logE.WithField("exe_path", exePath) 
        
           	logE.Debug("execute the command") 
        
           	for i := 0; i < 10; i++ { 
        
           		logE.Debug("execute the command") 
        
           		cmd := exec.Command(exePath, args...) 
        
           		cmd.Stdin = ctrl.stdin 
        
           		cmd.Stdout = ctrl.stdout 
        
           		cmd.Stderr = ctrl.stderr 
        
           		runner := timeout.NewRunner(0) 
        
           		if err := runner.Run(ctx, cmd); err != nil { 
        
           			exitCode := cmd.ProcessState.ExitCode() 
        
           			// https://pkg.go.dev/os#ProcessState.ExitCode 
        
           			// > ExitCode returns the exit code of the exited process, 
        
           			// > or -1 if the process hasn't exited or was terminated by a signal. 
        
           			if exitCode == -1 && ctx.Err() == nil { 
        
           				logE.WithField("retry_count", i+1).Debug("the process isn't started. retry") 
        
           				if err := wait(ctx, 10*time.Millisecond); err != nil { //nolint:gomnd 
        
           					return err 
        
           				} 
        
           				continue 
        
           			} 
        
           			logerr.WithError(logE, err).WithField("exit_code", exitCode).Debug("command was executed but it failed") 
        
           			return ecerror.Wrap(err, exitCode) 
        
           		} 
        
           		return nil 
        
           	} 
        
           	return nil 
        
           }

frezbo · 2022-05-10T14:15:17Z

Maybe we can replace os.Exec in aqua exec command too.

That'd be cool, less code to maintain

suzuki-shunsuke · 2022-05-10T15:28:49Z

WIP #715

suzuki-shunsuke · 2022-05-10T15:35:02Z

It works well. #715 aquaproj/aqua-proxy#25

The process tree is good.

$ nvim

$ pstree -s nvim                                  
-+= 00001 root /sbin/launchd
 \-+= 00743 shunsukesuzuki /System/Applications/Utilities/Terminal.app/Contents/MacOS/Terminal
   \-+= 54801 root login -pf shunsukesuzuki
     \-+= 54802 shunsukesuzuki -zsh
       \--= 46635 shunsukesuzuki nvim

frezbo · 2022-05-10T16:53:52Z

Awesome work, really appreciate fixing it this fast ❤️

suzuki-shunsuke · 2022-05-10T17:24:02Z

I've published prerelease versions.

I'd like to verify them for a while.

Please update aqua to v1.6.0-0.

$ aqua -v
aqua version 1.6.0-0 (da98e9d04300ed3daad3710389430193bf4b2248)

aqua.yaml

registries:
- type: standard
  ref: v2.14.0 # renovate: depName=aquaproj/aqua-registry
packages:
- name: neovim/[email protected]

$ aqua i # aqua-proxy would be updated to v1.1.0-0
INFO[0000] download and unarchive the package            aqua_version=1.6.0-0 package_name=aqua-proxy package_version=v1.1.0-0 program=aqua registry=

$ nvim

$ pstree -s nvim
-+= 00001 root /sbin/launchd
 \-+= 00743 shunsukesuzuki /System/Applications/Utilities/Terminal.app/Contents/MacOS/Terminal
   \-+= 75216 root login -pf shunsukesuzuki
     \-+= 75217 shunsukesuzuki -zsh
       \--= 90024 shunsukesuzuki nvim aqua.yaml

budimanjojo · 2022-05-10T17:39:54Z

Thanks! I just tested it and it works now.
Before:

             └─fish───hwatch─┬─aqua─┬─hwatch───2*[{hwatch}]
                             │      └─16*[{aqua}]
                             └─6*[{hwatch}]

After:

             ├─fish───hwatch───2*[{hwatch}]

You can close this issue or I can close it now.

suzuki-shunsuke · 2022-05-11T02:43:45Z

You are using Linux but I'm using macOS amd64 and arm64.
The difference of OS may be related, because golang.org/x/sys/unix is low level API.

budimanjojo · 2022-05-11T02:53:31Z

I see there's a commit by renovate that update the golang/x/sys digest. Can you try building from that version?

budimanjojo · 2022-05-11T03:09:46Z

You were using version from 9 releases old.
https://pkg.go.dev/golang.org/x/sys?tab=versions
ce5d925

suzuki-shunsuke · 2022-05-11T03:25:59Z

I build the latest main branch b6bd86d , but the problem isn't solved.

suzuki-shunsuke · 2022-05-11T03:29:21Z

This is just an idea, but I'm considering to release this feature as an experimental feature.
This is disabled by default, but you can enable this with environment variable.

e.g.

$ export AQUA_EXPERIMENTAL_FEATURES=x_sys_exec # comma separated

budimanjojo · 2022-05-11T03:35:25Z

This is just an idea, but I'm considering to release this feature as an experimental feature. This is disabled by default, but you can enable this with environment variable.

e.g.
$ export AQUA_EXPERIMENTAL_FEATURES=x_sys_exec # comma separated

I'm fine with this

suzuki-shunsuke · 2022-05-11T06:35:12Z

I launched Linux amd64 on macOS amd64 with lima-vm and tested, then it works good.

$ limactl --version
limactl version 0.10.0

shunsuke-suzuki@lima-default:/Users/shunsuke-suzuki/repos/src/github.com/aquaproj/aqua-registry$ hyperfine 'tfcmt -v'
Benchmark 1: tfcmt -v
  Time (mean ± σ):      60.6 ms ±   4.5 ms    [User: 19.6 ms, System: 49.8 ms]
  Range (min … max):    52.5 ms …  70.6 ms    41 runs

shunsuke-suzuki@lima-default:/Users/shunsuke-suzuki/repos/src/github.com/aquaproj/aqua-registry$ hyperfine 'ci-info -v'
Benchmark 1: ci-info -v
  Time (mean ± σ):      62.1 ms ±   7.1 ms    [User: 21.2 ms, System: 52.8 ms]
  Range (min … max):    51.4 ms …  88.5 ms    41 runs
 
shunsuke-suzuki@lima-default:/Users/shunsuke-suzuki/repos/src/github.com/aquaproj/aqua-registry$ hyperfine 'tfmigrator -v'
Benchmark 1: tfmigrator -v
  Time (mean ± σ):      76.3 ms ±  36.1 ms    [User: 27.1 ms, System: 52.4 ms]
  Range (min … max):    58.9 ms … 200.9 ms    14 runs
 
  Warning: The first benchmarking run for this command was significantly slower than the rest (200.9 ms). This could be caused by (filesystem) caches that were not filled until after the first run. You should consider using the '--warmup' option to fill those caches before the actual benchmark. Alternatively, use the '--prepare' option to clear the caches before each timing run.

budimanjojo · 2022-05-11T06:45:03Z

So the problem is only on darwin, both x86_64 and arm64? Maybe we should report to upstream? Or maybe there's a way to make os/exec work without spawning child process?

suzuki-shunsuke · 2022-05-11T06:47:54Z

So the problem is only on darwin, both x86_64 and arm64?

The issue is reproduced on both darwin amd64 and darwin arm64.

suzuki-shunsuke · 2022-05-11T06:54:26Z

Maybe we should report to upstream?

To report to upstream, we want to find the procedure to reproduce the issue with less dependencies.

frezbo · 2022-05-11T08:19:06Z

sorry I couldn't be of much help with darwin

suzuki-shunsuke · 2022-05-11T13:46:21Z

I've released the prerelease version aqua-proxy v1.1.0-1 and aqua v1.6.0-2.

https://github.com/aquaproj/aqua-proxy/releases/tag/v1.1.0-1
https://github.com/aquaproj/aqua/releases/tag/v1.6.0-2

Please set the environment variable AQUA_EXPERIMENTAL_X_SYS_EXEC to use the feature.

#725

$ export AQUA_EXPERIMENTAL_X_SYS_EXEC=true

The problem has been reproduced with GitHub Actions.
https://github.com/suzuki-shunsuke/aqua-benchmark/runs/6389050750?check_suite_focus=true

Refs: aquaproj/aqua#710 golang/go#51643

Use aqua experimental `exec` mode Ref: aquaproj/aqua#710 (comment) Signed-off-by: Noel Georgi <[email protected]>

frezbo · 2022-05-12T10:36:57Z

I've tested with aqua version v1.6.0-2 and setting the AQUA_EXPERIMENTAL_X_SYS_EXEC to true. Seems to work fine

suzuki-shunsuke · 2022-05-12T10:43:04Z

Thank you for your confirmation.
I'll release aqua-proxy v1.1.0 and aqua v1.6.0.

suzuki-shunsuke · 2022-05-12T11:25:53Z

Released.

https://github.com/aquaproj/aqua/releases/tag/v1.6.0
https://github.com/aquaproj/aqua-proxy/releases/tag/v1.1.0

And I've created an issue to track the above problem. #729

Let me close this issue now. Thank you for your contribution!

suzuki-shunsuke · 2023-05-07T00:16:41Z

@budimanjojo @frezbo
I've released aqua v2.5.0.
https://github.com/aquaproj/aqua/releases/tag/v2.5.0
This release would solve this issue by default in other than Windows without any setting such as AQUA_EXPERIMENTAL_X_SYS_EXEC.
For details, please see the release.

budimanjojo · 2023-05-07T03:43:34Z

@suzuki-shunsuke Tested and it works fine without the env variable on v2.5.0. Thanks!

frezbo · 2023-05-07T06:52:36Z

Thanks for following this up after a long time ❤️

frezbo mentioned this issue May 10, 2022

vscode crashes with vscode-go extension enabled and editing a go file golang/vscode-go#2229

Closed

frezbo added a commit to frezbo/dotfiles that referenced this issue May 10, 2022

fix: call go binary directly, no forking

409d3e7

Ref: aquaproj/aqua#710 Signed-off-by: Noel Georgi <[email protected]>

suzuki-shunsuke mentioned this issue May 10, 2022

feat: replace os.Exec to unix.Exec aquaproj/aqua-proxy#25

Merged

suzuki-shunsuke mentioned this issue May 10, 2022

feat: replace os/exec to golang.org/x/sys/unix #715

Merged

suzuki-shunsuke mentioned this issue May 10, 2022

chore: update aqua-proxy to v1.1.0-0 #720

Merged

This was referenced May 11, 2022

Support experimental features #725

Closed

feat: support AQUA_EXPERIMENTAL_X_SYS_EXEC aquaproj/aqua-proxy#28

Merged

feat: support AQUA_EXPERIMENTAL_X_SYS_EXEC #726

Merged

budimanjojo added a commit to budimanjojo/nix-config that referenced this issue May 11, 2022

fix(aqua): fix aqua-proxy crashing gopls

6386243

Refs: aquaproj/aqua#710 golang/go#51643

frezbo added a commit to frezbo/dotfiles that referenced this issue May 12, 2022

chore: use aqua experimental exec mode

af159b7

Use aqua experimental `exec` mode Ref: aquaproj/aqua#710 (comment) Signed-off-by: Noel Georgi <[email protected]>

suzuki-shunsuke mentioned this issue May 12, 2022

aqua freezes when AQUA_EXPERIMENTAL_X_SYS_EXEC is enabled on macOS #729

Closed

suzuki-shunsuke closed this as completed May 12, 2022

hyangah mentioned this issue Jun 7, 2022

The window has crashed, reason: 'crashed', code: '-1073741819' on Windows golang/vscode-go#2280

Closed

hyangah mentioned this issue Jan 25, 2023

gopls is causing termination of vscode window with no prompt or warning golang/vscode-go#2625

Closed

suzuki-shunsuke mentioned this issue Jan 30, 2023

Aqua managed gopls is causing termination of VSCode #1597

Closed

suzuki-shunsuke mentioned this issue May 3, 2023

Execute commands by execve(2) by default #1925

Closed

hyangah mentioned this issue Jul 7, 2023

x/tools/gopls: design UX around version skew resulting from the forward compatibility proposal golang/go#61185

Open

Install go using aqua broke gopls LSP server #710

Install go using aqua broke gopls LSP server #710

Comments

budimanjojo commented May 9, 2022 • edited Loading

aqua version

Environment

Overview

How to reproduce

Actual Behaviour

Important Factoids

References

suzuki-shunsuke commented May 9, 2022 • edited Loading

budimanjojo commented May 9, 2022

suzuki-shunsuke commented May 9, 2022

budimanjojo commented May 9, 2022

suzuki-shunsuke commented May 9, 2022 • edited Loading

suzuki-shunsuke commented May 9, 2022

budimanjojo commented May 9, 2022

budimanjojo commented May 9, 2022

suzuki-shunsuke commented May 9, 2022 • edited Loading

budimanjojo commented May 9, 2022

budimanjojo commented May 10, 2022

frezbo commented May 10, 2022

frezbo commented May 10, 2022

suzuki-shunsuke commented May 10, 2022

frezbo commented May 10, 2022 • edited Loading

frezbo commented May 10, 2022

budimanjojo commented May 10, 2022

suzuki-shunsuke commented May 10, 2022

suzuki-shunsuke commented May 10, 2022

frezbo commented May 10, 2022

suzuki-shunsuke commented May 10, 2022

suzuki-shunsuke commented May 10, 2022

frezbo commented May 10, 2022

suzuki-shunsuke commented May 10, 2022

budimanjojo commented May 10, 2022

suzuki-shunsuke commented May 11, 2022 • edited Loading

budimanjojo commented May 11, 2022

budimanjojo commented May 11, 2022

suzuki-shunsuke commented May 11, 2022

suzuki-shunsuke commented May 11, 2022 • edited Loading

budimanjojo commented May 11, 2022

suzuki-shunsuke commented May 11, 2022

budimanjojo commented May 11, 2022 • edited Loading

suzuki-shunsuke commented May 11, 2022

suzuki-shunsuke commented May 11, 2022

frezbo commented May 11, 2022

suzuki-shunsuke commented May 11, 2022 • edited Loading

frezbo commented May 12, 2022

suzuki-shunsuke commented May 12, 2022

suzuki-shunsuke commented May 12, 2022

suzuki-shunsuke commented May 7, 2023 • edited Loading

budimanjojo commented May 7, 2023

frezbo commented May 7, 2023

budimanjojo commented May 9, 2022 •

edited

Loading

suzuki-shunsuke commented May 9, 2022 •

edited

Loading

suzuki-shunsuke commented May 9, 2022 •

edited

Loading

suzuki-shunsuke commented May 9, 2022 •

edited

Loading

frezbo commented May 10, 2022 •

edited

Loading

suzuki-shunsuke commented May 11, 2022 •

edited

Loading

suzuki-shunsuke commented May 11, 2022 •

edited

Loading

budimanjojo commented May 11, 2022 •

edited

Loading

suzuki-shunsuke commented May 11, 2022 •

edited

Loading

suzuki-shunsuke commented May 7, 2023 •

edited

Loading